diff options
author | Toon Claes <toon@gitlab.com> | 2022-08-05 12:13:31 +0300 |
---|---|---|
committer | Toon Claes <toon@gitlab.com> | 2022-08-08 17:49:25 +0300 |
commit | e5f57d179e81aaad65fcf31bcae3473e87c2a5d1 (patch) | |
tree | fcdf51a75ff74185e4a898ec9b14e0239f826bec | |
parent | 7948dd3c9be963d0f148015975d5a0b54ef2b04a (diff) |
linguist: Remove duplicate test
The test coverage of TestInstance_Stats_incremental and
TestInstance_Stats/old_cache is nearly identical, so remove the
duplicate test.
-rw-r--r-- | internal/gitaly/linguist/linguist_test.go | 37 |
1 files changed, 0 insertions, 37 deletions
diff --git a/internal/gitaly/linguist/linguist_test.go b/internal/gitaly/linguist/linguist_test.go index 82eb7bb95..dd663ab57 100644 --- a/internal/gitaly/linguist/linguist_test.go +++ b/internal/gitaly/linguist/linguist_test.go @@ -244,43 +244,6 @@ func TestInstance_Stats_unmarshalJSONError(t *testing.T) { require.False(t, ok, "expected the error not be a json Syntax Error") } -func TestInstance_Stats_incremental(t *testing.T) { - t.Parallel() - - cfg := testcfg.Build(t) - logger, hook := test.NewNullLogger() - ctx := testhelper.Context(t, testhelper.ContextWithLogger(logrus.NewEntry(logger))) - ctx = featureflag.ContextWithFeatureFlag(ctx, featureflag.GoLanguageStats, true) - - gitCmdFactory := gittest.NewCommandFactory(t, cfg) - - linguist, err := New(cfg, gitCmdFactory) - require.NoError(t, err) - - catfileCache := catfile.NewCache(cfg) - t.Cleanup(catfileCache.Stop) - - repoProto, repoPath := gittest.CloneRepo(t, cfg, cfg.Storages[0]) - repo := localrepo.NewTestRepo(t, cfg, repoProto) - - cleanStats, err := linguist.Stats(ctx, repo, "1e292f8fedd741b75372e19097c76d327140c312", catfileCache) - require.NoError(t, err) - require.Len(t, hook.AllEntries(), 0) - require.NoError(t, os.Remove(filepath.Join(repoPath, languageStatsFilename))) - - _, err = linguist.Stats(ctx, repo, "cfe32cf61b73a0d5e9f13e774abde7ff789b1660", catfileCache) - require.NoError(t, err) - require.Len(t, hook.AllEntries(), 0) - require.FileExists(t, filepath.Join(repoPath, languageStatsFilename)) - - incStats, err := linguist.Stats(ctx, repo, "1e292f8fedd741b75372e19097c76d327140c312", catfileCache) - require.NoError(t, err) - require.Len(t, hook.AllEntries(), 0) - require.FileExists(t, filepath.Join(repoPath, languageStatsFilename)) - - require.Equal(t, cleanStats, incStats) -} - func TestNew(t *testing.T) { cfg := testcfg.Build(t, testcfg.WithRealLinguist()) |