proto: Remove mentions of `internal/allowed`

Remove mentions of the `internal/allowed` endpoint from the comments for
error responses as this functionality may be handled differently in the
near future.

2 files changed, 15 insertions, 18 deletions

diff --git a/proto/go/gitalypb/operations.pb.go b/proto/go/gitalypb/operations.pb.go
index d455cc450..333c8b088 100644
--- a/proto/go/gitalypb/operations.pb.go
+++ b/proto/go/gitalypb/operations.pb.go
@@ -678,7 +678,7 @@ type isUserDeleteBranchError_Error interface {
 }
 
 type UserDeleteBranchError_AccessCheck struct {
-	// access_checkError is set if the RPC failed because `/internal/allowed` failed.
+	// access_check is set if the RPC failed due to an external access check.
 	AccessCheck *AccessCheckError `protobuf:"bytes,1,opt,name=access_check,json=accessCheck,proto3,oneof"`
 }
 
@@ -1069,7 +1069,7 @@ type isUserCreateTagError_Error interface {
 }
 
 type UserCreateTagError_AccessCheck struct {
-	// access_checkError is set if the RPC failed because `/internal/allowed` failed.
+	// access_check is set if the RPC failed due to an external access check.
 	AccessCheck *AccessCheckError `protobuf:"bytes,1,opt,name=access_check,json=accessCheck,proto3,oneof"`
 }
 
@@ -1373,7 +1373,7 @@ type isUserMergeBranchError_Error interface {
 }
 
 type UserMergeBranchError_AccessCheck struct {
-	// access_checkError is set if the RPC failed because `/internal/allowed` failed.
+	// access_check is set if the RPC failed due to an external access check.
 	AccessCheck *AccessCheckError `protobuf:"bytes,1,opt,name=access_check,json=accessCheck,proto3,oneof"`
 }
 
@@ -2294,8 +2294,7 @@ type UserCherryPickError_ChangesAlreadyApplied struct {
 }
 
 type UserCherryPickError_AccessCheck struct {
-	// access_check is returned in case GitLab's `/internal/allowed` endpoint rejected
-	// the change.
+	// access_check is set if the RPC failed due to an external access check.
 	AccessCheck *AccessCheckError `protobuf:"bytes,4,opt,name=access_check,json=accessCheck,proto3,oneof"`
 }
 
@@ -3131,7 +3130,7 @@ type isUserCommitFilesError_Error interface {
 }
 
 type UserCommitFilesError_AccessCheck struct {
-	// access_checkError is set if the RPC failed because `/internal/allowed` failed.
+	// access_check is set if the RPC failed due to an external access check.
 	AccessCheck *AccessCheckError `protobuf:"bytes,1,opt,name=access_check,json=accessCheck,proto3,oneof"`
 }
 
@@ -3564,8 +3563,7 @@ type UserRebaseConfirmableError_RebaseConflict struct {
 }
 
 type UserRebaseConfirmableError_AccessCheck struct {
-	// access_checkError is returned in case GitLab's `/internal/allowed` endpoint rejected
-	// the change.
+	// access_check is set if the RPC failed due to an external access check.
 	AccessCheck *AccessCheckError `protobuf:"bytes,2,opt,name=access_check,json=accessCheck,proto3,oneof"`
 }
 
diff --git a/proto/operations.proto b/proto/operations.proto
index 8129709c5..4b6264bb7 100644
--- a/proto/operations.proto
+++ b/proto/operations.proto
@@ -297,7 +297,7 @@ message UserDeleteBranchResponse {
 // defined error cases.
 message UserDeleteBranchError {
   oneof error {
-    // access_checkError is set if the RPC failed because `/internal/allowed` failed.
+    // access_check is set if the RPC failed due to an external access check.
     AccessCheckError access_check = 1;
     // reference_updateError is set if the RPC failed because updating the
     // reference to the new object ID has failed.
@@ -376,7 +376,7 @@ message UserCreateTagResponse {
 // userCreateTag fails.
 message UserCreateTagError {
   oneof error {
-    // access_checkError is set if the RPC failed because `/internal/allowed` failed.
+    // access_check is set if the RPC failed due to an external access check.
     AccessCheckError access_check = 1;
     // reference_updateError is set if the RPC failed because updating the
     // reference to the new object ID has failed.
@@ -445,7 +445,7 @@ message UserMergeBranchResponse {
 // details in case UserMergeBranch fails.
 message UserMergeBranchError {
   oneof error {
-    // access_checkError is set if the RPC failed because `/internal/allowed` failed.
+    // access_check is set if the RPC failed due to an external access check.
     AccessCheckError access_check = 1;
     // reference_updateError is set if the RPC failed because updating the
     // reference to the new object ID has failed.
@@ -508,8 +508,9 @@ message UserMergeToRefResponse {
   // commit_id is the object ID of the computed merge commit.
   string commit_id = 1;
 
-  // PreReceiveError had never been set because this RPC does not perform authentication via
-  // `/internal/allowed`. This field was thus removed without replacement.
+  // pre_receive_error had never been set because this RPC does not perform
+  // authentication and authorization via an external endpoint. This field was
+  // thus removed without replacement.
   reserved "pre_receive_error";
   reserved 2;
 }
@@ -672,8 +673,7 @@ message UserCherryPickError {
     NotAncestorError target_branch_diverged = 2;
     // changes_already_applied is returned if the result after applying the cherry pick is empty.
     ChangesAlreadyAppliedError changes_already_applied = 3;
-    // access_check is returned in case GitLab's `/internal/allowed` endpoint rejected
-    // the change.
+    // access_check is set if the RPC failed due to an external access check.
     AccessCheckError access_check = 4;
   }
 }
@@ -874,7 +874,7 @@ message UserCommitFilesResponse {
 // defined error cases.
 message UserCommitFilesError {
   oneof error {
-    // access_checkError is set if the RPC failed because `/internal/allowed` failed.
+    // access_check is set if the RPC failed due to an external access check.
     AccessCheckError access_check = 1;
     // index_update is set to the error message when an operation conflicts with the repository
     // index, such as creating a file that already exists.
@@ -995,8 +995,7 @@ message UserRebaseConfirmableError {
     // commit fails with a merge conflict and in case merge squashing commits
     // fails with a merge conflict.
     MergeConflictError rebase_conflict = 1;
-    // access_checkError is returned in case GitLab's `/internal/allowed` endpoint rejected
-    // the change.
+    // access_check is set if the RPC failed due to an external access check.
     AccessCheckError access_check = 2;
   }
 }