diff options
| author | Jacob Vosmaer (GitLab) <jacob@gitlab.com> | 2017-10-11 16:25:35 +0300 |
|---|---|---|
| committer | Zeger-Jan van de Weg <zegerjan@gitlab.com> | 2017-10-11 16:25:35 +0300 |
| commit | 37a4e78ba0cc3a9f5d53ba70c28af99a3b3c3c08 (patch) | |
| tree | d60cc2ca2ca9d5d2c177ac6083c428f5403e96c9 | |
| parent | 75c18a13b4ba1cdbab0b2cb6818e88b11ff2dd46 (diff) | |
Deprecate implementation of RepositoryService.Exists
| -rw-r--r-- | CHANGELOG.md | 3 | ||||
| -rw-r--r-- | internal/service/repository/repository.go | 3 | ||||
| -rw-r--r-- | internal/service/repository/repository_test.go | 2 |
3 files changed, 6 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2a98b6b70..9123a2098 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,9 +2,12 @@ UNRELEASED +- Deprecate implementation of RepositoryService.Exists + https://gitlab.com/gitlab-org/gitaly/merge_requests/408 - Use gitaly-proto 0.42.0 https://gitlab.com/gitlab-org/gitaly/merge_requests/407 + v0.46.0 - Add a Rails logger to ruby-git diff --git a/internal/service/repository/repository.go b/internal/service/repository/repository.go index df45fd0d6..726b04f0b 100644 --- a/internal/service/repository/repository.go +++ b/internal/service/repository/repository.go @@ -8,8 +8,9 @@ import ( "gitlab.com/gitlab-org/gitaly/internal/rubyserver" ) +// Deprecated func (s *server) Exists(ctx context.Context, in *pb.RepositoryExistsRequest) (*pb.RepositoryExistsResponse, error) { - return s.RepositoryExists(ctx, in) + return nil, helper.Unimplemented } func (s *server) RepositoryExists(ctx context.Context, in *pb.RepositoryExistsRequest) (*pb.RepositoryExistsResponse, error) { diff --git a/internal/service/repository/repository_test.go b/internal/service/repository/repository_test.go index 983914d82..72fb1ad8b 100644 --- a/internal/service/repository/repository_test.go +++ b/internal/service/repository/repository_test.go @@ -108,7 +108,7 @@ func TestRepositoryExists(t *testing.T) { t.Run(tc.desc, func(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() - response, err := client.Exists(ctx, tc.request) + response, err := client.RepositoryExists(ctx, tc.request) require.Equal(t, tc.errorCode, grpc.Code(err)) |