diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-02-06 09:51:56 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-02-08 10:27:47 +0300 |
| commit | f6b0539953a2f68288cc2d4f807a0ea24bbdb9f8 (patch) | |
| tree | e5941191277bbbdab56b194d894857ef29822dfc | |
| parent | b0919f19443fbc6a155caf6d029fbe1cdd19a4c0 (diff) | |
datastore: Increase timeout for storage cleanup test
We've recently seen one of our tests for storage cleanup flake because
it hit the timeout of two seconds. This isn't all that surprising on
machines that are as slow as our CI runners.
Bump the timeout to a full minute. While it would be very much
preferable to refactor the code so that it doesn't need any timeouts in
the first place it doesn't feel worth it to refactor the code now.
| -rw-r--r-- | internal/praefect/datastore/storage_cleanup_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/praefect/datastore/storage_cleanup_test.go b/internal/praefect/datastore/storage_cleanup_test.go index 568116727..2a9f3eeb1 100644 --- a/internal/praefect/datastore/storage_cleanup_test.go +++ b/internal/praefect/datastore/storage_cleanup_test.go @@ -163,7 +163,7 @@ func TestStorageCleanup_AcquireNextStorage(t *testing.T) { require.Len(t, check2, 1) require.True(t, check2[0].TriggeredAt.Valid) return check2[0].TriggeredAt.Time.After(check1[0].TriggeredAt.Time) - }, 2*time.Second, 200*time.Millisecond, "goroutine failed to update triggered_at column") + }, time.Minute, 200*time.Millisecond, "goroutine failed to update triggered_at column") require.NoError(t, release()) |