diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2020-12-15 12:56:18 +0300 |
|---|---|---|
| committer | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2020-12-15 12:57:17 +0300 |
| commit | e2d397c3188df55b3e0074ab7173cbc53cec4b8a (patch) | |
| tree | 23d16cdf63d0c68abb32d04477128e735a66fd6a | |
| parent | d52ea41f12a33a5213bf0067f0bc0beabb949556 (diff) | |
Revert "Merge branch 'po-user-update-submodule-ff-default' into 'master'"
This reverts commit 61c631b3e50b2a4db5c6c821d1d22906260f2f28, reversing
changes made to 64d6e3dc24637c9755c5ca5220c1330d260689e5.
Because of the bug noted in my
https://gitlab.com/gitlab-org/gitaly/-/merge_requests/2926 of not
ferrying errors upwards. The feature has been stopped already, my MR
fixes it, but as discussed in Slack we'd like to have master in a
known-good state for an upcoming release.
| -rw-r--r-- | changelogs/unreleased/po-user-update-submodule-ff-default.yml | 5 | ||||
| -rw-r--r-- | internal/metadata/featureflag/feature_flags.go | 2 |
2 files changed, 1 insertions, 6 deletions
diff --git a/changelogs/unreleased/po-user-update-submodule-ff-default.yml b/changelogs/unreleased/po-user-update-submodule-ff-default.yml deleted file mode 100644 index be9c8c9a7..000000000 --- a/changelogs/unreleased/po-user-update-submodule-ff-default.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -title: Enable feature flag gitaly_go_user_update_submodule by default -merge_request: 2917 -author: -type: added diff --git a/internal/metadata/featureflag/feature_flags.go b/internal/metadata/featureflag/feature_flags.go index d67c6d405..d9e2fb9f2 100644 --- a/internal/metadata/featureflag/feature_flags.go +++ b/internal/metadata/featureflag/feature_flags.go @@ -33,7 +33,7 @@ var ( GoResolveConflicts = FeatureFlag{Name: "go_resolve_conflicts", OnByDefault: false} // GoUserUpdateSubmodule enables the Go implementation of // UserUpdateSubmodules - GoUserUpdateSubmodule = FeatureFlag{Name: "go_user_update_submodule", OnByDefault: true} + GoUserUpdateSubmodule = FeatureFlag{Name: "go_user_update_submodule", OnByDefault: false} // GoFetchRemote enables the Go implementation of FetchRemote GoFetchRemote = FeatureFlag{Name: "go_fetch_remote", OnByDefault: true} // GoUserDeleteTag enables the Go implementation of UserDeleteTag |