Praefect: Reconciliation.Validate method

The new 'Validate' method validates values of the
'Reconciliation' type. It will be used in the later changes.

2 files changed, 55 insertions, 0 deletions

diff --git a/internal/praefect/config/config.go b/internal/praefect/config/config.go
index 577ddb0fb..871a3b6b7 100644
--- a/internal/praefect/config/config.go
+++ b/internal/praefect/config/config.go
@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"sort"
 	"time"
 
 	"github.com/hashicorp/yamux"
@@ -151,6 +152,20 @@ type Reconciliation struct {
 	HistogramBuckets []float64 `toml:"histogram_buckets,omitempty"`
 }
 
+// Validate runs validation on all fields and compose all found errors.
+func (r Reconciliation) Validate() error {
+	errs := cfgerror.New().
+		Append(cfgerror.IsPositive(r.SchedulingInterval.Duration()), "scheduling_interval")
+
+	if r.SchedulingInterval != 0 {
+		if !sort.Float64sAreSorted(r.HistogramBuckets) {
+			errs = errs.Append(cfgerror.ErrBadOrder, "histogram_buckets")
+		}
+	}
+
+	return errs.AsError()
+}
+
 // DefaultReconciliationConfig returns the default values for reconciliation configuration.
 func DefaultReconciliationConfig() Reconciliation {
 	return Reconciliation{
diff --git a/internal/praefect/config/config_test.go b/internal/praefect/config/config_test.go
index 66f359e4c..7b6fa91b7 100644
--- a/internal/praefect/config/config_test.go
+++ b/internal/praefect/config/config_test.go
@@ -683,3 +683,43 @@ func TestBackgroundVerification_Validate(t *testing.T) {
 		})
 	}
 }
+
+func TestReconciliation_Validate(t *testing.T) {
+	t.Parallel()
+	for _, tc := range []struct {
+		name           string
+		reconciliation Reconciliation
+		expectedErr    error
+	}{
+		{
+			name:           "empty is valid",
+			reconciliation: Reconciliation{},
+		},
+		{
+			name: "valid",
+			reconciliation: Reconciliation{
+				SchedulingInterval: duration.Duration(1),
+				HistogramBuckets:   []float64{-1, 0, 1},
+			},
+		},
+		{
+			name: "invalid",
+			reconciliation: Reconciliation{
+				SchedulingInterval: duration.Duration(-1),
+				HistogramBuckets:   []float64{-1, 1, 0},
+			},
+			expectedErr: cfgerror.ValidationErrors{{
+				Key:   []string{"scheduling_interval"},
+				Cause: fmt.Errorf("%w: -1ns", cfgerror.ErrIsNegative),
+			}, {
+				Key:   []string{"histogram_buckets"},
+				Cause: cfgerror.ErrBadOrder,
+			}},
+		},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			err := tc.reconciliation.Validate()
+			require.Equal(t, tc.expectedErr, err)
+		})
+	}
+}