diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-05-02 12:42:47 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-05-09 13:20:19 +0300 |
commit | 58aa3bc8b0f8a1dd7fd9ec006ff870d59d8c01be (patch) | |
tree | 3c59ff4f3ae97dc286791f5c40457d30a110be27 | |
parent | 17dfa058c4310339eb8fcdb871ed46d97ad1d65e (diff) |
proto: Enforce comment-linting for enum fields
Enforce that enum fields must have a comment and add a placeholder for
all instances where such a comment is missing.
-rw-r--r-- | proto/.protolint.yaml | 1 | ||||
-rw-r--r-- | proto/commit.proto | 15 | ||||
-rw-r--r-- | proto/diff.proto | 5 | ||||
-rw-r--r-- | proto/go/gitalypb/commit.pb.go | 26 | ||||
-rw-r--r-- | proto/go/gitalypb/diff.pb.go | 13 | ||||
-rw-r--r-- | proto/go/gitalypb/hook.pb.go | 7 | ||||
-rw-r--r-- | proto/go/gitalypb/lint.pb.go | 14 | ||||
-rw-r--r-- | proto/go/gitalypb/ref.pb.go | 31 | ||||
-rw-r--r-- | proto/go/gitalypb/repository.pb.go | 29 | ||||
-rw-r--r-- | proto/go/gitalypb/shared.pb.go | 21 | ||||
-rw-r--r-- | proto/go/gitalypb/transaction.pb.go | 7 | ||||
-rw-r--r-- | proto/go/gitalypb/wiki.pb.go | 8 | ||||
-rw-r--r-- | proto/hook.proto | 3 | ||||
-rw-r--r-- | proto/lint.proto | 6 | ||||
-rw-r--r-- | proto/ref.proto | 13 | ||||
-rw-r--r-- | proto/repository.proto | 11 | ||||
-rw-r--r-- | proto/shared.proto | 9 | ||||
-rw-r--r-- | proto/transaction.proto | 3 | ||||
-rw-r--r-- | proto/wiki.proto | 4 |
19 files changed, 181 insertions, 45 deletions
diff --git a/proto/.protolint.yaml b/proto/.protolint.yaml index 9d29ed88f..6105a0094 100644 --- a/proto/.protolint.yaml +++ b/proto/.protolint.yaml @@ -15,7 +15,6 @@ lint: # get protolint included in our workflow with minimal required changes. - FILE_HAS_COMMENT - FIELDS_HAVE_COMMENT - - ENUM_FIELDS_HAVE_COMMENT # Many of our fields and messages have prepositions in them, and # furthermore this rule doesn't feel all that sensible after all. We thus # disable it. diff --git a/proto/commit.proto b/proto/commit.proto index 5462fc5d7..e70bd0bdb 100644 --- a/proto/commit.proto +++ b/proto/commit.proto @@ -311,9 +311,13 @@ message TreeEntryRequest { message TreeEntryResponse { // TODO: Replace this enum with ObjectType in shared.proto enum ObjectType { + // This comment is left unintentionally blank. COMMIT = 0; + // This comment is left unintentionally blank. BLOB = 1; + // This comment is left unintentionally blank. TREE = 2; + // This comment is left unintentionally blank. TAG = 3; } ObjectType type = 1; @@ -366,10 +370,14 @@ message CountDivergingCommitsResponse { message TreeEntry { // TODO: Replace this enum with ObjectType in shared.proto enum EntryType { + // This comment is left unintentionally blank. BLOB = 0; + // This comment is left unintentionally blank. TREE = 1; + // This comment is left unintentionally blank. COMMIT = 3; } + // OID of the object this tree entry points to string oid = 1; // OID of the tree attached to commit_oid @@ -389,7 +397,9 @@ message TreeEntry { message GetTreeEntriesRequest { // This comment is left unintentionally blank. enum SortBy { + // This comment is left unintentionally blank. DEFAULT = 0; // Preserve order of git ls-tree + // This comment is left unintentionally blank. TREES_FIRST = 1; // trees, blobs, submodules } @@ -469,8 +479,11 @@ message ListCommitsByRefNameResponse { message FindAllCommitsRequest { // This comment is left unintentionally blank. enum Order { + // This comment is left unintentionally blank. NONE = 0; + // This comment is left unintentionally blank. TOPO = 1; + // This comment is left unintentionally blank. DATE = 2; } @@ -491,7 +504,9 @@ message FindAllCommitsResponse { message FindCommitsRequest { // This comment is left unintentionally blank. enum Order { + // This comment is left unintentionally blank. NONE = 0; + // This comment is left unintentionally blank. TOPO = 1; } diff --git a/proto/diff.proto b/proto/diff.proto index 9ca0d7c13..169127d51 100644 --- a/proto/diff.proto +++ b/proto/diff.proto @@ -201,10 +201,15 @@ message FindChangedPathsResponse { message ChangedPaths { // This comment is left unintentionally blank. enum Status { + // This comment is left unintentionally blank. ADDED = 0; + // This comment is left unintentionally blank. MODIFIED = 1; + // This comment is left unintentionally blank. DELETED = 2; + // This comment is left unintentionally blank. TYPE_CHANGE = 3; + // This comment is left unintentionally blank. COPIED = 4; } diff --git a/proto/go/gitalypb/commit.pb.go b/proto/go/gitalypb/commit.pb.go index 9cb3edc7c..18ad1c589 100644 --- a/proto/go/gitalypb/commit.pb.go +++ b/proto/go/gitalypb/commit.pb.go @@ -82,10 +82,14 @@ func (ListCommitsRequest_Order) EnumDescriptor() ([]byte, []int) { type TreeEntryResponse_ObjectType int32 const ( + // This comment is left unintentionally blank. TreeEntryResponse_COMMIT TreeEntryResponse_ObjectType = 0 - TreeEntryResponse_BLOB TreeEntryResponse_ObjectType = 1 - TreeEntryResponse_TREE TreeEntryResponse_ObjectType = 2 - TreeEntryResponse_TAG TreeEntryResponse_ObjectType = 3 + // This comment is left unintentionally blank. + TreeEntryResponse_BLOB TreeEntryResponse_ObjectType = 1 + // This comment is left unintentionally blank. + TreeEntryResponse_TREE TreeEntryResponse_ObjectType = 2 + // This comment is left unintentionally blank. + TreeEntryResponse_TAG TreeEntryResponse_ObjectType = 3 ) // Enum value maps for TreeEntryResponse_ObjectType. @@ -135,8 +139,11 @@ func (TreeEntryResponse_ObjectType) EnumDescriptor() ([]byte, []int) { type TreeEntry_EntryType int32 const ( - TreeEntry_BLOB TreeEntry_EntryType = 0 - TreeEntry_TREE TreeEntry_EntryType = 1 + // This comment is left unintentionally blank. + TreeEntry_BLOB TreeEntry_EntryType = 0 + // This comment is left unintentionally blank. + TreeEntry_TREE TreeEntry_EntryType = 1 + // This comment is left unintentionally blank. TreeEntry_COMMIT TreeEntry_EntryType = 3 ) @@ -185,7 +192,9 @@ func (TreeEntry_EntryType) EnumDescriptor() ([]byte, []int) { type GetTreeEntriesRequest_SortBy int32 const ( - GetTreeEntriesRequest_DEFAULT GetTreeEntriesRequest_SortBy = 0 // Preserve order of git ls-tree + // This comment is left unintentionally blank. + GetTreeEntriesRequest_DEFAULT GetTreeEntriesRequest_SortBy = 0 // Preserve order of git ls-tree + // This comment is left unintentionally blank. GetTreeEntriesRequest_TREES_FIRST GetTreeEntriesRequest_SortBy = 1 // trees, blobs, submodules ) @@ -232,8 +241,11 @@ func (GetTreeEntriesRequest_SortBy) EnumDescriptor() ([]byte, []int) { type FindAllCommitsRequest_Order int32 const ( + // This comment is left unintentionally blank. FindAllCommitsRequest_NONE FindAllCommitsRequest_Order = 0 + // This comment is left unintentionally blank. FindAllCommitsRequest_TOPO FindAllCommitsRequest_Order = 1 + // This comment is left unintentionally blank. FindAllCommitsRequest_DATE FindAllCommitsRequest_Order = 2 ) @@ -282,7 +294,9 @@ func (FindAllCommitsRequest_Order) EnumDescriptor() ([]byte, []int) { type FindCommitsRequest_Order int32 const ( + // This comment is left unintentionally blank. FindCommitsRequest_NONE FindCommitsRequest_Order = 0 + // This comment is left unintentionally blank. FindCommitsRequest_TOPO FindCommitsRequest_Order = 1 ) diff --git a/proto/go/gitalypb/diff.pb.go b/proto/go/gitalypb/diff.pb.go index 8cc86c4d3..a9db0b2d2 100644 --- a/proto/go/gitalypb/diff.pb.go +++ b/proto/go/gitalypb/diff.pb.go @@ -73,11 +73,16 @@ func (CommitDiffRequest_DiffMode) EnumDescriptor() ([]byte, []int) { type ChangedPaths_Status int32 const ( - ChangedPaths_ADDED ChangedPaths_Status = 0 - ChangedPaths_MODIFIED ChangedPaths_Status = 1 - ChangedPaths_DELETED ChangedPaths_Status = 2 + // This comment is left unintentionally blank. + ChangedPaths_ADDED ChangedPaths_Status = 0 + // This comment is left unintentionally blank. + ChangedPaths_MODIFIED ChangedPaths_Status = 1 + // This comment is left unintentionally blank. + ChangedPaths_DELETED ChangedPaths_Status = 2 + // This comment is left unintentionally blank. ChangedPaths_TYPE_CHANGE ChangedPaths_Status = 3 - ChangedPaths_COPIED ChangedPaths_Status = 4 + // This comment is left unintentionally blank. + ChangedPaths_COPIED ChangedPaths_Status = 4 ) // Enum value maps for ChangedPaths_Status. diff --git a/proto/go/gitalypb/hook.pb.go b/proto/go/gitalypb/hook.pb.go index 2c274a694..64fbdb427 100644 --- a/proto/go/gitalypb/hook.pb.go +++ b/proto/go/gitalypb/hook.pb.go @@ -24,9 +24,12 @@ const ( type ReferenceTransactionHookRequest_State int32 const ( - ReferenceTransactionHookRequest_PREPARED ReferenceTransactionHookRequest_State = 0 + // This comment is left unintentionally blank. + ReferenceTransactionHookRequest_PREPARED ReferenceTransactionHookRequest_State = 0 + // This comment is left unintentionally blank. ReferenceTransactionHookRequest_COMMITTED ReferenceTransactionHookRequest_State = 1 - ReferenceTransactionHookRequest_ABORTED ReferenceTransactionHookRequest_State = 2 + // This comment is left unintentionally blank. + ReferenceTransactionHookRequest_ABORTED ReferenceTransactionHookRequest_State = 2 ) // Enum value maps for ReferenceTransactionHookRequest_State. diff --git a/proto/go/gitalypb/lint.pb.go b/proto/go/gitalypb/lint.pb.go index 5d462c426..10ccf4a77 100644 --- a/proto/go/gitalypb/lint.pb.go +++ b/proto/go/gitalypb/lint.pb.go @@ -25,9 +25,13 @@ const ( type OperationMsg_Operation int32 const ( - OperationMsg_UNKNOWN OperationMsg_Operation = 0 - OperationMsg_MUTATOR OperationMsg_Operation = 1 - OperationMsg_ACCESSOR OperationMsg_Operation = 2 + // This comment is left unintentionally blank. + OperationMsg_UNKNOWN OperationMsg_Operation = 0 + // This comment is left unintentionally blank. + OperationMsg_MUTATOR OperationMsg_Operation = 1 + // This comment is left unintentionally blank. + OperationMsg_ACCESSOR OperationMsg_Operation = 2 + // This comment is left unintentionally blank. OperationMsg_MAINTENANCE OperationMsg_Operation = 3 ) @@ -78,8 +82,10 @@ func (OperationMsg_Operation) EnumDescriptor() ([]byte, []int) { type OperationMsg_Scope int32 const ( + // This comment is left unintentionally blank. OperationMsg_REPOSITORY OperationMsg_Scope = 0 - OperationMsg_STORAGE OperationMsg_Scope = 2 + // This comment is left unintentionally blank. + OperationMsg_STORAGE OperationMsg_Scope = 2 ) // Enum value maps for OperationMsg_Scope. diff --git a/proto/go/gitalypb/ref.pb.go b/proto/go/gitalypb/ref.pb.go index 67cb0cc94..1c74b5031 100644 --- a/proto/go/gitalypb/ref.pb.go +++ b/proto/go/gitalypb/ref.pb.go @@ -25,8 +25,11 @@ const ( type FindLocalBranchesRequest_SortBy int32 const ( - FindLocalBranchesRequest_NAME FindLocalBranchesRequest_SortBy = 0 - FindLocalBranchesRequest_UPDATED_ASC FindLocalBranchesRequest_SortBy = 1 + // This comment is left unintentionally blank. + FindLocalBranchesRequest_NAME FindLocalBranchesRequest_SortBy = 0 + // This comment is left unintentionally blank. + FindLocalBranchesRequest_UPDATED_ASC FindLocalBranchesRequest_SortBy = 1 + // This comment is left unintentionally blank. FindLocalBranchesRequest_UPDATED_DESC FindLocalBranchesRequest_SortBy = 2 ) @@ -75,7 +78,9 @@ func (FindLocalBranchesRequest_SortBy) EnumDescriptor() ([]byte, []int) { type FindAllTagsRequest_SortBy_Key int32 const ( - FindAllTagsRequest_SortBy_REFNAME FindAllTagsRequest_SortBy_Key = 0 + // This comment is left unintentionally blank. + FindAllTagsRequest_SortBy_REFNAME FindAllTagsRequest_SortBy_Key = 0 + // This comment is left unintentionally blank. FindAllTagsRequest_SortBy_CREATORDATE FindAllTagsRequest_SortBy_Key = 1 ) @@ -122,9 +127,13 @@ func (FindAllTagsRequest_SortBy_Key) EnumDescriptor() ([]byte, []int) { type CreateBranchResponse_Status int32 const ( - CreateBranchResponse_OK CreateBranchResponse_Status = 0 - CreateBranchResponse_ERR_EXISTS CreateBranchResponse_Status = 1 - CreateBranchResponse_ERR_INVALID CreateBranchResponse_Status = 2 + // This comment is left unintentionally blank. + CreateBranchResponse_OK CreateBranchResponse_Status = 0 + // This comment is left unintentionally blank. + CreateBranchResponse_ERR_EXISTS CreateBranchResponse_Status = 1 + // This comment is left unintentionally blank. + CreateBranchResponse_ERR_INVALID CreateBranchResponse_Status = 2 + // This comment is left unintentionally blank. CreateBranchResponse_ERR_INVALID_START_POINT CreateBranchResponse_Status = 3 ) @@ -175,9 +184,13 @@ func (CreateBranchResponse_Status) EnumDescriptor() ([]byte, []int) { type ListRefsRequest_SortBy_Key int32 const ( - ListRefsRequest_SortBy_REFNAME ListRefsRequest_SortBy_Key = 0 - ListRefsRequest_SortBy_CREATORDATE ListRefsRequest_SortBy_Key = 1 - ListRefsRequest_SortBy_AUTHORDATE ListRefsRequest_SortBy_Key = 2 + // This comment is left unintentionally blank. + ListRefsRequest_SortBy_REFNAME ListRefsRequest_SortBy_Key = 0 + // This comment is left unintentionally blank. + ListRefsRequest_SortBy_CREATORDATE ListRefsRequest_SortBy_Key = 1 + // This comment is left unintentionally blank. + ListRefsRequest_SortBy_AUTHORDATE ListRefsRequest_SortBy_Key = 2 + // This comment is left unintentionally blank. ListRefsRequest_SortBy_COMMITTERDATE ListRefsRequest_SortBy_Key = 3 ) diff --git a/proto/go/gitalypb/repository.pb.go b/proto/go/gitalypb/repository.pb.go index 18a315209..7f03c9ab9 100644 --- a/proto/go/gitalypb/repository.pb.go +++ b/proto/go/gitalypb/repository.pb.go @@ -71,9 +71,13 @@ func (WriteCommitGraphRequest_SplitStrategy) EnumDescriptor() ([]byte, []int) { type GetArchiveRequest_Format int32 const ( - GetArchiveRequest_ZIP GetArchiveRequest_Format = 0 - GetArchiveRequest_TAR GetArchiveRequest_Format = 1 - GetArchiveRequest_TAR_GZ GetArchiveRequest_Format = 2 + // This comment is left unintentionally blank. + GetArchiveRequest_ZIP GetArchiveRequest_Format = 0 + // This comment is left unintentionally blank. + GetArchiveRequest_TAR GetArchiveRequest_Format = 1 + // This comment is left unintentionally blank. + GetArchiveRequest_TAR_GZ GetArchiveRequest_Format = 2 + // This comment is left unintentionally blank. GetArchiveRequest_TAR_BZ2 GetArchiveRequest_Format = 3 ) @@ -124,12 +128,19 @@ func (GetArchiveRequest_Format) EnumDescriptor() ([]byte, []int) { type GetRawChangesResponse_RawChange_Operation int32 const ( - GetRawChangesResponse_RawChange_UNKNOWN GetRawChangesResponse_RawChange_Operation = 0 - GetRawChangesResponse_RawChange_ADDED GetRawChangesResponse_RawChange_Operation = 1 - GetRawChangesResponse_RawChange_COPIED GetRawChangesResponse_RawChange_Operation = 2 - GetRawChangesResponse_RawChange_DELETED GetRawChangesResponse_RawChange_Operation = 3 - GetRawChangesResponse_RawChange_MODIFIED GetRawChangesResponse_RawChange_Operation = 4 - GetRawChangesResponse_RawChange_RENAMED GetRawChangesResponse_RawChange_Operation = 5 + // This comment is left unintentionally blank. + GetRawChangesResponse_RawChange_UNKNOWN GetRawChangesResponse_RawChange_Operation = 0 + // This comment is left unintentionally blank. + GetRawChangesResponse_RawChange_ADDED GetRawChangesResponse_RawChange_Operation = 1 + // This comment is left unintentionally blank. + GetRawChangesResponse_RawChange_COPIED GetRawChangesResponse_RawChange_Operation = 2 + // This comment is left unintentionally blank. + GetRawChangesResponse_RawChange_DELETED GetRawChangesResponse_RawChange_Operation = 3 + // This comment is left unintentionally blank. + GetRawChangesResponse_RawChange_MODIFIED GetRawChangesResponse_RawChange_Operation = 4 + // This comment is left unintentionally blank. + GetRawChangesResponse_RawChange_RENAMED GetRawChangesResponse_RawChange_Operation = 5 + // This comment is left unintentionally blank. GetRawChangesResponse_RawChange_TYPE_CHANGED GetRawChangesResponse_RawChange_Operation = 6 ) diff --git a/proto/go/gitalypb/shared.pb.go b/proto/go/gitalypb/shared.pb.go index 3976c354c..d76fa1963 100644 --- a/proto/go/gitalypb/shared.pb.go +++ b/proto/go/gitalypb/shared.pb.go @@ -25,11 +25,16 @@ const ( type ObjectType int32 const ( + // This comment is left unintentionally blank. ObjectType_UNKNOWN ObjectType = 0 - ObjectType_COMMIT ObjectType = 1 - ObjectType_BLOB ObjectType = 2 - ObjectType_TREE ObjectType = 3 - ObjectType_TAG ObjectType = 4 + // This comment is left unintentionally blank. + ObjectType_COMMIT ObjectType = 1 + // This comment is left unintentionally blank. + ObjectType_BLOB ObjectType = 2 + // This comment is left unintentionally blank. + ObjectType_TREE ObjectType = 3 + // This comment is left unintentionally blank. + ObjectType_TAG ObjectType = 4 ) // Enum value maps for ObjectType. @@ -81,10 +86,14 @@ func (ObjectType) EnumDescriptor() ([]byte, []int) { type SignatureType int32 const ( + // This comment is left unintentionally blank. SignatureType_NONE SignatureType = 0 - SignatureType_PGP SignatureType = 1 + // This comment is left unintentionally blank. + SignatureType_PGP SignatureType = 1 + // This comment is left unintentionally blank. SignatureType_X509 SignatureType = 2 - SignatureType_SSH SignatureType = 3 // maybe add X509+TSA or other combinations at a later step + // This comment is left unintentionally blank. + SignatureType_SSH SignatureType = 3 // maybe add X509+TSA or other combinations at a later step ) // Enum value maps for SignatureType. diff --git a/proto/go/gitalypb/transaction.pb.go b/proto/go/gitalypb/transaction.pb.go index 0b358fd5f..fb4977253 100644 --- a/proto/go/gitalypb/transaction.pb.go +++ b/proto/go/gitalypb/transaction.pb.go @@ -83,9 +83,12 @@ func (VoteTransactionRequest_Phase) EnumDescriptor() ([]byte, []int) { type VoteTransactionResponse_TransactionState int32 const ( + // This comment is left unintentionally blank. VoteTransactionResponse_COMMIT VoteTransactionResponse_TransactionState = 0 - VoteTransactionResponse_ABORT VoteTransactionResponse_TransactionState = 1 - VoteTransactionResponse_STOP VoteTransactionResponse_TransactionState = 2 + // This comment is left unintentionally blank. + VoteTransactionResponse_ABORT VoteTransactionResponse_TransactionState = 1 + // This comment is left unintentionally blank. + VoteTransactionResponse_STOP VoteTransactionResponse_TransactionState = 2 ) // Enum value maps for VoteTransactionResponse_TransactionState. diff --git a/proto/go/gitalypb/wiki.pb.go b/proto/go/gitalypb/wiki.pb.go index b4255679b..199f5a912 100644 --- a/proto/go/gitalypb/wiki.pb.go +++ b/proto/go/gitalypb/wiki.pb.go @@ -24,7 +24,9 @@ const ( type WikiGetAllPagesRequest_SortBy int32 const ( - WikiGetAllPagesRequest_TITLE WikiGetAllPagesRequest_SortBy = 0 + // This comment is left unintentionally blank. + WikiGetAllPagesRequest_TITLE WikiGetAllPagesRequest_SortBy = 0 + // This comment is left unintentionally blank. WikiGetAllPagesRequest_CREATED_AT WikiGetAllPagesRequest_SortBy = 1 ) @@ -71,7 +73,9 @@ func (WikiGetAllPagesRequest_SortBy) EnumDescriptor() ([]byte, []int) { type WikiListPagesRequest_SortBy int32 const ( - WikiListPagesRequest_TITLE WikiListPagesRequest_SortBy = 0 + // This comment is left unintentionally blank. + WikiListPagesRequest_TITLE WikiListPagesRequest_SortBy = 0 + // This comment is left unintentionally blank. WikiListPagesRequest_CREATED_AT WikiListPagesRequest_SortBy = 1 ) diff --git a/proto/hook.proto b/proto/hook.proto index 84ed1caac..a14278592 100644 --- a/proto/hook.proto +++ b/proto/hook.proto @@ -100,8 +100,11 @@ message UpdateHookResponse{ message ReferenceTransactionHookRequest { // This comment is left unintentionally blank. enum State { + // This comment is left unintentionally blank. PREPARED = 0; + // This comment is left unintentionally blank. COMMITTED = 1; + // This comment is left unintentionally blank. ABORTED = 2; } diff --git a/proto/lint.proto b/proto/lint.proto index cec0141b4..74f293856 100644 --- a/proto/lint.proto +++ b/proto/lint.proto @@ -10,15 +10,21 @@ option go_package = "gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"; message OperationMsg { // This comment is left unintentionally blank. enum Operation { + // This comment is left unintentionally blank. UNKNOWN = 0; + // This comment is left unintentionally blank. MUTATOR = 1; + // This comment is left unintentionally blank. ACCESSOR = 2; + // This comment is left unintentionally blank. MAINTENANCE = 3; } // This comment is left unintentionally blank. enum Scope { + // This comment is left unintentionally blank. REPOSITORY = 0; + // This comment is left unintentionally blank. STORAGE = 2; reserved 1; diff --git a/proto/ref.proto b/proto/ref.proto index 6c4417366..85d2252f3 100644 --- a/proto/ref.proto +++ b/proto/ref.proto @@ -183,8 +183,11 @@ message FindAllTagNamesResponse { message FindLocalBranchesRequest { // This comment is left unintentionally blank. enum SortBy { + // This comment is left unintentionally blank. NAME = 0; + // This comment is left unintentionally blank. UPDATED_ASC = 1; + // This comment is left unintentionally blank. UPDATED_DESC = 2; } @@ -258,7 +261,9 @@ message FindAllTagsRequest { message SortBy { // Key is a key used for sorting. enum Key { + // This comment is left unintentionally blank. REFNAME = 0; + // This comment is left unintentionally blank. CREATORDATE = 1; } @@ -303,9 +308,13 @@ message CreateBranchRequest { message CreateBranchResponse { // This comment is left unintentionally blank. enum Status { + // This comment is left unintentionally blank. OK = 0; + // This comment is left unintentionally blank. ERR_EXISTS = 1; + // This comment is left unintentionally blank. ERR_INVALID = 2; + // This comment is left unintentionally blank. ERR_INVALID_START_POINT = 3; } @@ -472,9 +481,13 @@ message ListRefsRequest { message SortBy { // This comment is left unintentionally blank. enum Key { + // This comment is left unintentionally blank. REFNAME = 0; + // This comment is left unintentionally blank. CREATORDATE = 1; + // This comment is left unintentionally blank. AUTHORDATE = 2; + // This comment is left unintentionally blank. COMMITTERDATE = 3; } diff --git a/proto/repository.proto b/proto/repository.proto index 31fb59e83..a2fc00238 100644 --- a/proto/repository.proto +++ b/proto/repository.proto @@ -502,9 +502,13 @@ message CreateRepositoryResponse { message GetArchiveRequest { // This comment is left unintentionally blank. enum Format { + // This comment is left unintentionally blank. ZIP = 0; + // This comment is left unintentionally blank. TAR = 1; + // This comment is left unintentionally blank. TAR_GZ = 2; + // This comment is left unintentionally blank. TAR_BZ2 = 3; } @@ -775,12 +779,19 @@ message GetRawChangesResponse { message RawChange { // This comment is left unintentionally blank. enum Operation { + // This comment is left unintentionally blank. UNKNOWN = 0; + // This comment is left unintentionally blank. ADDED = 1; + // This comment is left unintentionally blank. COPIED = 2; + // This comment is left unintentionally blank. DELETED = 3; + // This comment is left unintentionally blank. MODIFIED = 4; + // This comment is left unintentionally blank. RENAMED = 5; + // This comment is left unintentionally blank. TYPE_CHANGED = 6; } diff --git a/proto/shared.proto b/proto/shared.proto index 8a23b063e..0a8d801b4 100644 --- a/proto/shared.proto +++ b/proto/shared.proto @@ -9,18 +9,27 @@ option go_package = "gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"; // This comment is left unintentionally blank. enum ObjectType { + // This comment is left unintentionally blank. UNKNOWN = 0; + // This comment is left unintentionally blank. COMMIT = 1; + // This comment is left unintentionally blank. BLOB = 2; + // This comment is left unintentionally blank. TREE = 3; + // This comment is left unintentionally blank. TAG = 4; } // This comment is left unintentionally blank. enum SignatureType { + // This comment is left unintentionally blank. NONE = 0; + // This comment is left unintentionally blank. PGP = 1; + // This comment is left unintentionally blank. X509 = 2; + // This comment is left unintentionally blank. SSH = 3; // maybe add X509+TSA or other combinations at a later step } diff --git a/proto/transaction.proto b/proto/transaction.proto index 4e8864c81..992178165 100644 --- a/proto/transaction.proto +++ b/proto/transaction.proto @@ -75,8 +75,11 @@ message VoteTransactionResponse { // The outcome of the given transaction telling the client whether the // transaction should be committed or rolled back. enum TransactionState { + // This comment is left unintentionally blank. COMMIT = 0; + // This comment is left unintentionally blank. ABORT = 1; + // This comment is left unintentionally blank. STOP = 2; } diff --git a/proto/wiki.proto b/proto/wiki.proto index b99181651..8863c5c38 100644 --- a/proto/wiki.proto +++ b/proto/wiki.proto @@ -133,7 +133,9 @@ message WikiFindPageResponse { message WikiGetAllPagesRequest { // This comment is left unintentionally blank. enum SortBy { + // This comment is left unintentionally blank. TITLE = 0; + // This comment is left unintentionally blank. CREATED_AT = 1; } @@ -155,7 +157,9 @@ message WikiGetAllPagesResponse { message WikiListPagesRequest { // This comment is left unintentionally blank. enum SortBy { + // This comment is left unintentionally blank. TITLE = 0; + // This comment is left unintentionally blank. CREATED_AT = 1; } |