diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-28 13:52:24 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-28 14:01:36 +0300 |
| commit | 5bf73d7a012b74fb3df5d18a81c57468bf322848 (patch) | |
| tree | ffd0bf988a7a482225ce11daf7aca42e163a0847 | |
| parent | fde8ce021e2b80994784ec1c6268db45938e7448 (diff) | |
Makefile: Drop assembly targets
Historically, the GDK used Gitaly's "assemble" target to install all
runtime dependencies into a single directory. This usage has long been
replaced by a simple `make -C /path/to/gitaly` invocation in a6e99ef7
(Move gitaly to top level, 2019-12-03). This implicitly executes the
"install" target with the install directory set to Gitaly's top-level
directory, so none of the assembly targets are involved.
Scanning through downstream distributions and documentation in
gitlab-org/gitlab didn't surface any other users of these targets, so we
may assume that they are not used anymore, making them safe for removal.
| -rw-r--r-- | Makefile | 35 |
1 files changed, 1 insertions, 34 deletions
@@ -31,7 +31,6 @@ prefix ?= ${PREFIX} exec_prefix ?= ${prefix} bindir ?= ${exec_prefix}/bin INSTALL_DEST_DIR := ${DESTDIR}${bindir} -ASSEMBLY_ROOT ?= ${BUILD_DIR}/assembly GIT_PREFIX ?= ${GIT_INSTALL_DIR} # Tools @@ -205,38 +204,6 @@ install: build ${Q}mkdir -p ${INSTALL_DEST_DIR} install $(call find_command_binaries) ${INSTALL_DEST_DIR} -.PHONY: force-ruby-bundle -force-ruby-bundle: - ${Q}rm -f ${SOURCE_DIR}/.ruby-bundle - -# Assembles all runtime components into a directory -# Used by the GDK: run 'make assemble ASSEMBLY_ROOT=.../gitaly' -.PHONY: assemble -assemble: force-ruby-bundle assemble-internal - -# assemble-internal does not force 'bundle install' to run again -.PHONY: assemble-internal -assemble-internal: assemble-ruby assemble-go - -.PHONY: assemble-go -assemble-go: build - ${Q}rm -rf ${ASSEMBLY_ROOT}/bin - ${Q}mkdir -p ${ASSEMBLY_ROOT}/bin - install $(call find_command_binaries) ${ASSEMBLY_ROOT}/bin - -.PHONY: assemble-ruby -assemble-ruby: - ${Q}mkdir -p ${ASSEMBLY_ROOT} - ${Q}rm -rf ${GITALY_RUBY_DIR}/tmp - ${Q}mkdir -p ${ASSEMBLY_ROOT}/ruby/ - rsync -a --delete ${GITALY_RUBY_DIR}/ ${ASSEMBLY_ROOT}/ruby/ - ${Q}rm -rf ${ASSEMBLY_ROOT}/ruby/spec - -.PHONY: binaries -binaries: assemble - ${Q}if [ ${ARCH} != 'x86_64' ]; then echo Incorrect architecture for build: ${ARCH}; exit 1; fi - ${Q}cd ${ASSEMBLY_ROOT} && sha256sum bin/* | tee checksums.sha256.txt - .PHONY: prepare-tests prepare-tests: git libgit2 prepare-test-repos ${SOURCE_DIR}/.ruby-bundle @@ -279,7 +246,7 @@ race-go: TEST_OPTIONS := ${TEST_OPTIONS} -race race-go: test-go .PHONY: rspec -rspec: assemble-go prepare-tests +rspec: build prepare-tests ${Q}cd ${GITALY_RUBY_DIR} && PATH='${SOURCE_DIR}/internal/testhelper/testdata/home/bin:${PATH}' bundle exec rspec .PHONY: verify |