diff options
| author | Zeger-Jan van de Weg <zegerjan@gitlab.com> | 2018-10-05 14:43:37 +0300 |
|---|---|---|
| committer | Zeger-Jan van de Weg <zegerjan@gitlab.com> | 2018-10-05 14:43:37 +0300 |
| commit | df6a8dc7ef30e0a6cc12c6e5d5e26e0458ab8a38 (patch) | |
| tree | 33984cad4a6b712cad498c710061ce4bc3b80258 | |
| parent | f03038d301d4c928c425321bfab9b81f4cea58ad (diff) | |
| parent | df44e03da55a3f9c247903675993a06b4e8724ce (diff) | |
Merge branch 'remove-gogit-feature-flag' into 'master'
Remove test case that exercises gogit feature flag
See merge request gitlab-org/gitaly!899
| -rw-r--r-- | changelogs/unreleased/remove-gogit-feature-flag.yml | 5 | ||||
| -rw-r--r-- | internal/service/commit/find_commit_test.go | 16 |
2 files changed, 5 insertions, 16 deletions
diff --git a/changelogs/unreleased/remove-gogit-feature-flag.yml b/changelogs/unreleased/remove-gogit-feature-flag.yml new file mode 100644 index 000000000..60488fbcf --- /dev/null +++ b/changelogs/unreleased/remove-gogit-feature-flag.yml @@ -0,0 +1,5 @@ +--- +title: Remove test case that exercises gogit feature flag +merge_request: 899 +author: +type: other diff --git a/internal/service/commit/find_commit_test.go b/internal/service/commit/find_commit_test.go index f55ab7ed9..bdf8e35b2 100644 --- a/internal/service/commit/find_commit_test.go +++ b/internal/service/commit/find_commit_test.go @@ -248,22 +248,6 @@ func TestSuccessfulFindCommitRequest(t *testing.T) { }) } require.Equal(t, len(testCases), len(allCommits), "length of allCommits") - - gogitCtx := metadata.NewOutgoingContext( - ctx, - metadata.New(map[string]string{featureflag.HeaderKey("gogit-findcommit"): "true"}), - ) - - for i, testCase := range testCases { - request := &gitalypb.FindCommitRequest{ - Repository: testRepo, - Revision: []byte(testCase.revision), - } - - response, err := client.FindCommit(gogitCtx, request) - require.NoError(t, err, "request with go-git should succeed") - require.Equal(t, allCommits[i], response.Commit, "commit fetched with go-git should match default") - } } func TestFailedFindCommitRequest(t *testing.T) { |