Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSami Hiltunen <shiltunen@gitlab.com>2023-08-21 15:52:03 +0300
committerSami Hiltunen <shiltunen@gitlab.com>2023-08-21 15:52:03 +0300
commit40a25f26f53c96a08b68b4c5d316bb1128444f30 (patch)
tree8e4af4cf2fc28d8f15d147e1a381f98737d25b09
parent3c79c64beacaacc75b55861c4d317732ae367fc1 (diff)
Remove duplicate test
There's a duplicate test in TestStorageCleanup_AcquireNextStorage. Remove it.
-rw-r--r--internal/praefect/datastore/storage_cleanup_test.go18
1 files changed, 0 insertions, 18 deletions
diff --git a/internal/praefect/datastore/storage_cleanup_test.go b/internal/praefect/datastore/storage_cleanup_test.go
index 60e7b16e8..cc70889a6 100644
--- a/internal/praefect/datastore/storage_cleanup_test.go
+++ b/internal/praefect/datastore/storage_cleanup_test.go
@@ -125,24 +125,6 @@ func TestStorageCleanup_AcquireNextStorage(t *testing.T) {
require.NoError(t, release3())
})
- t.Run("already acquired won't be acquired until released", func(t *testing.T) {
- db.TruncateAll(t)
- require.NoError(t, storageCleanup.Populate(ctx, "vs", "g1"))
- _, release1, err := storageCleanup.AcquireNextStorage(ctx, 0, time.Second)
- require.NoError(t, err)
-
- clusterPath, release2, err := storageCleanup.AcquireNextStorage(ctx, 0, time.Second)
- require.NoError(t, err)
- require.Nil(t, clusterPath, clusterPath)
- require.NoError(t, release1())
- require.NoError(t, release2())
-
- clusterPath, release3, err := storageCleanup.AcquireNextStorage(ctx, 0, time.Second)
- require.NoError(t, err)
- require.NotNil(t, clusterPath)
- require.NoError(t, release3())
- })
-
t.Run("acquired for long time triggers update loop", func(t *testing.T) {
db.TruncateAll(t)
require.NoError(t, storageCleanup.Populate(ctx, "vs", "g1"))