diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-08-24 13:28:46 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-08-24 13:46:21 +0300 |
| commit | fb287cf5d90e106a9a7d3eb321510d5cba9233bb (patch) | |
| tree | 5041ac892fb6c5ad93abd9095b4e0f0b6c73d88e | |
| parent | c6f0c6aa481efb561bd79d6880d2b6197bb95185 (diff) | |
testhelper: Remove rule to ignore labkit logger Goroutine leak
We're not really using the labkit logger anymore, whihc makes the rule
that ignores a leakage in that package useless now. Remove it.
| -rw-r--r-- | internal/testhelper/leakage.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/internal/testhelper/leakage.go b/internal/testhelper/leakage.go index d5eca88d2..7a9c4006a 100644 --- a/internal/testhelper/leakage.go +++ b/internal/testhelper/leakage.go @@ -24,9 +24,6 @@ func mustHaveNoGoroutines() { // `init()` function. There is no way to stop this worker, so it will leak // whenever we import the package. goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"), - // labkit's logger spawns a Goroutine which cannot be closed when calling - // `Initialize()`. - goleak.IgnoreTopFunction("gitlab.com/gitlab-org/labkit/log.listenForSignalHangup"), // The backchannel code is somehow stock on closing its connections. I have no clue // why that is, but we should investigate. goleak.IgnoreTopFunction(PkgPath("internal/grpc/backchannel.clientHandshake.serve.func4")), |