Sync repository removals

Repository removals are currently not synced to the disk. This may
lead to the repository appearing back on the disk either in full or
in corrupted state with deletion partially applied. As we are moving
the repository to a temporary directory before deleting it, we need
to just sync the move the removal from the parent directory in order
to avoid the issues.

Changelog: fixed

1 files changed, 4 insertions, 0 deletions

diff --git a/internal/gitaly/repoutil/remove.go b/internal/gitaly/repoutil/remove.go
index 75a2ce998..de3ca7822 100644
--- a/internal/gitaly/repoutil/remove.go
+++ b/internal/gitaly/repoutil/remove.go
@@ -84,6 +84,10 @@ func Remove(
 		return structerr.NewInternal("staging repository for removal: %w", err)
 	}
 
+	if err := safe.NewSyncer().SyncParent(path); err != nil {
+		return fmt.Errorf("sync removal: %w", err)
+	}
+
 	if err := os.RemoveAll(destDir); err != nil {
 		return structerr.NewInternal("removing repository: %w", err)
 	}