diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2024-01-03 17:59:46 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2024-01-03 17:59:46 +0300 |
| commit | 514ff4c96aebf2a0f5a897fe9edfb91d92aff59a (patch) | |
| tree | 4012ddc3cf70a1e3da9f4c6e196bd7700b14ec71 | |
| parent | e9b91447b381c42612796150c7f793fe5a607325 (diff) | |
Defualt enable CLONE_INTO_CGROUP support
CLONE_INTO_CGROUP support is currently default disabled. We can't test
it on production as we're not running cgroup v2. Cgroup v2 is also
broken when used through Omnibus as Gitaly doesn't run in the same
hierarchy as the child cgroups and can't thus move move the processes
it spawns into those cgroups.
To remove the feature flag before we support cgroup v2 ourselves, let's
just enable the flag by default and remove it a couple of releases after
if there are no issues reported. Manual testing has shown it to work.
Default enabling this would only change behavior for setups that manually
configure the cgroups and avoid the issue with moving processes across
hierarchies.
Changelog: fixed
| -rw-r--r-- | internal/featureflag/ff_exec_command_directly_in_cgroup.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/featureflag/ff_exec_command_directly_in_cgroup.go b/internal/featureflag/ff_exec_command_directly_in_cgroup.go index a47b0339f..247837116 100644 --- a/internal/featureflag/ff_exec_command_directly_in_cgroup.go +++ b/internal/featureflag/ff_exec_command_directly_in_cgroup.go @@ -5,5 +5,5 @@ var ExecCommandDirectlyInCgroup = NewFeatureFlag( "exec_command_directly_in_cgroup", "v16.5.0", "https://gitlab.com/gitlab-org/gitaly/-/issues/5639", - false, + true, ) |