diff options
author | Toon Claes <toon@gitlab.com> | 2023-04-07 10:41:25 +0300 |
---|---|---|
committer | Toon Claes <toon@gitlab.com> | 2023-04-14 16:38:04 +0300 |
commit | 2d3047b02ecf0d079e9216ac4c7298e321f4c76c (patch) | |
tree | e4c007c6957a38fb0a8073433efbba0100a3d4fb | |
parent | 683033db2043d8b3ad716115a37d0f2af3c86936 (diff) |
git: Remove comment about rspec tests
We've been mentioning a workaround for rspec tests, but in fact this
workaround is needed for Go tests as well. So change the comment to
reflect that.
-rw-r--r-- | internal/git/execution_environment.go | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/internal/git/execution_environment.go b/internal/git/execution_environment.go index 5a6b092ea..17344ddce 100644 --- a/internal/git/execution_environment.go +++ b/internal/git/execution_environment.go @@ -155,10 +155,11 @@ func (c BundledGitEnvironmentConstructor) Construct(cfg config.Cfg) (_ Execution } if err := os.Symlink(bundledGitBinary, filepath.Join(cfg.BinDir, binary)); err != nil { - // While Gitaly's Go tests use a temporary binary directory, Ruby - // rspecs set up the binary directory to point to our build - // directory. They thus already contain the Git binaries and don't - // need symlinking. + // Multiple Git command factories might be created for the same configuration. + // Each of them will create the execution environment every time, + // therefore these symlinks might already exist. + // It would be nice if we could fix this, but gracefully handling the error is a + // more boring solution. if errors.Is(err, os.ErrExist) { continue } |