diff options
| author | Paul Okstad <pokstad@gitlab.com> | 2020-02-11 07:14:41 +0300 |
|---|---|---|
| committer | Paul Okstad <pokstad@gitlab.com> | 2020-02-11 07:14:41 +0300 |
| commit | 8196d6f066f738707995f42e50e54f50b196be6f (patch) | |
| tree | 465766719168e5324e314ad4c1a3952330df723c | |
| parent | 4c854bf270703de52af43c551d85bc30afeb869e (diff) | |
| parent | d745a8e6ec9c1800487bdf046c501d070d5c3fb3 (diff) | |
Merge branch 'jc-fix-latency-metric' into 'master'
Calculate praefect replication latency using seconds with float64
See merge request gitlab-org/gitaly!1820
| -rw-r--r-- | changelogs/unreleased/jc-fix-latency-metric.yml | 5 | ||||
| -rw-r--r-- | internal/praefect/replicator.go | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/changelogs/unreleased/jc-fix-latency-metric.yml b/changelogs/unreleased/jc-fix-latency-metric.yml new file mode 100644 index 000000000..b4e63927e --- /dev/null +++ b/changelogs/unreleased/jc-fix-latency-metric.yml @@ -0,0 +1,5 @@ +--- +title: Calculate praefect replication latency using seconds with float64 +merge_request: 1820 +author: +type: fixed diff --git a/internal/praefect/replicator.go b/internal/praefect/replicator.go index 3d71e22fa..2f3a48ea3 100644 --- a/internal/praefect/replicator.go +++ b/internal/praefect/replicator.go @@ -330,7 +330,7 @@ func (r ReplMgr) processReplJob(ctx context.Context, job datastore.ReplJob) { } replDuration := time.Since(replStart) - r.replLatencyMetric.Observe(float64(replDuration / time.Millisecond)) + r.replLatencyMetric.Observe(float64(replDuration) / float64(time.Second)) if err := r.datastore.UpdateReplJob(job.ID, datastore.JobStateComplete); err != nil { l.WithError(err).Error("error when updating replication job status to complete") |