Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2020-04-20 18:36:55 +0300
committerJacob Vosmaer <jacob@gitlab.com>2020-04-20 18:36:55 +0300
commit960b5ce6680c722db8360aca51887503921cc778 (patch)
tree14db7fa979cb4e62ec8c89e7168a138b730acb3f
parent44baa4513541671ae64601173466c425ce28e5fb (diff)
`Ref` objects receive the `canonical_name` from Rugged
The `Gitlab::Git::Ref` initializer, which `Branch` inherits, already removes the `refs/heads|tags/` prefix from the provided name via `Gitlab::Git.ref_name`, so there should be no functional difference to providing the "canonical name". In a future commit, we'll store the canonical name in addition to the non-prefixed name.
-rw-r--r--changelogs/unreleased/rs-divergent-refs-response.yml5
-rw-r--r--internal/service/remote/update_remote_mirror_test.go3
-rw-r--r--proto/go/gitalypb/remote.pb.go107
-rw-r--r--proto/remote.proto4
-rw-r--r--ruby/lib/gitaly_server/remote_service.rb7
-rw-r--r--ruby/lib/gitlab/git/ref.rb4
-rw-r--r--ruby/lib/gitlab/git/remote_mirror.rb14
-rw-r--r--ruby/lib/gitlab/git/repository.rb8
-rw-r--r--ruby/proto/gitaly/remote_pb.rb1
-rw-r--r--ruby/spec/lib/gitaly_server/remote_service_spec.rb21
10 files changed, 117 insertions, 57 deletions
diff --git a/changelogs/unreleased/rs-divergent-refs-response.yml b/changelogs/unreleased/rs-divergent-refs-response.yml
new file mode 100644
index 000000000..e85e96ecf
--- /dev/null
+++ b/changelogs/unreleased/rs-divergent-refs-response.yml
@@ -0,0 +1,5 @@
+---
+title: Add DivergentRefs to UpdateRemoteMirrorResponse
+merge_request: 2028
+author:
+type: added
diff --git a/internal/service/remote/update_remote_mirror_test.go b/internal/service/remote/update_remote_mirror_test.go
index 499c40b13..5242fc0df 100644
--- a/internal/service/remote/update_remote_mirror_test.go
+++ b/internal/service/remote/update_remote_mirror_test.go
@@ -223,8 +223,9 @@ func TestSuccessfulUpdateRemoteMirrorRequestWithKeepDivergentRefs(t *testing.T)
require.NoError(t, err)
require.NoError(t, stream.Send(firstRequest))
- _, err = stream.CloseAndRecv()
+ response, err := stream.CloseAndRecv()
require.NoError(t, err)
+ require.ElementsMatch(t, response.DivergentRefs, [][]byte{[]byte("refs/heads/master")})
mirrorRefs := string(testhelper.MustRunCommand(t, nil, "git", "-C", mirrorPath, "for-each-ref"))
diff --git a/proto/go/gitalypb/remote.pb.go b/proto/go/gitalypb/remote.pb.go
index 9ac3909f5..68b26f61e 100644
--- a/proto/go/gitalypb/remote.pb.go
+++ b/proto/go/gitalypb/remote.pb.go
@@ -371,6 +371,7 @@ func (m *UpdateRemoteMirrorRequest) GetKeepDivergentRefs() bool {
}
type UpdateRemoteMirrorResponse struct {
+ DivergentRefs [][]byte `protobuf:"bytes,1,rep,name=divergent_refs,json=divergentRefs,proto3" json:"divergent_refs,omitempty"`
XXX_NoUnkeyedLiteral struct{} `json:"-"`
XXX_unrecognized []byte `json:"-"`
XXX_sizecache int32 `json:"-"`
@@ -401,6 +402,13 @@ func (m *UpdateRemoteMirrorResponse) XXX_DiscardUnknown() {
var xxx_messageInfo_UpdateRemoteMirrorResponse proto.InternalMessageInfo
+func (m *UpdateRemoteMirrorResponse) GetDivergentRefs() [][]byte {
+ if m != nil {
+ return m.DivergentRefs
+ }
+ return nil
+}
+
type FindRemoteRepositoryRequest struct {
Remote string `protobuf:"bytes,1,opt,name=remote,proto3" json:"remote,omitempty"`
XXX_NoUnkeyedLiteral struct{} `json:"-"`
@@ -721,55 +729,56 @@ func init() {
func init() { proto.RegisterFile("remote.proto", fileDescriptor_eefc82927d57d89b) }
var fileDescriptor_eefc82927d57d89b = []byte{
- // 759 bytes of a gzipped FileDescriptorProto
- 0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0xb4, 0x56, 0xc9, 0x6e, 0xd3, 0x40,
- 0x18, 0x96, 0x93, 0x34, 0xcb, 0x9f, 0x14, 0x25, 0x93, 0xaa, 0x38, 0x4e, 0x25, 0x52, 0x03, 0x92,
- 0x0f, 0x34, 0xa9, 0xca, 0x22, 0x0e, 0x48, 0x88, 0x0a, 0xa1, 0xb2, 0xb4, 0x02, 0x43, 0x2f, 0x5c,
- 0x8c, 0x93, 0x4c, 0x12, 0x2b, 0x8e, 0xc7, 0xcc, 0x4c, 0x0a, 0x79, 0x0b, 0x6e, 0xe5, 0xc0, 0x0b,
- 0x70, 0xe1, 0x31, 0x78, 0xa8, 0x9e, 0xd0, 0x78, 0xc6, 0x89, 0xd3, 0x3a, 0xe1, 0x50, 0xb8, 0x79,
- 0xbe, 0x7f, 0xfb, 0xfe, 0x55, 0x86, 0x0a, 0xc5, 0x13, 0xc2, 0x71, 0x3b, 0xa4, 0x84, 0x13, 0x94,
- 0x1f, 0x7a, 0xdc, 0xf5, 0x67, 0x06, 0xf8, 0x5e, 0xc0, 0x25, 0x66, 0x54, 0xd8, 0xc8, 0xa5, 0xb8,
- 0x2f, 0x5f, 0xe6, 0x2f, 0x0d, 0xaa, 0xcf, 0xfa, 0x7d, 0x3b, 0xb2, 0xb2, 0xf1, 0xe7, 0x29, 0x66,
- 0x1c, 0x3d, 0x06, 0xa0, 0x38, 0x24, 0xcc, 0xe3, 0x84, 0xce, 0x74, 0xad, 0xa5, 0x59, 0xe5, 0x03,
- 0xd4, 0x96, 0xbe, 0xda, 0xf6, 0x5c, 0x72, 0x98, 0xfb, 0xfe, 0xfb, 0x9e, 0x66, 0x27, 0x74, 0x11,
- 0x82, 0x5c, 0xe0, 0x4e, 0xb0, 0x9e, 0x69, 0x69, 0x56, 0xc9, 0x8e, 0xbe, 0x51, 0x15, 0xb2, 0x53,
- 0xea, 0xeb, 0xd9, 0x08, 0x12, 0x9f, 0xe8, 0x2e, 0xdc, 0x98, 0x78, 0x94, 0x12, 0xea, 0x50, 0x3c,
- 0x98, 0xb8, 0x21, 0xd3, 0x37, 0x5a, 0x59, 0xab, 0x64, 0x6f, 0x4a, 0xd4, 0x96, 0xe0, 0xab, 0x5c,
- 0x31, 0x57, 0xdd, 0x88, 0x41, 0xa5, 0x6a, 0xd6, 0xa1, 0x96, 0xe0, 0xcb, 0x42, 0x12, 0x30, 0x6c,
- 0xf6, 0xa0, 0x2e, 0x90, 0x33, 0xfc, 0x1f, 0xf3, 0x30, 0xdb, 0xb0, 0xb5, 0x1c, 0x44, 0x06, 0x47,
- 0xdb, 0x90, 0xa7, 0x98, 0x4d, 0x7d, 0x1e, 0x45, 0x28, 0xda, 0xea, 0x65, 0x9e, 0x6b, 0x60, 0xbc,
- 0xc0, 0xbc, 0x37, 0x7a, 0x19, 0x70, 0x4c, 0x03, 0xd7, 0xff, 0x57, 0xe4, 0x9e, 0x42, 0x4d, 0x76,
- 0xd9, 0x49, 0x38, 0xc8, 0xac, 0x72, 0x60, 0x57, 0xa9, 0x8a, 0x1b, 0x23, 0xe6, 0x43, 0x68, 0xa6,
- 0x12, 0xfb, 0x4b, 0x42, 0xdf, 0x32, 0xd0, 0x38, 0x0d, 0xfb, 0x2e, 0x57, 0x15, 0x38, 0x56, 0xdd,
- 0xba, 0x6e, 0x3e, 0x0d, 0x28, 0x52, 0x3c, 0x70, 0x12, 0x05, 0x2f, 0x50, 0x3c, 0x38, 0x11, 0xb3,
- 0xf3, 0x00, 0xb6, 0x49, 0xe0, 0xcf, 0x9c, 0x2e, 0x75, 0x83, 0xde, 0x08, 0x33, 0x67, 0xe2, 0xf2,
- 0xde, 0xc8, 0x0b, 0x86, 0x7a, 0xb6, 0x95, 0xb5, 0x2a, 0xf6, 0x96, 0x90, 0x1e, 0x2a, 0xe1, 0xb1,
- 0x92, 0xa1, 0x9b, 0x50, 0x60, 0x6c, 0xe4, 0x8c, 0xf1, 0x4c, 0xcf, 0x45, 0xfe, 0xf2, 0x8c, 0x8d,
- 0x5e, 0xe3, 0x19, 0xba, 0x05, 0xe5, 0x71, 0x40, 0xbe, 0x04, 0xce, 0x88, 0x30, 0x2e, 0xa6, 0x4e,
- 0x08, 0x21, 0x82, 0x8e, 0x04, 0x82, 0xda, 0x50, 0x1f, 0x63, 0x1c, 0x3a, 0x7d, 0xef, 0x0c, 0xd3,
- 0x21, 0x0e, 0xb8, 0x18, 0x3b, 0xa6, 0xe7, 0xa3, 0x3a, 0xd4, 0x84, 0xe8, 0x79, 0x2c, 0xb1, 0xf1,
- 0x80, 0x99, 0x3b, 0x60, 0xa4, 0x55, 0x44, 0x8d, 0xa5, 0xa8, 0xb3, 0x17, 0xcc, 0x87, 0x75, 0xde,
- 0x11, 0x55, 0xb1, 0xa8, 0xce, 0x42, 0x14, 0x55, 0xab, 0x64, 0xab, 0x97, 0xf9, 0x08, 0x76, 0xd2,
- 0xcd, 0x16, 0xfd, 0xc1, 0x5f, 0x3d, 0x91, 0x80, 0xea, 0x8f, 0x7c, 0x99, 0x3e, 0xe8, 0x09, 0x3b,
- 0x42, 0x04, 0xc5, 0xeb, 0x77, 0x67, 0xc1, 0x32, 0xb3, 0xc4, 0x72, 0x0f, 0x1a, 0x29, 0xd1, 0x14,
- 0xc5, 0x2a, 0x64, 0x29, 0x1e, 0xa8, 0xbc, 0xc4, 0xa7, 0x79, 0x02, 0xe8, 0x8d, 0xc7, 0xb8, 0x54,
- 0x67, 0xd7, 0xa6, 0x65, 0xfe, 0xd4, 0xa0, 0xbe, 0xe4, 0x50, 0x45, 0x7e, 0x02, 0x05, 0x49, 0x50,
- 0x54, 0x27, 0x6b, 0x95, 0x0f, 0xcc, 0xd8, 0x5d, 0x8a, 0x76, 0x5b, 0xb1, 0x8f, 0x4d, 0x8c, 0x0f,
- 0x90, 0x97, 0xd0, 0xfc, 0x02, 0x68, 0x89, 0x4b, 0xd6, 0x84, 0xd2, 0x40, 0xec, 0x8d, 0x23, 0xee,
- 0x99, 0xac, 0x46, 0x31, 0x02, 0x4e, 0xa9, 0x2f, 0xa6, 0x38, 0x9c, 0x32, 0x29, 0x93, 0xb7, 0xae,
- 0x20, 0xde, 0xa7, 0xd4, 0x3f, 0xf8, 0xb1, 0x01, 0x9b, 0xd2, 0xed, 0x7b, 0x4c, 0xcf, 0xbc, 0x1e,
- 0x46, 0x47, 0x50, 0x9a, 0x5f, 0x31, 0xa4, 0xc7, 0x0c, 0x2f, 0x1f, 0x62, 0xa3, 0x91, 0x22, 0x51,
- 0xb3, 0x95, 0xbf, 0x38, 0xb7, 0x32, 0x45, 0x0d, 0x0d, 0xa0, 0x9e, 0xb2, 0xcb, 0x68, 0x9e, 0xf5,
- 0xea, 0x0b, 0x64, 0xdc, 0x5e, 0xab, 0x73, 0x29, 0xce, 0x3b, 0xa8, 0x24, 0xaf, 0x1f, 0x6a, 0x2e,
- 0xba, 0x74, 0xe5, 0xf0, 0x1a, 0x3b, 0xe9, 0xc2, 0x4b, 0x2e, 0x31, 0xa0, 0xab, 0xcb, 0x83, 0x76,
- 0x63, 0xdb, 0x95, 0xa7, 0xc6, 0x30, 0xd7, 0xa9, 0x2c, 0x07, 0xb1, 0x34, 0x34, 0x86, 0xad, 0xb4,
- 0x75, 0x42, 0x8b, 0xf4, 0x57, 0xef, 0xa8, 0x71, 0x67, 0xbd, 0x92, 0x0a, 0x56, 0xbc, 0x38, 0xb7,
- 0x72, 0xc5, 0x4c, 0x55, 0x43, 0x9f, 0xa0, 0x76, 0x65, 0x2b, 0x50, 0x2b, 0xc5, 0xc9, 0xd2, 0x7a,
- 0x1a, 0xbb, 0x6b, 0x34, 0x96, 0x12, 0xca, 0xa0, 0xb7, 0x50, 0x4e, 0x4c, 0x32, 0x32, 0x52, 0xc7,
- 0x5b, 0x7a, 0x6d, 0xae, 0x19, 0xfd, 0xd8, 0xdf, 0xbe, 0x76, 0xb8, 0xff, 0x51, 0xe8, 0xf9, 0x6e,
- 0xb7, 0xdd, 0x23, 0x93, 0x8e, 0xfc, 0xdc, 0x23, 0x74, 0xd8, 0x91, 0xd6, 0x9d, 0xe8, 0x4f, 0xa1,
- 0x33, 0x24, 0xea, 0x1d, 0x76, 0xbb, 0xf9, 0x08, 0xba, 0xff, 0x27, 0x00, 0x00, 0xff, 0xff, 0xab,
- 0xf9, 0x67, 0x5e, 0x6e, 0x08, 0x00, 0x00,
+ // 772 bytes of a gzipped FileDescriptorProto
+ 0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0xb4, 0x56, 0xcb, 0x6e, 0xd3, 0x4c,
+ 0x14, 0x96, 0x93, 0x34, 0x97, 0x93, 0xb4, 0x4a, 0x26, 0x55, 0x7f, 0xc7, 0xa9, 0xf4, 0xa7, 0x86,
+ 0x4a, 0x59, 0xd0, 0xa4, 0x2a, 0x17, 0xb1, 0x40, 0x42, 0x14, 0x84, 0xca, 0xa5, 0x15, 0x18, 0xba,
+ 0x61, 0x63, 0x9c, 0x64, 0x92, 0x58, 0x71, 0x3c, 0x66, 0x66, 0x52, 0xc8, 0x5b, 0xb0, 0x2b, 0x0b,
+ 0x5e, 0x80, 0x0d, 0x8f, 0xc1, 0x43, 0x75, 0x85, 0xc6, 0x33, 0x4e, 0x9c, 0xd4, 0x09, 0x8b, 0xc2,
+ 0xce, 0x73, 0x2e, 0xdf, 0xf9, 0xce, 0x55, 0x86, 0x12, 0xc5, 0x63, 0xc2, 0x71, 0x2b, 0xa0, 0x84,
+ 0x13, 0x94, 0x1d, 0xb8, 0xdc, 0xf1, 0xa6, 0x06, 0x78, 0xae, 0xcf, 0xa5, 0xcc, 0x28, 0xb1, 0xa1,
+ 0x43, 0x71, 0x4f, 0xbe, 0xcc, 0x9f, 0x1a, 0x94, 0x9f, 0xf4, 0x7a, 0x56, 0xe8, 0x65, 0xe1, 0x4f,
+ 0x13, 0xcc, 0x38, 0x7a, 0x08, 0x40, 0x71, 0x40, 0x98, 0xcb, 0x09, 0x9d, 0xea, 0x5a, 0x43, 0x6b,
+ 0x16, 0x8f, 0x50, 0x4b, 0x62, 0xb5, 0xac, 0x99, 0xe6, 0x38, 0xf3, 0xed, 0xd7, 0x1d, 0xcd, 0x8a,
+ 0xd9, 0x22, 0x04, 0x19, 0xdf, 0x19, 0x63, 0x3d, 0xd5, 0xd0, 0x9a, 0x05, 0x2b, 0xfc, 0x46, 0x65,
+ 0x48, 0x4f, 0xa8, 0xa7, 0xa7, 0x43, 0x91, 0xf8, 0x44, 0xfb, 0xb0, 0x35, 0x76, 0x29, 0x25, 0xd4,
+ 0xa6, 0xb8, 0x3f, 0x76, 0x02, 0xa6, 0x6f, 0x34, 0xd2, 0xcd, 0x82, 0xb5, 0x29, 0xa5, 0x96, 0x14,
+ 0xbe, 0xcc, 0xe4, 0x33, 0xe5, 0x8d, 0x48, 0xa8, 0x4c, 0xcd, 0x2a, 0x54, 0x62, 0x7c, 0x59, 0x40,
+ 0x7c, 0x86, 0xcd, 0x2e, 0x54, 0x85, 0xe4, 0x02, 0xff, 0xc3, 0x3c, 0xcc, 0x16, 0x6c, 0x2f, 0x06,
+ 0x91, 0xc1, 0xd1, 0x0e, 0x64, 0x29, 0x66, 0x13, 0x8f, 0x87, 0x11, 0xf2, 0x96, 0x7a, 0x99, 0x97,
+ 0x1a, 0x18, 0xcf, 0x31, 0xef, 0x0e, 0x5f, 0xf8, 0x1c, 0x53, 0xdf, 0xf1, 0xfe, 0x16, 0xb9, 0xc7,
+ 0x50, 0x91, 0x5d, 0xb6, 0x63, 0x00, 0xa9, 0x55, 0x00, 0x56, 0x99, 0xaa, 0xb8, 0x91, 0xc4, 0xbc,
+ 0x0f, 0xf5, 0x44, 0x62, 0x7f, 0x48, 0xe8, 0x6b, 0x0a, 0x6a, 0xe7, 0x41, 0xcf, 0xe1, 0xaa, 0x02,
+ 0xa7, 0xaa, 0x5b, 0x37, 0xcd, 0xa7, 0x06, 0x79, 0x8a, 0xfb, 0x76, 0xac, 0xe0, 0x39, 0x8a, 0xfb,
+ 0x67, 0x62, 0x76, 0xee, 0xc1, 0x0e, 0xf1, 0xbd, 0xa9, 0xdd, 0xa1, 0x8e, 0xdf, 0x1d, 0x62, 0x66,
+ 0x8f, 0x1d, 0xde, 0x1d, 0xba, 0xfe, 0x40, 0x4f, 0x37, 0xd2, 0xcd, 0x92, 0xb5, 0x2d, 0xb4, 0xc7,
+ 0x4a, 0x79, 0xaa, 0x74, 0xe8, 0x3f, 0xc8, 0x31, 0x36, 0xb4, 0x47, 0x78, 0xaa, 0x67, 0x42, 0xbc,
+ 0x2c, 0x63, 0xc3, 0x57, 0x78, 0x8a, 0xfe, 0x87, 0xe2, 0xc8, 0x27, 0x9f, 0x7d, 0x7b, 0x48, 0x18,
+ 0x17, 0x53, 0x27, 0x94, 0x10, 0x8a, 0x4e, 0x84, 0x04, 0xb5, 0xa0, 0x3a, 0xc2, 0x38, 0xb0, 0x7b,
+ 0xee, 0x05, 0xa6, 0x03, 0xec, 0x73, 0x31, 0x76, 0x4c, 0xcf, 0x86, 0x75, 0xa8, 0x08, 0xd5, 0xb3,
+ 0x48, 0x63, 0xe1, 0x3e, 0x33, 0x9f, 0x82, 0x91, 0x54, 0x11, 0x55, 0xc8, 0x7d, 0xd8, 0x5a, 0x02,
+ 0xd2, 0x42, 0xd6, 0x9b, 0xbd, 0x05, 0x10, 0xd1, 0x0e, 0xd7, 0x9f, 0xcd, 0xf4, 0xac, 0x71, 0xaa,
+ 0xb0, 0x61, 0x3b, 0x84, 0x2a, 0x2c, 0x6a, 0xc1, 0x52, 0x2f, 0xf3, 0x01, 0xec, 0x26, 0xbb, 0xcd,
+ 0xdb, 0x88, 0xbf, 0xb8, 0x22, 0x4f, 0xd5, 0x46, 0xf9, 0x32, 0x3d, 0xd0, 0x63, 0x7e, 0x84, 0x08,
+ 0x12, 0x37, 0x6f, 0xe2, 0x9c, 0x65, 0x6a, 0x81, 0xe5, 0x01, 0xd4, 0x12, 0xa2, 0x29, 0x8a, 0x65,
+ 0x48, 0x53, 0xdc, 0x57, 0x79, 0x89, 0x4f, 0xf3, 0x0c, 0xd0, 0x6b, 0x97, 0x71, 0x69, 0xce, 0x6e,
+ 0x4c, 0xcb, 0xfc, 0xa1, 0x41, 0x75, 0x01, 0x50, 0x45, 0x7e, 0x04, 0x39, 0x49, 0x50, 0xf6, 0xa4,
+ 0x78, 0x64, 0x46, 0x70, 0x09, 0xd6, 0x2d, 0xc5, 0x3e, 0x72, 0x31, 0xde, 0x43, 0x56, 0x8a, 0x66,
+ 0x87, 0x42, 0x8b, 0x1d, 0xbc, 0x3a, 0x14, 0xfa, 0x62, 0xbd, 0x6c, 0x71, 0xf6, 0x64, 0x35, 0xf2,
+ 0xa1, 0xe0, 0x9c, 0x7a, 0x62, 0xd8, 0x83, 0x09, 0x93, 0x3a, 0x79, 0x12, 0x73, 0xe2, 0x7d, 0x4e,
+ 0xbd, 0xa3, 0xef, 0x1b, 0xb0, 0x29, 0x61, 0xdf, 0x61, 0x7a, 0xe1, 0x76, 0x31, 0x3a, 0x81, 0xc2,
+ 0xec, 0xd8, 0x21, 0x3d, 0x62, 0xb8, 0x7c, 0xaf, 0x8d, 0x5a, 0x82, 0x46, 0x5d, 0xc6, 0xec, 0xd5,
+ 0x65, 0x33, 0x95, 0xd7, 0x50, 0x1f, 0xaa, 0x09, 0x2b, 0x8f, 0x66, 0x59, 0xaf, 0x3e, 0x54, 0xc6,
+ 0xad, 0xb5, 0x36, 0x4b, 0x71, 0xde, 0x42, 0x29, 0x7e, 0x24, 0x51, 0x7d, 0xde, 0xa5, 0x6b, 0xf7,
+ 0xd9, 0xd8, 0x4d, 0x56, 0x2e, 0x41, 0x62, 0x40, 0xd7, 0x77, 0x0c, 0xed, 0x45, 0xbe, 0x2b, 0x2f,
+ 0x92, 0x61, 0xae, 0x33, 0x59, 0x0c, 0xd2, 0xd4, 0xd0, 0x08, 0xb6, 0x93, 0xd6, 0x09, 0xcd, 0xd3,
+ 0x5f, 0xbd, 0xa3, 0xc6, 0xed, 0xf5, 0x46, 0x2a, 0x58, 0xfe, 0xea, 0xb2, 0x99, 0xc9, 0xa7, 0xca,
+ 0x1a, 0xfa, 0x08, 0x95, 0x6b, 0x5b, 0x81, 0x1a, 0x09, 0x20, 0x0b, 0xeb, 0x69, 0xec, 0xad, 0xb1,
+ 0x58, 0x48, 0x28, 0x85, 0xde, 0x40, 0x31, 0x36, 0xc9, 0xc8, 0x48, 0x1c, 0x6f, 0x89, 0x5a, 0x5f,
+ 0x33, 0xfa, 0x11, 0xde, 0xa1, 0x76, 0x7c, 0xf8, 0x41, 0xd8, 0x79, 0x4e, 0xa7, 0xd5, 0x25, 0xe3,
+ 0xb6, 0xfc, 0x3c, 0x20, 0x74, 0xd0, 0x96, 0xde, 0xed, 0xf0, 0x87, 0xa2, 0x3d, 0x20, 0xea, 0x1d,
+ 0x74, 0x3a, 0xd9, 0x50, 0x74, 0xf7, 0x77, 0x00, 0x00, 0x00, 0xff, 0xff, 0x49, 0x23, 0x90, 0x30,
+ 0x95, 0x08, 0x00, 0x00,
}
// Reference imports to suppress errors if they are not otherwise used.
diff --git a/proto/remote.proto b/proto/remote.proto
index 624f826fd..67cb012f8 100644
--- a/proto/remote.proto
+++ b/proto/remote.proto
@@ -87,7 +87,9 @@ message UpdateRemoteMirrorRequest {
bool keep_divergent_refs = 6;
}
-message UpdateRemoteMirrorResponse {}
+message UpdateRemoteMirrorResponse {
+ repeated bytes divergent_refs = 1;
+}
message FindRemoteRepositoryRequest {
string remote = 1;
diff --git a/ruby/lib/gitaly_server/remote_service.rb b/ruby/lib/gitaly_server/remote_service.rb
index fa62ec092..66a2d6b7d 100644
--- a/ruby/lib/gitaly_server/remote_service.rb
+++ b/ruby/lib/gitaly_server/remote_service.rb
@@ -2,6 +2,9 @@ module GitalyServer
class RemoteService < Gitaly::RemoteService::Service
include Utils
+ # Maximum number of divergent refs to return in UpdateRemoteMirrorResponse
+ DIVERGENT_REF_LIMIT = 100
+
def add_remote(request, call)
repo = Gitlab::Git::Repository.from_gitaly(request.repository, call)
@@ -38,7 +41,9 @@ module GitalyServer
remote_mirror.update
- Gitaly::UpdateRemoteMirrorResponse.new
+ Gitaly::UpdateRemoteMirrorResponse.new(
+ divergent_refs: remote_mirror.divergent_refs.take(DIVERGENT_REF_LIMIT)
+ )
end
end
end
diff --git a/ruby/lib/gitlab/git/ref.rb b/ruby/lib/gitlab/git/ref.rb
index fdf35e473..e45bec404 100644
--- a/ruby/lib/gitlab/git/ref.rb
+++ b/ruby/lib/gitlab/git/ref.rb
@@ -5,6 +5,9 @@ module Gitlab
class Ref
include Gitlab::EncodingHelper
+ # Canonical refname, including `refs/heads|tags/` prefix
+ attr_reader :refname
+
# Branch or tag name
# without "refs/tags|heads" prefix
attr_reader :name
@@ -34,6 +37,7 @@ module Gitlab
end
def initialize(_repository, name, target, dereferenced_target)
+ @refname = name
@name = Gitlab::Git.ref_name(name)
@dereferenced_target = dereferenced_target
@target = if target.respond_to?(:oid)
diff --git a/ruby/lib/gitlab/git/remote_mirror.rb b/ruby/lib/gitlab/git/remote_mirror.rb
index 2ad02bb26..02a35026d 100644
--- a/ruby/lib/gitlab/git/remote_mirror.rb
+++ b/ruby/lib/gitlab/git/remote_mirror.rb
@@ -3,12 +3,19 @@ module Gitlab
class RemoteMirror
attr_reader :repository, :remote_name, :ssh_auth, :only_branches_matching
+ # An Array of local refnames that have diverged on the remote
+ #
+ # Only populated when `keep_divergent_refs` is enabled
+ attr_reader :divergent_refs
+
def initialize(repository, remote_name, ssh_auth:, only_branches_matching:, keep_divergent_refs:)
@repository = repository
@remote_name = remote_name
@ssh_auth = ssh_auth
@only_branches_matching = only_branches_matching
@keep_divergent_refs = keep_divergent_refs
+
+ @divergent_refs = []
end
def update
@@ -71,7 +78,12 @@ module Gitlab
false
elsif @keep_divergent_refs
# Mirror the ref if its remote counterpart hasn't diverged
- repository.ancestor?(remote_target&.id, local_target&.id)
+ if repository.ancestor?(remote_target&.id, local_target&.id)
+ true
+ else
+ @divergent_refs << ref.refname
+ false
+ end
else
# Attempt to overwrite whatever's on the remote; push rules and
# protected branches may still prevent this
diff --git a/ruby/lib/gitlab/git/repository.rb b/ruby/lib/gitlab/git/repository.rb
index 326c4c563..80b4c24ef 100644
--- a/ruby/lib/gitlab/git/repository.rb
+++ b/ruby/lib/gitlab/git/repository.rb
@@ -181,7 +181,7 @@ module Gitlab
target_commit = Gitlab::Git::Commit.find(self, ref.target)
Gitlab::Git::Tag.new(self,
- name: ref.name,
+ name: ref.canonical_name,
target: ref.target,
target_commit: target_commit,
message: message)
@@ -543,7 +543,7 @@ module Gitlab
rugged_ref = rugged.branches[name]
if rugged_ref
target_commit = Gitlab::Git::Commit.find(self, rugged_ref.target)
- Gitlab::Git::Branch.new(self, rugged_ref.name, rugged_ref.target, target_commit)
+ Gitlab::Git::Branch.new(self, rugged_ref.canonical_name, rugged_ref.target, target_commit)
end
end
@@ -552,7 +552,7 @@ module Gitlab
return unless rugged_ref
- Gitlab::Git::Ref.new(self, rugged_ref.name, rugged_ref.target, rugged_ref.target_id)
+ Gitlab::Git::Ref.new(self, rugged_ref.canonical_name, rugged_ref.target, rugged_ref.target_id)
end
# Delete the specified branch from the repository
@@ -798,7 +798,7 @@ module Gitlab
branches = rugged.branches.each(filter).map do |rugged_ref|
begin
target_commit = Gitlab::Git::Commit.find(self, rugged_ref.target)
- Gitlab::Git::Branch.new(self, rugged_ref.name, rugged_ref.target, target_commit)
+ Gitlab::Git::Branch.new(self, rugged_ref.canonical_name, rugged_ref.target, target_commit)
rescue Rugged::ReferenceError
# Omit invalid branch
end
diff --git a/ruby/proto/gitaly/remote_pb.rb b/ruby/proto/gitaly/remote_pb.rb
index 6f03c83a4..36f985412 100644
--- a/ruby/proto/gitaly/remote_pb.rb
+++ b/ruby/proto/gitaly/remote_pb.rb
@@ -38,6 +38,7 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
optional :keep_divergent_refs, :bool, 6
end
add_message "gitaly.UpdateRemoteMirrorResponse" do
+ repeated :divergent_refs, :bytes, 1
end
add_message "gitaly.FindRemoteRepositoryRequest" do
optional :remote, :string, 1
diff --git a/ruby/spec/lib/gitaly_server/remote_service_spec.rb b/ruby/spec/lib/gitaly_server/remote_service_spec.rb
new file mode 100644
index 000000000..511b4f008
--- /dev/null
+++ b/ruby/spec/lib/gitaly_server/remote_service_spec.rb
@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe GitalyServer::RemoteService do
+ describe '#update_remote_mirror' do
+ it 'assigns a limited number of divergent refs' do
+ stub_const("#{described_class}::DIVERGENT_REF_LIMIT", 2)
+
+ mirror = double(
+ divergent_refs: %w[refs/heads/master refs/heads/develop refs/heads/stable]
+ ).as_null_object
+ stub_const('Gitlab::Git::RemoteMirror', mirror)
+
+ call = double(to_a: [], to_ary: []).as_null_object
+ response = described_class.new.update_remote_mirror(call)
+
+ expect(response.divergent_refs).to eq(%w[refs/heads/master refs/heads/develop])
+ end
+ end
+end