Add reviewer suggestions to MRs

This would be a round robin way of getting a reviewer. Minimal
implementation, to see if it works.

4 files changed, 22 insertions, 6 deletions

diff --git a/Dangerfile b/Dangerfile
index c1c7a1526..5cd823476 100644
--- a/Dangerfile
+++ b/Dangerfile
@@ -1,3 +1,6 @@
+GITALY_TEAM = %w[8bitlife jacobvosmaer-gitlab johncai pokstad1 zj-gitlab]
+
+danger.import_dangerfile(path: 'danger/assignees')
 danger.import_dangerfile(path: 'danger/changelog')
 danger.import_dangerfile(path: 'danger/labels')
 danger.import_dangerfile(path: 'danger/merge_request')
diff --git a/danger/assignees/Dangerfile b/danger/assignees/Dangerfile
new file mode 100644
index 000000000..048c31b04
--- /dev/null
+++ b/danger/assignees/Dangerfile
@@ -0,0 +1,15 @@
+if gitlab.mr_json["assignees"].none?
+  warn "This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time."
+
+  suggestions = (GITALY_TEAM - [gitlab.mr_author]).sample(2)
+
+  case suggestions.size
+  when 0
+  when 1
+    message "Suggested maintainer: @#{suggestions.first}"
+  else
+    message "Suggested maintainers: @#{suggestions.first}, and @#{suggestions.last}"
+  end
+end
+
+# vim: ft=ruby
diff --git a/danger/labels/Dangerfile b/danger/labels/Dangerfile
index a2a442946..e46d50114 100644
--- a/danger/labels/Dangerfile
+++ b/danger/labels/Dangerfile
@@ -11,8 +11,6 @@ def changelog_entry
 end
 
 required_labels = %w[devops::create]
-
-GITALY_TEAM = %w[8bitlife jacobvosmaer-gitlab johncai pokstad1 zj-gitlab]
 required_labels << "group::gitaly" if GITALY_TEAM.include?(gitlab.mr_author)
 
 TYPE_TO_LABEL = {
diff --git a/danger/merge_request/Dangerfile b/danger/merge_request/Dangerfile
index c69204936..38cb859b0 100644
--- a/danger/merge_request/Dangerfile
+++ b/danger/merge_request/Dangerfile
@@ -6,12 +6,12 @@ if gitlab.mr_body.empty?
   fail("Please provide a merge request description")
 end
 
-unless gitlab.mr_json["assignee"]
-  warn "This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time."
-end
-
 if gitlab.mr_title.length > 72
   warn "The title of this merge requests it too long"
 end
 
+unless gitlab.mr_json["force_remove_source_branch"]
+  warn "The source branch can be removed after the merge request is merged, please consider setting this option"
+end
+
 # vim: ft=ruby