diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-06-07 15:32:26 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-06-07 15:51:31 +0300 |
commit | 860328e692a2707c459daec873e3e03935372925 (patch) | |
tree | 5ecbc60991d49e081f2c3fd5909c0db2894a48fa | |
parent | a78993a3de762d87d4a0c9152ab9a35e9c612c5b (diff) |
operations: Remove out-of-date comment
Remove comment stating that we don't verify the branch name and/or user
in `UserCreateBranch()` while we do in `UserDeleteBranch()`: we do it in
both, so this comment is clearly stale.
-rw-r--r-- | internal/gitaly/service/operations/branches.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/internal/gitaly/service/operations/branches.go b/internal/gitaly/service/operations/branches.go index a1bbb6d9c..b209c0bf1 100644 --- a/internal/gitaly/service/operations/branches.go +++ b/internal/gitaly/service/operations/branches.go @@ -146,9 +146,6 @@ func (s *Server) UserUpdateBranch(ctx context.Context, req *gitalypb.UserUpdateB // UserDeleteBranch force-deletes a single branch in the context of a specific user. It executes // hooks and contacts Rails to verify that the user is indeed allowed to delete that branch. func (s *Server) UserDeleteBranch(ctx context.Context, req *gitalypb.UserDeleteBranchRequest) (*gitalypb.UserDeleteBranchResponse, error) { - // That we do the branch name & user check here first only in - // UserDelete but not UserCreate is "intentional", i.e. it's - // always been that way. if len(req.BranchName) == 0 { return nil, status.Errorf(codes.InvalidArgument, "Bad Request (empty branch name)") } |