cli/praefect: Quarantine tests in cli/praefect

Currently several tests in the cli/praefect package are known to be
flaky. These include:

- `TestCheckSubcommand/positional_arguments`
- `TestDatalossSubcommand`
- `TestAcceptDatalossSubcommand`
- `TestConfiguration_validate`

This change uses `testhelper.SkipQuarantinedTest` to quarantine these
tests so it skips test execution until the flakiness is resolved.

4 files changed, 11 insertions, 0 deletions

diff --git a/internal/cli/praefect/subcmd_accept_dataloss_test.go b/internal/cli/praefect/subcmd_accept_dataloss_test.go
index 04896cb7b..b2244f480 100644
--- a/internal/cli/praefect/subcmd_accept_dataloss_test.go
+++ b/internal/cli/praefect/subcmd_accept_dataloss_test.go
@@ -19,6 +19,8 @@ import (
 )
 
 func TestAcceptDatalossSubcommand(t *testing.T) {
+	testhelper.SkipQuarantinedTest(t, "https://gitlab.com/gitlab-org/gitaly/-/issues/5080")
+
 	t.Parallel()
 	const (
 		vs   = "test-virtual-storage-1"
diff --git a/internal/cli/praefect/subcmd_check_test.go b/internal/cli/praefect/subcmd_check_test.go
index fa4055989..aaedc3846 100644
--- a/internal/cli/praefect/subcmd_check_test.go
+++ b/internal/cli/praefect/subcmd_check_test.go
@@ -191,6 +191,11 @@ Checking check 3...Failed (warning) error: i failed but not too badly
 
 	for _, tc := range testCases {
 		t.Run(tc.desc, func(t *testing.T) {
+			testhelper.SkipQuarantinedTest(t,
+				"https://gitlab.com/gitlab-org/gitaly/-/issues/5080",
+				"TestCheckSubcommand/positional_arguments",
+			)
+
 			var stdout bytes.Buffer
 			app := cli.App{
 				Writer: &stdout,
diff --git a/internal/cli/praefect/subcmd_configuration_validate_test.go b/internal/cli/praefect/subcmd_configuration_validate_test.go
index 9cb1364b2..4cf629d1f 100644
--- a/internal/cli/praefect/subcmd_configuration_validate_test.go
+++ b/internal/cli/praefect/subcmd_configuration_validate_test.go
@@ -15,6 +15,8 @@ import (
 )
 
 func TestConfiguration_validate(t *testing.T) {
+	testhelper.SkipQuarantinedTest(t, "https://gitlab.com/gitlab-org/gitaly/-/issues/5080")
+
 	t.Parallel()
 
 	praefectBin := testcfg.BuildBinary(t, testhelper.TempDir(t), "gitlab.com/gitlab-org/gitaly/v15/cmd/praefect")
diff --git a/internal/cli/praefect/subcmd_dataloss_test.go b/internal/cli/praefect/subcmd_dataloss_test.go
index 428672248..a4465d1ae 100644
--- a/internal/cli/praefect/subcmd_dataloss_test.go
+++ b/internal/cli/praefect/subcmd_dataloss_test.go
@@ -20,6 +20,8 @@ import (
 )
 
 func TestDatalossSubcommand(t *testing.T) {
+	testhelper.SkipQuarantinedTest(t, "https://gitlab.com/gitlab-org/gitaly/-/issues/5080")
+
 	t.Parallel()
 	cfg := config.Config{
 		ListenAddr: ":0",