diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-29 12:05:41 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-29 12:05:41 +0300 |
| commit | fd081d5f6c931176eabe891b766588190833d2a7 (patch) | |
| tree | bdb5e17f4cdededc4ccbe11d52462dd13af1de62 | |
| parent | cc42cf8f28dc37bf808dabaac8a055a84b83a5db (diff) | |
operations: Default-enable quarantined voting for UserSquash
We have recently introduced quarantined voting for the UserSquash RPC.
With this change in place, we first stage new objects in a quarantine
directory which only gets merged into the main repository in case the
RPC succeeds. Furthermore, we vote on the generated commits to ensure
that they're the same across all Gitaly nodes in case of a Praefect
setup.
This flag has been rolled out to production on March 24th without any
issues. While the feature seems to be stable enough, we still can't
remove the feature flag though due to backwards compatibility concerns:
all nodes must behave the same already and know how to handle the voting
or otherwise we face problems during zero-downtime upgrades when only
some of the Gitaly nodes have been upgraded yet.
This commit thus default-enables the feature flag before we can remove
it altogether in the next release.
Changelog: changed
| -rw-r--r-- | internal/metadata/featureflag/ff_user_squash_quarantined_voting.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/metadata/featureflag/ff_user_squash_quarantined_voting.go b/internal/metadata/featureflag/ff_user_squash_quarantined_voting.go index 0f3f8e50b..baf41ebf0 100644 --- a/internal/metadata/featureflag/ff_user_squash_quarantined_voting.go +++ b/internal/metadata/featureflag/ff_user_squash_quarantined_voting.go @@ -4,4 +4,4 @@ package featureflag // created by UserSquash into a temporary directory. This quarantine directory will only be migrated // into the final repository when the RPC is successful, including a new transactional vote on the // object ID of the resulting squashed commit. -var UserSquashQuarantinedVoting = NewFeatureFlag("user_squash_quarantined_voting", false) +var UserSquashQuarantinedVoting = NewFeatureFlag("user_squash_quarantined_voting", true) |