Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Steinhardt <psteinhardt@gitlab.com>2022-08-10 13:38:49 +0300
committerPatrick Steinhardt <psteinhardt@gitlab.com>2022-08-11 15:03:14 +0300
commit7e87131edb431c2d7d491f29606fe88955b399eb (patch)
tree104e953f6c154c9f4b656008103ba19f6b9d768a
parentf5d1a379260156181b599d1b45e162212a67e399 (diff)
golangci-lint: Allow `testing.T` as first parameter
We currently exclude a revive rule that `context.Context` should be the first parameter for our test sources. This can be handled better though because golangci-lint allows us to exclude certain types from this rule. Adapt the rule to allow `testing.T` et al before `context.Context` and remove the excluded rule. Interestingly, this now surfaces a whole bunch of `nolint: revive` annotations that aren't needed anymore, so we fix them in the same commit.
-rw-r--r--.golangci.yml10
-rw-r--r--client/pool_options.go2
-rw-r--r--internal/cgroups/noop.go6
-rw-r--r--internal/cgroups/v1_linux.go4
-rw-r--r--internal/command/stats.go12
-rw-r--r--internal/git/gittest/command_factory.go1
-rw-r--r--internal/git/stats/packfile_negotiation.go4
-rw-r--r--internal/gitaly/config/config.go2
-rw-r--r--internal/gitaly/config/ruby.go6
-rw-r--r--internal/gitaly/hook/check.go2
-rw-r--r--internal/gitaly/hook/postreceive.go2
-rw-r--r--internal/gitaly/hook/referencetransaction.go2
-rw-r--r--internal/gitaly/hook/update.go2
-rw-r--r--internal/gitaly/service/operations/apply_patch.go2
-rw-r--r--internal/gitaly/service/operations/branches.go4
-rw-r--r--internal/gitaly/service/operations/cherry_pick.go2
-rw-r--r--internal/gitaly/service/operations/merge.go4
-rw-r--r--internal/gitaly/service/operations/rebase.go2
-rw-r--r--internal/gitaly/service/operations/revert.go2
-rw-r--r--internal/gitaly/service/operations/server.go2
-rw-r--r--internal/gitaly/service/operations/submodules.go2
-rw-r--r--internal/gitaly/service/operations/tags.go4
-rw-r--r--internal/gitaly/service/repository/midx.go2
-rw-r--r--internal/gitaly/service/smarthttp/server.go2
-rw-r--r--internal/gitaly/service/ssh/server.go2
-rw-r--r--internal/gitaly/storage/locator.go2
-rw-r--r--internal/helper/ticker.go8
-rw-r--r--internal/praefect/config/config.go2
-rw-r--r--internal/praefect/config/node.go2
-rw-r--r--internal/praefect/coordinator.go4
-rw-r--r--internal/praefect/datastore/assignment.go2
-rw-r--r--internal/praefect/datastore/collector.go6
-rw-r--r--internal/praefect/datastore/mock.go2
-rw-r--r--internal/praefect/datastore/queue.go10
-rw-r--r--internal/praefect/datastore/repository_store.go14
-rw-r--r--internal/praefect/datastore/repository_store_mock.go16
-rw-r--r--internal/praefect/grpc-proxy/proxy/director.go4
-rw-r--r--internal/praefect/health_checker.go2
-rw-r--r--internal/praefect/metrics/prometheus.go6
-rw-r--r--internal/praefect/nodes/manager.go8
-rw-r--r--internal/praefect/nodes/mock.go12
-rw-r--r--internal/praefect/protoregistry/protoregistry.go2
-rw-r--r--internal/praefect/reconciler/reconciler.go4
-rw-r--r--internal/praefect/replicator.go4
-rw-r--r--internal/praefect/router_per_repository.go4
-rw-r--r--internal/praefect/service/info/dataloss.go2
-rw-r--r--internal/praefect/service/info/replication_factor.go2
-rw-r--r--internal/praefect/service/info/server.go2
-rw-r--r--internal/praefect/service/transaction/server.go4
-rw-r--r--internal/praefect/testserver.go2
-rw-r--r--internal/praefect/transactions/manager.go6
-rw-r--r--internal/testhelper/promtest/counter.go8
-rw-r--r--internal/testhelper/testdb/health.go2
53 files changed, 112 insertions, 115 deletions
diff --git a/.golangci.yml b/.golangci.yml
index a6c5a1351..4c07d598d 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -63,6 +63,12 @@ linters-settings:
# checks to verify we don't use `t.Parallel()` when setting envvars.
- ^os.Setenv$
- ^os.Unsetenv$
+ revive:
+ rules:
+ - name: context-as-argument
+ arguments:
+ # The context should always be first, except in our testing packages.
+ allowTypesBefore: "*testing.T,*testing.B,testing.TB"
stylecheck:
# ST1000 checks for missing package comments. We don't use these for most
# packages, so let's disable this check.
@@ -76,10 +82,6 @@ issues:
# This fine thing excludes all paths which don't end with "_test.go".
path: "^([^_]|_([^t]|t([^e]|e([^s]|s([^t]|t([^\\.]|\\.([^g]|g[^o])))))))*$"
- linters:
- - revive
- text: "context.Context should be the first parameter of a function"
- path: "_test.go"
- - linters:
- errcheck
text: "Error return value of `[^`]+.(Close|Serve)` is not checked"
# Maximum issues count per one linter. Set to 0 to disable. Default is 50.
diff --git a/client/pool_options.go b/client/pool_options.go
index 35f924c41..decb2a812 100644
--- a/client/pool_options.go
+++ b/client/pool_options.go
@@ -7,7 +7,7 @@ type poolOptions struct {
dialOptions []grpc.DialOption
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type PoolOption func(*poolOptions)
func applyPoolOptions(options []PoolOption) *poolOptions {
diff --git a/internal/cgroups/noop.go b/internal/cgroups/noop.go
index feaa0d6ef..4dfc491d4 100644
--- a/internal/cgroups/noop.go
+++ b/internal/cgroups/noop.go
@@ -9,17 +9,17 @@ import (
// NoopManager is a cgroups manager that does nothing
type NoopManager struct{}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (cg *NoopManager) Setup() error {
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (cg *NoopManager) AddCommand(cmd *command.Command, repo repository.GitRepo) (string, error) {
return "", nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (cg *NoopManager) Cleanup() error {
return nil
}
diff --git a/internal/cgroups/v1_linux.go b/internal/cgroups/v1_linux.go
index 17065ba20..9b284dd1f 100644
--- a/internal/cgroups/v1_linux.go
+++ b/internal/cgroups/v1_linux.go
@@ -53,7 +53,7 @@ func newV1Manager(cfg cgroupscfg.Config) *CGroupV1Manager {
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (cg *CGroupV1Manager) Setup() error {
var parentResources specs.LinuxResources
@@ -197,7 +197,7 @@ func (cg *CGroupV1Manager) Describe(ch chan<- *prometheus.Desc) {
prometheus.DescribeByCollect(cg, ch)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (cg *CGroupV1Manager) Cleanup() error {
processCgroupPath := cg.currentProcessCgroup()
diff --git a/internal/command/stats.go b/internal/command/stats.go
index 5fbb7f3b3..6e1be4eb4 100644
--- a/internal/command/stats.go
+++ b/internal/command/stats.go
@@ -9,13 +9,13 @@ import (
type requestStatsKey struct{}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type Stats struct {
registry map[string]int
sync.Mutex
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (stats *Stats) RecordSum(key string, value int) {
stats.Lock()
defer stats.Unlock()
@@ -27,7 +27,7 @@ func (stats *Stats) RecordSum(key string, value int) {
stats.registry[key] = value
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (stats *Stats) RecordMax(key string, value int) {
stats.Lock()
defer stats.Unlock()
@@ -41,7 +41,7 @@ func (stats *Stats) RecordMax(key string, value int) {
stats.registry[key] = value
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (stats *Stats) Fields() logrus.Fields {
stats.Lock()
defer stats.Unlock()
@@ -53,13 +53,13 @@ func (stats *Stats) Fields() logrus.Fields {
return f
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func StatsFromContext(ctx context.Context) *Stats {
stats, _ := ctx.Value(requestStatsKey{}).(*Stats)
return stats
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func InitContextStats(ctx context.Context) context.Context {
return context.WithValue(ctx, requestStatsKey{}, &Stats{
registry: make(map[string]int),
diff --git a/internal/git/gittest/command_factory.go b/internal/git/gittest/command_factory.go
index 25d76f6a6..863de697b 100644
--- a/internal/git/gittest/command_factory.go
+++ b/internal/git/gittest/command_factory.go
@@ -20,7 +20,6 @@ func NewCommandFactory(tb testing.TB, cfg config.Cfg, opts ...git.ExecCommandFac
// GitSupportsStatusFlushing returns whether or not the current version of Git
// supports status flushing.
-//nolint: revive
func GitSupportsStatusFlushing(t *testing.T, ctx context.Context, cfg config.Cfg) bool {
version, err := NewCommandFactory(t, cfg).GitVersion(ctx)
require.NoError(t, err)
diff --git a/internal/git/stats/packfile_negotiation.go b/internal/git/stats/packfile_negotiation.go
index 9fd29b37e..ca152d70e 100644
--- a/internal/git/stats/packfile_negotiation.go
+++ b/internal/git/stats/packfile_negotiation.go
@@ -11,7 +11,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/internal/helper/text"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type PackfileNegotiation struct {
// Total size of all pktlines' data
PayloadSize int64
@@ -31,7 +31,7 @@ type PackfileNegotiation struct {
Filter string
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func ParsePackfileNegotiation(body io.Reader) (PackfileNegotiation, error) {
n := PackfileNegotiation{}
return n, n.Parse(body)
diff --git a/internal/gitaly/config/config.go b/internal/gitaly/config/config.go
index bba1e7d40..8ca0d0d24 100644
--- a/internal/gitaly/config/config.go
+++ b/internal/gitaly/config/config.go
@@ -92,7 +92,7 @@ type Hooks struct {
CustomHooksDir string `toml:"custom_hooks_dir" json:"custom_hooks_dir"`
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type HTTPSettings struct {
ReadTimeout int `toml:"read_timeout" json:"read_timeout"`
User string `toml:"user" json:"user"`
diff --git a/internal/gitaly/config/ruby.go b/internal/gitaly/config/ruby.go
index 5bcc03ab8..032c28456 100644
--- a/internal/gitaly/config/ruby.go
+++ b/internal/gitaly/config/ruby.go
@@ -20,7 +20,7 @@ type Ruby struct {
// Duration is a trick to let our TOML library parse durations from strings.
type Duration time.Duration
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (d *Duration) Duration() time.Duration {
if d != nil {
return time.Duration(*d)
@@ -28,7 +28,7 @@ func (d *Duration) Duration() time.Duration {
return 0
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (d *Duration) UnmarshalText(text []byte) error {
td, err := time.ParseDuration(string(text))
if err == nil {
@@ -37,7 +37,7 @@ func (d *Duration) UnmarshalText(text []byte) error {
return err
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (d Duration) MarshalText() ([]byte, error) {
return []byte(time.Duration(d).String()), nil
}
diff --git a/internal/gitaly/hook/check.go b/internal/gitaly/hook/check.go
index 60f8c473d..181a86240 100644
--- a/internal/gitaly/hook/check.go
+++ b/internal/gitaly/hook/check.go
@@ -6,7 +6,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/internal/gitlab"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *GitLabHookManager) Check(ctx context.Context) (*gitlab.CheckInfo, error) {
return m.gitlabClient.Check(ctx)
}
diff --git a/internal/gitaly/hook/postreceive.go b/internal/gitaly/hook/postreceive.go
index 9ac6e041b..2063b1adf 100644
--- a/internal/gitaly/hook/postreceive.go
+++ b/internal/gitaly/hook/postreceive.go
@@ -116,7 +116,7 @@ func printAlert(m gitlab.PostReceiveMessage, w io.Writer) error {
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *GitLabHookManager) PostReceiveHook(ctx context.Context, repo *gitalypb.Repository, pushOptions, env []string, stdin io.Reader, stdout, stderr io.Writer) error {
payload, err := git.HooksPayloadFromEnv(env)
if err != nil {
diff --git a/internal/gitaly/hook/referencetransaction.go b/internal/gitaly/hook/referencetransaction.go
index 2468f5eb6..b7e76dcee 100644
--- a/internal/gitaly/hook/referencetransaction.go
+++ b/internal/gitaly/hook/referencetransaction.go
@@ -16,7 +16,7 @@ import (
// reference without checking its current value.
var forceDeletionPrefix = fmt.Sprintf("%[1]s %[1]s ", git.ObjectHashSHA1.ZeroOID.String())
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *GitLabHookManager) ReferenceTransactionHook(ctx context.Context, state ReferenceTransactionState, env []string, stdin io.Reader) error {
payload, err := git.HooksPayloadFromEnv(env)
if err != nil {
diff --git a/internal/gitaly/hook/update.go b/internal/gitaly/hook/update.go
index 81251f6ca..8574622f0 100644
--- a/internal/gitaly/hook/update.go
+++ b/internal/gitaly/hook/update.go
@@ -11,7 +11,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *GitLabHookManager) UpdateHook(ctx context.Context, repo *gitalypb.Repository, ref, oldValue, newValue string, env []string, stdout, stderr io.Writer) error {
payload, err := git.HooksPayloadFromEnv(env)
if err != nil {
diff --git a/internal/gitaly/service/operations/apply_patch.go b/internal/gitaly/service/operations/apply_patch.go
index 0a02b7430..c86297abc 100644
--- a/internal/gitaly/service/operations/apply_patch.go
+++ b/internal/gitaly/service/operations/apply_patch.go
@@ -33,7 +33,7 @@ func (er gitError) Error() string {
return er.ErrMsg + ": " + er.Err.Error()
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserApplyPatch(stream gitalypb.OperationService_UserApplyPatchServer) error {
firstRequest, err := stream.Recv()
if err != nil {
diff --git a/internal/gitaly/service/operations/branches.go b/internal/gitaly/service/operations/branches.go
index ebad7a04d..2e99a6547 100644
--- a/internal/gitaly/service/operations/branches.go
+++ b/internal/gitaly/service/operations/branches.go
@@ -13,7 +13,7 @@ import (
"google.golang.org/grpc/status"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserCreateBranch(ctx context.Context, req *gitalypb.UserCreateBranchRequest) (*gitalypb.UserCreateBranchResponse, error) {
if len(req.BranchName) == 0 {
return nil, status.Errorf(codes.InvalidArgument, "Bad Request (empty branch name)")
@@ -101,7 +101,7 @@ func validateUserUpdateBranchGo(req *gitalypb.UserUpdateBranchRequest) error {
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserUpdateBranch(ctx context.Context, req *gitalypb.UserUpdateBranchRequest) (*gitalypb.UserUpdateBranchResponse, error) {
// Validate the request
if err := validateUserUpdateBranchGo(req); err != nil {
diff --git a/internal/gitaly/service/operations/cherry_pick.go b/internal/gitaly/service/operations/cherry_pick.go
index 8732f84cb..fa45958fe 100644
--- a/internal/gitaly/service/operations/cherry_pick.go
+++ b/internal/gitaly/service/operations/cherry_pick.go
@@ -16,7 +16,7 @@ import (
"google.golang.org/grpc/status"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserCherryPick(ctx context.Context, req *gitalypb.UserCherryPickRequest) (*gitalypb.UserCherryPickResponse, error) {
if err := validateCherryPickOrRevertRequest(req); err != nil {
return nil, status.Errorf(codes.InvalidArgument, "UserCherryPick: %v", err)
diff --git a/internal/gitaly/service/operations/merge.go b/internal/gitaly/service/operations/merge.go
index d54b7b8d4..8886340c7 100644
--- a/internal/gitaly/service/operations/merge.go
+++ b/internal/gitaly/service/operations/merge.go
@@ -44,7 +44,7 @@ func validateMergeBranchRequest(request *gitalypb.UserMergeBranchRequest) error
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserMergeBranch(stream gitalypb.OperationService_UserMergeBranchServer) error {
ctx := stream.Context()
@@ -243,7 +243,7 @@ func validateFFRequest(in *gitalypb.UserFFBranchRequest) error {
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserFFBranch(ctx context.Context, in *gitalypb.UserFFBranchRequest) (*gitalypb.UserFFBranchResponse, error) {
if err := validateFFRequest(in); err != nil {
return nil, helper.ErrInvalidArgument(err)
diff --git a/internal/gitaly/service/operations/rebase.go b/internal/gitaly/service/operations/rebase.go
index af727c1ad..b1bbc7448 100644
--- a/internal/gitaly/service/operations/rebase.go
+++ b/internal/gitaly/service/operations/rebase.go
@@ -14,7 +14,7 @@ import (
"google.golang.org/grpc/status"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserRebaseConfirmable(stream gitalypb.OperationService_UserRebaseConfirmableServer) error {
firstRequest, err := stream.Recv()
if err != nil {
diff --git a/internal/gitaly/service/operations/revert.go b/internal/gitaly/service/operations/revert.go
index 2d7775a33..22c5c4527 100644
--- a/internal/gitaly/service/operations/revert.go
+++ b/internal/gitaly/service/operations/revert.go
@@ -14,7 +14,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserRevert(ctx context.Context, req *gitalypb.UserRevertRequest) (*gitalypb.UserRevertResponse, error) {
if err := validateCherryPickOrRevertRequest(req); err != nil {
return nil, helper.ErrInvalidArgument(err)
diff --git a/internal/gitaly/service/operations/server.go b/internal/gitaly/service/operations/server.go
index bfe571c19..3ff19f752 100644
--- a/internal/gitaly/service/operations/server.go
+++ b/internal/gitaly/service/operations/server.go
@@ -18,7 +18,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type Server struct {
gitalypb.UnimplementedOperationServiceServer
hookManager hook.Manager
diff --git a/internal/gitaly/service/operations/submodules.go b/internal/gitaly/service/operations/submodules.go
index aae4b9be5..dd8e3ee70 100644
--- a/internal/gitaly/service/operations/submodules.go
+++ b/internal/gitaly/service/operations/submodules.go
@@ -19,7 +19,7 @@ import (
const userUpdateSubmoduleName = "UserUpdateSubmodule"
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserUpdateSubmodule(ctx context.Context, req *gitalypb.UserUpdateSubmoduleRequest) (*gitalypb.UserUpdateSubmoduleResponse, error) {
if err := validateUserUpdateSubmoduleRequest(req); err != nil {
return nil, status.Errorf(codes.InvalidArgument, userUpdateSubmoduleName+": %v", err)
diff --git a/internal/gitaly/service/operations/tags.go b/internal/gitaly/service/operations/tags.go
index f46528a9d..71909dfb1 100644
--- a/internal/gitaly/service/operations/tags.go
+++ b/internal/gitaly/service/operations/tags.go
@@ -20,7 +20,7 @@ import (
"google.golang.org/grpc/status"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserDeleteTag(ctx context.Context, req *gitalypb.UserDeleteTagRequest) (*gitalypb.UserDeleteTagResponse, error) {
if len(req.TagName) == 0 {
return nil, status.Errorf(codes.InvalidArgument, "empty tag name")
@@ -83,7 +83,7 @@ func validateUserCreateTag(req *gitalypb.UserCreateTagRequest) error {
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) UserCreateTag(ctx context.Context, req *gitalypb.UserCreateTagRequest) (*gitalypb.UserCreateTagResponse, error) {
if err := validateUserCreateTag(req); err != nil {
return nil, helper.ErrInvalidArgumentf("validating request: %w", err)
diff --git a/internal/gitaly/service/repository/midx.go b/internal/gitaly/service/repository/midx.go
index b72cbd3a5..7691c0680 100644
--- a/internal/gitaly/service/repository/midx.go
+++ b/internal/gitaly/service/repository/midx.go
@@ -20,7 +20,7 @@ import (
)
const (
- //nolint: revive // This is unintentionally missing documentation.
+ // This is unintentionally missing documentation.
MidxRelPath = "objects/pack/multi-pack-index"
)
diff --git a/internal/gitaly/service/smarthttp/server.go b/internal/gitaly/service/smarthttp/server.go
index 1ce72fa93..c22609c91 100644
--- a/internal/gitaly/service/smarthttp/server.go
+++ b/internal/gitaly/service/smarthttp/server.go
@@ -47,7 +47,7 @@ func NewServer(
// ServerOpt is a self referential option for server
type ServerOpt func(s *server)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func WithPackfileNegotiationMetrics(c *prometheus.CounterVec) ServerOpt {
return func(s *server) {
s.packfileNegotiationMetrics = c
diff --git a/internal/gitaly/service/ssh/server.go b/internal/gitaly/service/ssh/server.go
index 5b383222a..cddf72d37 100644
--- a/internal/gitaly/service/ssh/server.go
+++ b/internal/gitaly/service/ssh/server.go
@@ -68,7 +68,7 @@ func WithArchiveRequestTimeout(d time.Duration) ServerOpt {
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func WithPackfileNegotiationMetrics(c *prometheus.CounterVec) ServerOpt {
return func(s *server) {
s.packfileNegotiationMetrics = c
diff --git a/internal/gitaly/storage/locator.go b/internal/gitaly/storage/locator.go
index 65333556b..acc41013f 100644
--- a/internal/gitaly/storage/locator.go
+++ b/internal/gitaly/storage/locator.go
@@ -34,7 +34,7 @@ type Locator interface {
StateDir(storageName string) (string, error)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
var ErrRelativePathEscapesRoot = errors.New("relative path escapes root directory")
// ValidateRelativePath validates a relative path by joining it with rootDir and verifying the result
diff --git a/internal/helper/ticker.go b/internal/helper/ticker.go
index d6054422d..4009f951e 100644
--- a/internal/helper/ticker.go
+++ b/internal/helper/ticker.go
@@ -47,16 +47,16 @@ type ManualTicker struct {
ResetFunc func()
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mt *ManualTicker) C() <-chan time.Time { return mt.c }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mt *ManualTicker) Stop() { mt.StopFunc() }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mt *ManualTicker) Reset() { mt.ResetFunc() }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mt *ManualTicker) Tick() { mt.c <- time.Now() }
// NewManualTicker returns a Ticker that can be manually controlled.
diff --git a/internal/praefect/config/config.go b/internal/praefect/config/config.go
index 2d0ae2d3e..5ea334bc9 100644
--- a/internal/praefect/config/config.go
+++ b/internal/praefect/config/config.go
@@ -40,7 +40,7 @@ const (
minimalSyncRunInterval = time.Minute
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type Failover struct {
Enabled bool `toml:"enabled,omitempty"`
// ElectionStrategy is the strategy to use for electing primaries nodes.
diff --git a/internal/praefect/config/node.go b/internal/praefect/config/node.go
index 6347eb8d9..7ed25e955 100644
--- a/internal/praefect/config/node.go
+++ b/internal/praefect/config/node.go
@@ -12,7 +12,7 @@ type Node struct {
Token string `toml:"token,omitempty"`
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (n Node) MarshalJSON() ([]byte, error) {
return json.Marshal(map[string]interface{}{
"storage": n.Storage,
diff --git a/internal/praefect/coordinator.go b/internal/praefect/coordinator.go
index 0e00c03c0..5099a2391 100644
--- a/internal/praefect/coordinator.go
+++ b/internal/praefect/coordinator.go
@@ -235,12 +235,12 @@ func NewCoordinator(
return coordinator
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (c *Coordinator) Describe(descs chan<- *prometheus.Desc) {
prometheus.DescribeByCollect(c, descs)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (c *Coordinator) Collect(metrics chan<- prometheus.Metric) {
c.votersMetric.Collect(metrics)
c.txReplicationCountMetric.Collect(metrics)
diff --git a/internal/praefect/datastore/assignment.go b/internal/praefect/datastore/assignment.go
index 659a394dd..9cfda0aca 100644
--- a/internal/praefect/datastore/assignment.go
+++ b/internal/praefect/datastore/assignment.go
@@ -37,7 +37,7 @@ func NewAssignmentStore(db glsql.Querier, configuredStorages map[string][]string
return AssignmentStore{db: db, configuredStorages: configuredStorages}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s AssignmentStore) GetHostAssignments(ctx context.Context, virtualStorage string, repositoryID int64) ([]string, error) {
configuredStorages, ok := s.configuredStorages[virtualStorage]
if !ok {
diff --git a/internal/praefect/datastore/collector.go b/internal/praefect/datastore/collector.go
index 655f01430..af2b61553 100644
--- a/internal/praefect/datastore/collector.go
+++ b/internal/praefect/datastore/collector.go
@@ -64,14 +64,14 @@ func NewRepositoryStoreCollector(
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (c *RepositoryStoreCollector) Describe(ch chan<- *prometheus.Desc) {
for _, desc := range descriptions {
ch <- desc
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (c *RepositoryStoreCollector) Collect(ch chan<- prometheus.Metric) {
ctx, cancel := context.WithTimeout(context.TODO(), c.timeout)
defer cancel()
@@ -129,7 +129,7 @@ type QueueDepthCollector struct {
db glsql.Querier
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (q *QueueDepthCollector) Describe(ch chan<- *prometheus.Desc) {
ch <- descReplicationQueueDepth
}
diff --git a/internal/praefect/datastore/mock.go b/internal/praefect/datastore/mock.go
index ce6344021..4d9867ec2 100644
--- a/internal/praefect/datastore/mock.go
+++ b/internal/praefect/datastore/mock.go
@@ -9,7 +9,7 @@ type MockReplicationEventQueue struct {
EnqueueFunc func(context.Context, ReplicationEvent) (ReplicationEvent, error)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockReplicationEventQueue) Enqueue(ctx context.Context, event ReplicationEvent) (ReplicationEvent, error) {
return m.EnqueueFunc(ctx, event)
}
diff --git a/internal/praefect/datastore/queue.go b/internal/praefect/datastore/queue.go
index 6b9d7a7ed..2943974ce 100644
--- a/internal/praefect/datastore/queue.go
+++ b/internal/praefect/datastore/queue.go
@@ -66,7 +66,7 @@ type ReplicationJob struct {
Params Params `json:"params"`
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (job *ReplicationJob) Scan(value interface{}) error {
if value == nil {
return nil
@@ -80,7 +80,7 @@ func (job *ReplicationJob) Scan(value interface{}) error {
return json.Unmarshal(d, job)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (job ReplicationJob) Value() (driver.Value, error) {
data, err := json.Marshal(job)
if err != nil {
@@ -208,7 +208,7 @@ type PostgresReplicationEventQueue struct {
qc glsql.Querier
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rq PostgresReplicationEventQueue) Enqueue(ctx context.Context, event ReplicationEvent) (ReplicationEvent, error) {
// When `Enqueue` method is called:
// 1. Insertion of the new record into `replication_queue_lock` table, so we are ensured all events have
@@ -241,7 +241,7 @@ func (rq PostgresReplicationEventQueue) Enqueue(ctx context.Context, event Repli
return events[0], nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rq PostgresReplicationEventQueue) Dequeue(ctx context.Context, virtualStorage, nodeStorage string, count int) ([]ReplicationEvent, error) {
// When `Dequeue` method is called:
// 1. Events with attempts left that are either in `ready` or `failed` state are candidates for dequeuing.
@@ -322,7 +322,7 @@ func (rq PostgresReplicationEventQueue) Dequeue(ctx context.Context, virtualStor
return res, nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rq PostgresReplicationEventQueue) Acknowledge(ctx context.Context, state JobState, ids []uint64) ([]uint64, error) {
// When `Acknowledge` method is called:
// 1. The list of event `id`s and corresponding <lock>s retrieved from `replication_queue` table as passed in by the
diff --git a/internal/praefect/datastore/repository_store.go b/internal/praefect/datastore/repository_store.go
index 03e7a2d08..d18f8c543 100644
--- a/internal/praefect/datastore/repository_store.go
+++ b/internal/praefect/datastore/repository_store.go
@@ -213,7 +213,7 @@ func (rs *PostgresRepositoryStore) MarkStorageUnverified(ctx context.Context, vi
return result.RowsAffected()
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) GetGeneration(ctx context.Context, repositoryID int64, storage string) (int, error) {
const q = `
SELECT generation
@@ -234,7 +234,7 @@ AND storage = $2
return gen, nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) IncrementGeneration(ctx context.Context, repositoryID int64, primary string, secondaries []string) error {
const q = `
WITH updated_replicas AS (
@@ -288,7 +288,7 @@ SELECT
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) SetGeneration(ctx context.Context, repositoryID int64, storage, relativePath string, generation int) error {
const q = `
WITH repository AS (
@@ -352,7 +352,7 @@ ON CONFLICT (virtual_storage, relative_path, storage) DO UPDATE
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) GetReplicatedGeneration(ctx context.Context, repositoryID int64, source, target string) (int, error) {
const q = `
SELECT storage, generation
@@ -487,7 +487,7 @@ FROM (
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) DeleteRepository(ctx context.Context, virtualStorage, relativePath string) (string, []string, error) {
var (
replicaPath string
@@ -571,7 +571,7 @@ WHERE repository_id = (SELECT repository_id FROM repository)
return nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) RenameRepository(ctx context.Context, virtualStorage, relativePath, storage, newRelativePath string) error {
const q = `
WITH repo AS (
@@ -657,7 +657,7 @@ func (rs *PostgresRepositoryStore) getConsistentStorages(ctx context.Context, qu
return replicaPath, consistentStorages, nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (rs *PostgresRepositoryStore) RepositoryExists(ctx context.Context, virtualStorage, relativePath string) (bool, error) {
const q = `
SELECT true
diff --git a/internal/praefect/datastore/repository_store_mock.go b/internal/praefect/datastore/repository_store_mock.go
index 42acafb6e..b2a9f60c9 100644
--- a/internal/praefect/datastore/repository_store_mock.go
+++ b/internal/praefect/datastore/repository_store_mock.go
@@ -28,7 +28,7 @@ type MockRepositoryStore struct {
GetRepositoryMetadataByPathFunc func(ctx context.Context, virtualStorage, relativePath string) (RepositoryMetadata, error)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) GetGeneration(ctx context.Context, repositoryID int64, storage string) (int, error) {
if m.GetGenerationFunc == nil {
return GenerationUnknown, nil
@@ -37,7 +37,7 @@ func (m MockRepositoryStore) GetGeneration(ctx context.Context, repositoryID int
return m.GetGenerationFunc(ctx, repositoryID, storage)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) IncrementGeneration(ctx context.Context, repositoryID int64, primary string, secondaries []string) error {
if m.IncrementGenerationFunc == nil {
return nil
@@ -46,7 +46,7 @@ func (m MockRepositoryStore) IncrementGeneration(ctx context.Context, repository
return m.IncrementGenerationFunc(ctx, repositoryID, primary, secondaries)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) GetReplicatedGeneration(ctx context.Context, repositoryID int64, source, target string) (int, error) {
if m.GetReplicatedGenerationFunc == nil {
return GenerationUnknown, nil
@@ -55,7 +55,7 @@ func (m MockRepositoryStore) GetReplicatedGeneration(ctx context.Context, reposi
return m.GetReplicatedGenerationFunc(ctx, repositoryID, source, target)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) SetGeneration(ctx context.Context, repositoryID int64, storage, relativePath string, generation int) error {
if m.SetGenerationFunc == nil {
return nil
@@ -82,7 +82,7 @@ func (m MockRepositoryStore) SetAuthoritativeReplica(ctx context.Context, virtua
return m.SetAuthoritativeReplicaFunc(ctx, virtualStorage, relativePath, storage)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) DeleteRepository(ctx context.Context, virtualStorage, relativePath string) (string, []string, error) {
if m.DeleteRepositoryFunc == nil {
return "", nil, nil
@@ -105,7 +105,7 @@ func (m MockRepositoryStore) RenameRepositoryInPlace(ctx context.Context, virtua
return m.RenameRepositoryInPlaceFunc(ctx, virtualStorage, relativePath, newRelativePath)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) RenameRepository(ctx context.Context, virtualStorage, relativePath, storage, newRelativePath string) error {
if m.RenameRepositoryFunc == nil {
return nil
@@ -141,7 +141,7 @@ func (m MockRepositoryStore) GetPartiallyAvailableRepositories(ctx context.Conte
return m.GetPartiallyAvailableRepositoriesFunc(ctx, virtualStorage)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) DeleteInvalidRepository(ctx context.Context, repositoryID int64, storage string) error {
if m.DeleteInvalidRepositoryFunc == nil {
return nil
@@ -150,7 +150,7 @@ func (m MockRepositoryStore) DeleteInvalidRepository(ctx context.Context, reposi
return m.DeleteInvalidRepositoryFunc(ctx, repositoryID, storage)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m MockRepositoryStore) RepositoryExists(ctx context.Context, virtualStorage, relativePath string) (bool, error) {
if m.RepositoryExistsFunc == nil {
return true, nil
diff --git a/internal/praefect/grpc-proxy/proxy/director.go b/internal/praefect/grpc-proxy/proxy/director.go
index 5f887213c..97b5be7ba 100644
--- a/internal/praefect/grpc-proxy/proxy/director.go
+++ b/internal/praefect/grpc-proxy/proxy/director.go
@@ -58,12 +58,12 @@ func NewStreamParameters(primary Destination, secondaries []Destination, reqFina
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *StreamParameters) Primary() Destination {
return s.primary
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *StreamParameters) Secondaries() []Destination {
return s.secondaries
}
diff --git a/internal/praefect/health_checker.go b/internal/praefect/health_checker.go
index 45ae4c021..36193812b 100644
--- a/internal/praefect/health_checker.go
+++ b/internal/praefect/health_checker.go
@@ -9,7 +9,7 @@ type HealthChecker interface {
// StaticHealthChecker returns the nodes as always healthy.
type StaticHealthChecker map[string][]string
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (healthyNodes StaticHealthChecker) HealthyNodes() map[string][]string {
return healthyNodes
}
diff --git a/internal/praefect/metrics/prometheus.go b/internal/praefect/metrics/prometheus.go
index f374a5860..f0bd9abee 100644
--- a/internal/praefect/metrics/prometheus.go
+++ b/internal/praefect/metrics/prometheus.go
@@ -54,7 +54,7 @@ func RegisterNodeLatency(conf gitalycfgprom.Config, registerer prometheus.Regist
return nodeLatency, registerer.Register(nodeLatency)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
var MethodTypeCounter = promauto.NewCounterVec(
prometheus.CounterOpts{
Namespace: "gitaly",
@@ -63,7 +63,7 @@ var MethodTypeCounter = promauto.NewCounterVec(
}, []string{"method_type"},
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
var PrimaryGauge = promauto.NewGaugeVec(
prometheus.GaugeOpts{
Namespace: "gitaly",
@@ -72,7 +72,7 @@ var PrimaryGauge = promauto.NewGaugeVec(
}, []string{"virtual_storage", "gitaly_storage"},
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
var NodeLastHealthcheckGauge = promauto.NewGaugeVec(
prometheus.GaugeOpts{
Namespace: "gitaly",
diff --git a/internal/praefect/nodes/manager.go b/internal/praefect/nodes/manager.go
index 4a8692999..d91ef8d0a 100644
--- a/internal/praefect/nodes/manager.go
+++ b/internal/praefect/nodes/manager.go
@@ -33,7 +33,7 @@ type Shard struct {
Secondaries []Node
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s Shard) GetNode(storage string) (Node, error) {
if storage == s.Primary.GetStorage() {
return s.Primary, nil
@@ -260,7 +260,7 @@ func (n *Mgr) GetPrimary(ctx context.Context, virtualStorage string, _ int64) (s
return shard.Primary.GetStorage(), nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (n *Mgr) GetSyncedNode(ctx context.Context, virtualStorageName, repoPath string) (Node, error) {
_, upToDateStorages, err := n.csg.GetConsistentStorages(ctx, virtualStorageName, repoPath)
if err != nil && !errors.As(err, new(commonerr.RepositoryNotFoundError)) {
@@ -297,7 +297,7 @@ func (n *Mgr) GetSyncedNode(ctx context.Context, virtualStorageName, repoPath st
return healthyStorages[rand.Intn(len(healthyStorages))], nil
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (n *Mgr) HealthyNodes() map[string][]string {
healthy := make(map[string][]string, len(n.nodes))
for vs, nodes := range n.nodes {
@@ -314,7 +314,7 @@ func (n *Mgr) HealthyNodes() map[string][]string {
return healthy
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (n *Mgr) Nodes() map[string][]Node { return n.nodes }
func newConnectionStatus(node config.Node, cc *grpc.ClientConn, l logrus.FieldLogger, latencyHist prommetrics.HistogramVec, errorTracker tracker.ErrorTracker) *nodeStatus {
diff --git a/internal/praefect/nodes/mock.go b/internal/praefect/nodes/mock.go
index d11887462..d30ba9461 100644
--- a/internal/praefect/nodes/mock.go
+++ b/internal/praefect/nodes/mock.go
@@ -14,7 +14,7 @@ type MockManager struct {
Storage string
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockManager) GetShard(_ context.Context, storage string) (Shard, error) {
return m.GetShardFunc(storage)
}
@@ -58,17 +58,17 @@ type MockNode struct {
Healthy bool
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockNode) GetStorage() string { return m.GetStorageMethod() }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockNode) IsHealthy() bool { return m.Healthy }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockNode) GetConnection() *grpc.ClientConn { return m.Conn }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockNode) GetAddress() string { return "" }
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockNode) GetToken() string { return "" }
diff --git a/internal/praefect/protoregistry/protoregistry.go b/internal/praefect/protoregistry/protoregistry.go
index 1ee871176..2bfb77706 100644
--- a/internal/praefect/protoregistry/protoregistry.go
+++ b/internal/praefect/protoregistry/protoregistry.go
@@ -100,7 +100,7 @@ func (mi MethodInfo) AdditionalRepo(msg proto.Message) (*gitalypb.Repository, bo
return repo, true, err
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mi MethodInfo) FullMethodName() string {
return mi.fullMethodName
}
diff --git a/internal/praefect/reconciler/reconciler.go b/internal/praefect/reconciler/reconciler.go
index 43a19442d..a04b1ecc0 100644
--- a/internal/praefect/reconciler/reconciler.go
+++ b/internal/praefect/reconciler/reconciler.go
@@ -49,12 +49,12 @@ func NewReconciler(log logrus.FieldLogger, db glsql.Querier, hc praefect.HealthC
return r
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (r *Reconciler) Describe(ch chan<- *prometheus.Desc) {
prometheus.DescribeByCollect(r, ch)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (r *Reconciler) Collect(ch chan<- prometheus.Metric) {
r.reconciliationSchedulingDuration.Collect(ch)
}
diff --git a/internal/praefect/replicator.go b/internal/praefect/replicator.go
index 54ed3ebda..d3d36c586 100644
--- a/internal/praefect/replicator.go
+++ b/internal/praefect/replicator.go
@@ -287,12 +287,12 @@ func NewReplMgr(log logrus.FieldLogger, storageNames map[string][]string, queue
return r
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (r ReplMgr) Describe(ch chan<- *prometheus.Desc) {
prometheus.DescribeByCollect(r, ch)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (r ReplMgr) Collect(ch chan<- prometheus.Metric) {
r.replInFlightMetric.Collect(ch)
}
diff --git a/internal/praefect/router_per_repository.go b/internal/praefect/router_per_repository.go
index 287d8d33b..153bab616 100644
--- a/internal/praefect/router_per_repository.go
+++ b/internal/praefect/router_per_repository.go
@@ -135,7 +135,7 @@ func (r *PerRepositoryRouter) RouteStorageMutator(ctx context.Context, virtualSt
return StorageMutatorRoute{}, errors.New("RouteStorageMutator is not implemented on PerRepositoryRouter")
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (r *PerRepositoryRouter) RouteRepositoryAccessor(ctx context.Context, virtualStorage, relativePath string, forcePrimary bool) (RepositoryAccessorRoute, error) {
healthyNodes, err := r.healthyNodes(virtualStorage)
if err != nil {
@@ -208,7 +208,7 @@ func (r *PerRepositoryRouter) resolveAdditionalReplicaPath(ctx context.Context,
return r.rs.GetReplicaPath(ctx, additionalRepositoryID)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (r *PerRepositoryRouter) RouteRepositoryMutator(ctx context.Context, virtualStorage, relativePath, additionalRelativePath string) (RepositoryMutatorRoute, error) {
healthyNodes, err := r.healthyNodes(virtualStorage)
if err != nil {
diff --git a/internal/praefect/service/info/dataloss.go b/internal/praefect/service/info/dataloss.go
index 1631a50c7..d5ae5c6b9 100644
--- a/internal/praefect/service/info/dataloss.go
+++ b/internal/praefect/service/info/dataloss.go
@@ -6,7 +6,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) DatalossCheck(ctx context.Context, req *gitalypb.DatalossCheckRequest) (*gitalypb.DatalossCheckResponse, error) {
repos, err := s.rs.GetPartiallyAvailableRepositories(ctx, req.GetVirtualStorage())
if err != nil {
diff --git a/internal/praefect/service/info/replication_factor.go b/internal/praefect/service/info/replication_factor.go
index e9e6a5e12..ba4ac1b9d 100644
--- a/internal/praefect/service/info/replication_factor.go
+++ b/internal/praefect/service/info/replication_factor.go
@@ -10,7 +10,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) SetReplicationFactor(ctx context.Context, req *gitalypb.SetReplicationFactorRequest) (*gitalypb.SetReplicationFactorResponse, error) {
resp, err := s.setReplicationFactor(ctx, req)
if err != nil {
diff --git a/internal/praefect/service/info/server.go b/internal/praefect/service/info/server.go
index b6ce28a53..c8fffb6d1 100644
--- a/internal/praefect/service/info/server.go
+++ b/internal/praefect/service/info/server.go
@@ -60,7 +60,7 @@ func NewServer(
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (s *Server) SetAuthoritativeStorage(ctx context.Context, req *gitalypb.SetAuthoritativeStorageRequest) (*gitalypb.SetAuthoritativeStorageResponse, error) {
storages := s.conf.StorageNames()[req.VirtualStorage]
if storages == nil {
diff --git a/internal/praefect/service/transaction/server.go b/internal/praefect/service/transaction/server.go
index 63de4d4a8..7d0af1999 100644
--- a/internal/praefect/service/transaction/server.go
+++ b/internal/praefect/service/transaction/server.go
@@ -10,13 +10,13 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type Server struct {
gitalypb.UnimplementedRefTransactionServer
txMgr *transactions.Manager
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func NewServer(txMgr *transactions.Manager) gitalypb.RefTransactionServer {
return &Server{
txMgr: txMgr,
diff --git a/internal/praefect/testserver.go b/internal/praefect/testserver.go
index 142b46764..fbbd58d2e 100644
--- a/internal/praefect/testserver.go
+++ b/internal/praefect/testserver.go
@@ -181,8 +181,6 @@ func startProcessBacklog(ctx context.Context, replMgr ReplMgr) <-chan struct{} {
// The caller is responsible to call returned testhelper.Cleanup in order to stop the service
// and release all acquired resources.
// The function should be used only for testing purposes and not as part of the production code.
-//
-//nolint:revive
func RunPraefectServer(
t testing.TB,
ctx context.Context,
diff --git a/internal/praefect/transactions/manager.go b/internal/praefect/transactions/manager.go
index 4cd1c7984..e05b2ed7f 100644
--- a/internal/praefect/transactions/manager.go
+++ b/internal/praefect/transactions/manager.go
@@ -15,7 +15,7 @@ import (
"gitlab.com/gitlab-org/gitaly/v15/internal/transaction/voting"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
var ErrNotFound = errors.New("transaction not found")
// Manager handles reference transactions for Praefect. It is required in order
@@ -63,12 +63,12 @@ func NewManager(cfg config.Config) *Manager {
}
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mgr *Manager) Describe(descs chan<- *prometheus.Desc) {
prometheus.DescribeByCollect(mgr, descs)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (mgr *Manager) Collect(metrics chan<- prometheus.Metric) {
mgr.counterMetric.Collect(metrics)
mgr.delayMetric.Collect(metrics)
diff --git a/internal/testhelper/promtest/counter.go b/internal/testhelper/promtest/counter.go
index 576b56643..1d29831e8 100644
--- a/internal/testhelper/promtest/counter.go
+++ b/internal/testhelper/promtest/counter.go
@@ -4,25 +4,25 @@ import (
"sync"
)
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
type MockCounter struct {
m sync.RWMutex
value float64
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockCounter) Value() float64 {
m.m.RLock()
defer m.m.RUnlock()
return m.value
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockCounter) Inc() {
m.Add(1)
}
-//nolint: revive,stylecheck // This is unintentionally missing documentation.
+//nolint: stylecheck // This is unintentionally missing documentation.
func (m *MockCounter) Add(v float64) {
m.m.Lock()
defer m.m.Unlock()
diff --git a/internal/testhelper/testdb/health.go b/internal/testhelper/testdb/health.go
index da33dcdc7..b6822506e 100644
--- a/internal/testhelper/testdb/health.go
+++ b/internal/testhelper/testdb/health.go
@@ -12,8 +12,6 @@ import (
// praefect name -> virtual storage -> storage. On each run, it clears all previous health checks from the table, so the
// passed in nodes are the only ones considered healthy after the function. As the healthy nodes are determined by the time of
// the last successful health check, this should be run in the same transastion as the tested query to prevent flakiness.
-//
-//nolint:revive
func SetHealthyNodes(t testing.TB, ctx context.Context, db glsql.Querier, healthyNodes map[string]map[string][]string) {
t.Helper()