diff options
| author | Jacob Vosmaer <jacob@gitlab.com> | 2020-01-22 14:26:53 +0300 |
|---|---|---|
| committer | Jacob Vosmaer <jacob@gitlab.com> | 2020-01-22 14:26:53 +0300 |
| commit | 3e986e40a8302f372e2c597e65929acf7ac15317 (patch) | |
| tree | 0b60c68c55d7cc423b931569c41e65e5dfa7bfe5 | |
| parent | 8ec87ce1a6a752892f2a452c4d9b4a5823c23944 (diff) | |
| parent | f94b224ea59637fd5b5346ad9f87222a4e2fc65c (diff) | |
Merge branch 'ps-filter-shas-with-signatures-rm-ruby' into 'master'
Remove FilterShasWithSignatures RPC implementation from Gitaly-Ruby
Closes #2300
See merge request gitlab-org/gitaly!1754
| -rw-r--r-- | ruby/.rubocop_todo.yml | 3 | ||||
| -rw-r--r-- | ruby/lib/gitaly_server.rb | 2 | ||||
| -rw-r--r-- | ruby/lib/gitaly_server/commit_service.rb | 15 |
3 files changed, 0 insertions, 20 deletions
diff --git a/ruby/.rubocop_todo.yml b/ruby/.rubocop_todo.yml index 9e688a186..88c94e5e2 100644 --- a/ruby/.rubocop_todo.yml +++ b/ruby/.rubocop_todo.yml @@ -23,7 +23,6 @@ Lint/AmbiguousBlockAssociation: # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: - - 'lib/gitaly_server/commit_service.rb' - 'lib/gitaly_server/conflicts_service.rb' - 'lib/gitaly_server/diff_service.rb' - 'lib/gitaly_server/ref_service.rb' @@ -126,7 +125,6 @@ Style/Alias: # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW Style/CommentAnnotation: Exclude: - - 'lib/gitaly_server/commit_service.rb' - 'lib/gitlab/config.rb' # Offense count: 63 @@ -211,7 +209,6 @@ Style/PreferredHashMethods: Style/RaiseArgs: Exclude: - 'lib/gitaly_server/client.rb' - - 'lib/gitaly_server/commit_service.rb' - 'lib/gitaly_server/conflicts_service.rb' - 'lib/gitaly_server/operations_service.rb' - 'lib/gitaly_server/ref_service.rb' diff --git a/ruby/lib/gitaly_server.rb b/ruby/lib/gitaly_server.rb index fccbd41f9..a57f4dc24 100644 --- a/ruby/lib/gitaly_server.rb +++ b/ruby/lib/gitaly_server.rb @@ -6,7 +6,6 @@ require_relative 'gitlab/git.rb' require_relative 'gitaly_server/client.rb' require_relative 'gitaly_server/utils.rb' require_relative 'gitaly_server/blob_service.rb' -require_relative 'gitaly_server/commit_service.rb' require_relative 'gitaly_server/ref_service.rb' require_relative 'gitaly_server/operations_service.rb' require_relative 'gitaly_server/repository_service.rb' @@ -43,7 +42,6 @@ module GitalyServer end def self.register_handlers(server) - server.handle(CommitService.new) server.handle(RefService.new) server.handle(OperationsService.new) server.handle(RepositoryService.new) diff --git a/ruby/lib/gitaly_server/commit_service.rb b/ruby/lib/gitaly_server/commit_service.rb deleted file mode 100644 index 6f37e1ffb..000000000 --- a/ruby/lib/gitaly_server/commit_service.rb +++ /dev/null @@ -1,15 +0,0 @@ -module GitalyServer - class CommitService < Gitaly::CommitService::Service - def filter_shas_with_signatures(_session, call) - Enumerator.new do |y| - repository = nil - - call.each_remote_read.with_index do |request, index| - repository = Gitlab::Git::Repository.from_gitaly(request.repository, call) if index.zero? - - y << Gitaly::FilterShasWithSignaturesResponse.new(shas: Gitlab::Git::Commit.shas_with_signatures(repository, request.shas)) - end - end - end - end -end |