diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-12-17 09:56:50 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-12-17 11:01:09 +0300 |
| commit | 0fa3cb8bdb7b17a6986494ad633c1b5ba2e5c6a7 (patch) | |
| tree | 5baf37054ef693a10cd546b2cb796ce43261def3 | |
| parent | 61471fff6a262bc2c9c5270016f8a677e48638bb (diff) | |
danger: Move rules into subdirectory
It's best practice for Danger rules to live in a separate "rules/"
directory. Let's move them there, which also allows us to use globs to
import all rules.
| -rw-r--r-- | Dangerfile | 8 | ||||
| -rw-r--r-- | danger/rules/changelog/Dangerfile (renamed from danger/changelog/Dangerfile) | 2 | ||||
| -rw-r--r-- | danger/rules/labels/Dangerfile (renamed from danger/labels/Dangerfile) | 0 | ||||
| -rw-r--r-- | danger/rules/merge_request/Dangerfile (renamed from danger/merge_request/Dangerfile) | 0 | ||||
| -rw-r--r-- | danger/rules/milestones/Dangerfile (renamed from danger/milestones/Dangerfile) | 0 | ||||
| -rw-r--r-- | danger/rules/roulette/Dangerfile (renamed from danger/roulette/Dangerfile) | 0 |
6 files changed, 4 insertions, 6 deletions
diff --git a/Dangerfile b/Dangerfile index 1c614dd60..98b75ad84 100644 --- a/Dangerfile +++ b/Dangerfile @@ -19,11 +19,9 @@ danger.import_plugin('danger/plugins/*.rb') gitlab_dangerfiles.import_dangerfiles -danger.import_dangerfile(path: 'danger/changelog') -danger.import_dangerfile(path: 'danger/labels') -danger.import_dangerfile(path: 'danger/merge_request') -danger.import_dangerfile(path: 'danger/milestones') -danger.import_dangerfile(path: 'danger/roulette') +Dir.each_child('danger/rules') do |rule| + danger.import_dangerfile(path: "danger/rules/#{rule}") +end anything_to_post = status_report.values.any?(&:any?) diff --git a/danger/changelog/Dangerfile b/danger/rules/changelog/Dangerfile index fae781a86..e1079b78a 100644 --- a/danger/changelog/Dangerfile +++ b/danger/rules/changelog/Dangerfile @@ -40,7 +40,7 @@ NO_CHANGELOG_LABELS = [ ].freeze CATEGORIES = YAML - .load_file(File.expand_path('../../.gitlab/changelog_config.yml', __dir__)) + .load_file(File.expand_path('../../../.gitlab/changelog_config.yml', __dir__)) .fetch('categories') .keys .freeze diff --git a/danger/labels/Dangerfile b/danger/rules/labels/Dangerfile index 6bfee7178..6bfee7178 100644 --- a/danger/labels/Dangerfile +++ b/danger/rules/labels/Dangerfile diff --git a/danger/merge_request/Dangerfile b/danger/rules/merge_request/Dangerfile index b9c81d2af..b9c81d2af 100644 --- a/danger/merge_request/Dangerfile +++ b/danger/rules/merge_request/Dangerfile diff --git a/danger/milestones/Dangerfile b/danger/rules/milestones/Dangerfile index ce74bbb87..ce74bbb87 100644 --- a/danger/milestones/Dangerfile +++ b/danger/rules/milestones/Dangerfile diff --git a/danger/roulette/Dangerfile b/danger/rules/roulette/Dangerfile index 80ee666df..80ee666df 100644 --- a/danger/roulette/Dangerfile +++ b/danger/rules/roulette/Dangerfile |