diff options
| author | Paul Okstad <pokstad@gitlab.com> | 2019-07-09 00:20:48 +0300 |
|---|---|---|
| committer | Paul Okstad <pokstad@gitlab.com> | 2019-07-09 00:20:48 +0300 |
| commit | 46856e1fd24d25f22289beefa472736aadc38652 (patch) | |
| tree | d9dcb2bb813b046268abc964de6c525ebf964ea5 | |
| parent | 6de0de1852e5e4810acf4df351d949b8f624476f (diff) | |
| parent | 934d148bcdd6e42115fa81906ceeb3a770812da1 (diff) | |
Merge branch 'docs-sm-clarify-responsibility' into 'master'
Update beginners_guide.md
See merge request gitlab-org/gitaly!1348
| -rw-r--r-- | doc/beginners_guide.md | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/doc/beginners_guide.md b/doc/beginners_guide.md index b27b932e9..8e5e7b615 100644 --- a/doc/beginners_guide.md +++ b/doc/beginners_guide.md @@ -140,7 +140,9 @@ doesn't yet have the new endpoint implemented. We fix this by adding a dummy imp ###### Adding an empty Go implementation for a new RPC -This is a typical Go compiler error after you have have vendored a new protocol: +Often the other developers add a new protocol to gitaly-proto and it could interfere your merge request +due to the lack of corresponding implementations in gitaly. For instance, you'd see the following +Go compiler error in such case: ``` # gitlab.com/gitlab-org/gitaly/internal/service/repository @@ -148,6 +150,9 @@ _build/src/gitlab.com/gitlab-org/gitaly/internal/service/repository/server.go:15 *server does not implement gitaly.RepositoryServiceServer (missing RestoreCustomHooks method) ``` +Remember that this sort of error can be addressed by the following method +(even if you're not the one who added the protocol). + In this case a new RPC called `RestoreCustomHooks` was added to the RepositoryService service, but it does not have an implementation. We fix this by adding a dummy implementation. |