tests: Check errors returned by `CloseSend()`

There's several code sites which invoke `CloseSend()` without checking
the returned error. Do so by calling `require.NoError()`.

5 files changed, 6 insertions, 6 deletions

diff --git a/internal/gitaly/service/smarthttp/receive_pack_test.go b/internal/gitaly/service/smarthttp/receive_pack_test.go
index 4cc67de67..89cac847c 100644
--- a/internal/gitaly/service/smarthttp/receive_pack_test.go
+++ b/internal/gitaly/service/smarthttp/receive_pack_test.go
@@ -306,7 +306,7 @@ func TestFailedReceivePackRequestDueToValidationError(t *testing.T) {
 			require.NoError(t, err)
 
 			require.NoError(t, stream.Send(&rpcRequest))
-			stream.CloseSend()
+			require.NoError(t, stream.CloseSend())
 
 			err = drainPostReceivePackResponse(stream)
 			testhelper.RequireGrpcError(t, err, codes.InvalidArgument)
diff --git a/internal/gitaly/service/smarthttp/upload_pack_test.go b/internal/gitaly/service/smarthttp/upload_pack_test.go
index 33928e304..a2aa66601 100644
--- a/internal/gitaly/service/smarthttp/upload_pack_test.go
+++ b/internal/gitaly/service/smarthttp/upload_pack_test.go
@@ -314,7 +314,7 @@ func makePostUploadPackRequest(ctx context.Context, t *testing.T, serverSocketPa
 
 		_, err = io.Copy(sw, body)
 		require.NoError(t, err)
-		stream.CloseSend()
+		require.NoError(t, stream.CloseSend())
 	}
 
 	responseBuffer := &bytes.Buffer{}
diff --git a/internal/gitaly/service/ssh/upload_archive_test.go b/internal/gitaly/service/ssh/upload_archive_test.go
index 5ff89ae2b..fef7435e2 100644
--- a/internal/gitaly/service/ssh/upload_archive_test.go
+++ b/internal/gitaly/service/ssh/upload_archive_test.go
@@ -96,7 +96,7 @@ func TestFailedUploadArchiveRequestDueToValidationError(t *testing.T) {
 			if err = stream.Send(test.Req); err != nil {
 				t.Fatal(err)
 			}
-			stream.CloseSend()
+			require.NoError(t, stream.CloseSend())
 
 			err = testUploadArchiveFailedResponse(t, stream)
 			testhelper.RequireGrpcError(t, err, test.Code)
diff --git a/internal/gitaly/service/ssh/upload_pack_test.go b/internal/gitaly/service/ssh/upload_pack_test.go
index f638732cd..c3d015a6e 100644
--- a/internal/gitaly/service/ssh/upload_pack_test.go
+++ b/internal/gitaly/service/ssh/upload_pack_test.go
@@ -191,7 +191,7 @@ func TestFailedUploadPackRequestDueToValidationError(t *testing.T) {
 			if err = stream.Send(test.Req); err != nil {
 				t.Fatal(err)
 			}
-			stream.CloseSend()
+			require.NoError(t, stream.CloseSend())
 
 			err = testPostUploadPackFailedResponse(t, stream)
 			testhelper.RequireGrpcError(t, err, test.Code)
diff --git a/internal/middleware/limithandler/limithandler_test.go b/internal/middleware/limithandler/limithandler_test.go
index 65e3bdc2c..4fc39ccfd 100644
--- a/internal/middleware/limithandler/limithandler_test.go
+++ b/internal/middleware/limithandler/limithandler_test.go
@@ -116,7 +116,7 @@ func TestStreamLimitHandler(t *testing.T) {
 				require.NoError(t, err)
 
 				require.NoError(t, stream.Send(&pb.BidirectionalRequest{}))
-				stream.CloseSend()
+				require.NoError(t, stream.CloseSend())
 
 				r, err := stream.Recv()
 				require.NotNil(t, r)
@@ -142,7 +142,7 @@ func TestStreamLimitHandler(t *testing.T) {
 				for i := 0; i < 10; i++ {
 					require.NoError(t, stream.Send(&pb.BidirectionalRequest{}))
 				}
-				stream.CloseSend()
+				require.NoError(t, stream.CloseSend())
 
 				r, err := stream.Recv()
 				require.NotNil(t, r)