diff options
| author | Pavlo Strokov <pstrokov@gitlab.com> | 2020-03-27 15:40:14 +0300 |
|---|---|---|
| committer | Pavlo Strokov <pstrokov@gitlab.com> | 2020-03-27 15:40:14 +0300 |
| commit | 4c6502e7441e25951085d4b8f3134cf5dee41504 (patch) | |
| tree | a6172be804a5e55cade40a439d00ddb75278644b | |
| parent | 8479700f188ecbbf282a7ef73b709d79bb2ef66d (diff) | |
| parent | 80884f067f6bcf03f11ec7076955a3959c8331a7 (diff) | |
Merge branch 'smh-remove-stale-comment' into 'master'
Remove a stale todo comment about replication failures
See merge request gitlab-org/gitaly!1977
| -rw-r--r-- | internal/praefect/replicator.go | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/internal/praefect/replicator.go b/internal/praefect/replicator.go index b497b9cd8..263740747 100644 --- a/internal/praefect/replicator.go +++ b/internal/praefect/replicator.go @@ -407,11 +407,6 @@ func (r ReplMgr) ProcessBacklog(ctx context.Context, b BackoffFunc) error { } } -// TODO: errors that occur during replication should be handled better. Logging -// is a crutch in this situation. Ideally, we need to update state somewhere -// with information regarding the replication failure. See follow up issue: -// https://gitlab.com/gitlab-org/gitaly/issues/2138 - func (r ReplMgr) processReplJob(ctx context.Context, job datastore.ReplJob, sourceCC, targetCC *grpc.ClientConn) error { l := r.log. WithField(logWithReplJobID, job.ID). |