Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Steinhardt <psteinhardt@gitlab.com>2020-11-11 16:52:16 +0300
committerPatrick Steinhardt <psteinhardt@gitlab.com>2020-11-11 16:52:16 +0300
commit79d8edcdf41065d0c57f109f94e95adeaa745706 (patch)
treee883c1422460921b3c8682aad40e904e4b253806
parentcf5239cc721567b6a37f8b2aabd2c54086cd78e7 (diff)
Makefile: Don't cause warnings to abort the Git build
When adding `DEVELOPER=1` to Git's build options like we do, then this enables additional warnings and turns them into compiler errors. This makes perfect sense for a developer, but less so for distributors who want to package Gitaly from source. Most importantly, while Git may build without warnings today, it may not do so tomorrow with an updated compiler version which has shiny new diagnostics. Disable `-Werror` by passing `DEVOPTS=no-error` to fix this.
-rw-r--r--Makefile2
1 files changed, 2 insertions, 0 deletions
diff --git a/Makefile b/Makefile
index 1f4d4d204..eb1b26b32 100644
--- a/Makefile
+++ b/Makefile
@@ -81,6 +81,8 @@ GIT_SOURCE_DIR := ${BUILD_DIR}/src/git
ifeq (${GIT_BUILD_OPTIONS},)
# activate developer checks
GIT_BUILD_OPTIONS += DEVELOPER=1
+ # but don't cause warnings to fail the build
+ GIT_BUILD_OPTIONS += DEVOPTS=no-error
GIT_BUILD_OPTIONS += USE_LIBPCRE2=YesPlease
GIT_BUILD_OPTIONS += NO_PERL=YesPlease
GIT_BUILD_OPTIONS += NO_EXPAT=YesPlease