repository: Properly validate source repo passed to CreateFork

While we verify that the caller indeed passes a source repository to
CreateFork, we don't verify that it also contains sensible data. Fix
this by validating it via `service.ValidateRepository()`.

2 files changed, 6 insertions, 6 deletions

diff --git a/internal/gitaly/service/repository/create_fork.go b/internal/gitaly/service/repository/create_fork.go
index bb172eac5..d10307639 100644
--- a/internal/gitaly/service/repository/create_fork.go
+++ b/internal/gitaly/service/repository/create_fork.go
@@ -13,16 +13,16 @@ import (
 )
 
 func (s *server) CreateFork(ctx context.Context, req *gitalypb.CreateForkRequest) (*gitalypb.CreateForkResponse, error) {
-	targetRepository := req.Repository
-	sourceRepository := req.SourceRepository
-
-	if sourceRepository == nil {
-		return nil, structerr.NewInvalidArgument("empty SourceRepository")
+	if err := service.ValidateRepository(req.GetSourceRepository()); err != nil {
+		return nil, structerr.NewInvalidArgument("validating source repository: %w", err)
 	}
 	if err := service.ValidateRepository(req.GetRepository()); err != nil {
 		return nil, structerr.NewInvalidArgument("%w", err)
 	}
 
+	targetRepository := req.Repository
+	sourceRepository := req.SourceRepository
+
 	if err := repoutil.Create(ctx, s.locator, s.gitCmdFactory, s.txManager, targetRepository, func(repo *gitalypb.Repository) error {
 		targetPath, err := s.locator.GetPath(repo)
 		if err != nil {
diff --git a/internal/gitaly/service/repository/create_fork_test.go b/internal/gitaly/service/repository/create_fork_test.go
index ff68a9051..a1352e1eb 100644
--- a/internal/gitaly/service/repository/create_fork_test.go
+++ b/internal/gitaly/service/repository/create_fork_test.go
@@ -283,7 +283,7 @@ func TestCreateFork_validate(t *testing.T) {
 				if testhelper.IsPraefectEnabled() {
 					return status.Error(codes.AlreadyExists, "route repository creation: reserve repository id: repository already exists")
 				}
-				return status.Error(codes.InvalidArgument, "empty SourceRepository")
+				return status.Error(codes.InvalidArgument, "validating source repository: empty Repository")
 			}(),
 		},
 	} {