diff options
author | James Fargher <proglottis@gmail.com> | 2022-06-22 03:19:35 +0300 |
---|---|---|
committer | James Fargher <proglottis@gmail.com> | 2022-06-22 03:19:35 +0300 |
commit | b7f31ec501e0ef995f8170a2eefbe0e4cc0e1556 (patch) | |
tree | a94e6b169da9289f95c61eb31691c252bb51baa1 | |
parent | c2b476bf52faf71cde1e6182a331887b2b0d2cf7 (diff) | |
parent | 3dfb0d51f6a940ca858b8b5a92d9b53ca937a137 (diff) |
Merge branch 'smh-with-insecure' into 'master'
Replace deprecated WithInsecure with WithTransportCredentials
See merge request gitlab-org/gitaly!4658
45 files changed, 109 insertions, 70 deletions
diff --git a/cmd/praefect/subcmd_test.go b/cmd/praefect/subcmd_test.go index 18943dcef..14d8058c1 100644 --- a/cmd/praefect/subcmd_test.go +++ b/cmd/praefect/subcmd_test.go @@ -10,6 +10,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/health" "google.golang.org/grpc/health/grpc_health_v1" ) @@ -49,7 +50,7 @@ func listenAndServe(t testing.TB, svcs []svcRegistrar) (net.Listener, testhelper // verify the service is up addr := fmt.Sprintf("%s://%s", ln.Addr().Network(), ln.Addr()) - cc, err := grpc.DialContext(ctx, addr, grpc.WithBlock(), grpc.WithInsecure()) + cc, err := grpc.DialContext(ctx, addr, grpc.WithBlock(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) require.NoError(t, cc.Close()) diff --git a/internal/backchannel/backchannel_example_test.go b/internal/backchannel/backchannel_example_test.go index 2176e9866..abc4357bc 100644 --- a/internal/backchannel/backchannel_example_test.go +++ b/internal/backchannel/backchannel_example_test.go @@ -121,7 +121,7 @@ func invokeWithMuxedClient(logger *logrus.Entry, address string) error { } func invokeWithNormalClient(address string) error { - return invokeWithOpts(address, grpc.WithInsecure()) + return invokeWithOpts(address, grpc.WithTransportCredentials(insecure.NewCredentials())) } func invokeWithOpts(address string, opts ...grpc.DialOption) error { diff --git a/internal/backchannel/backchannel_test.go b/internal/backchannel/backchannel_test.go index 9973a7fae..e8fc30636 100644 --- a/internal/backchannel/backchannel_test.go +++ b/internal/backchannel/backchannel_test.go @@ -92,7 +92,7 @@ func TestBackchannel_concurrentRequestsFromMultipleClients(t *testing.T) { defer wg.Done() <-start - client, err := grpc.Dial(ln.Addr().String(), grpc.WithInsecure()) + client, err := grpc.Dial(ln.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) if !assert.NoError(t, err) { return } @@ -272,7 +272,7 @@ func Benchmark(b *testing.B) { go srv.Serve(ln) ctx := testhelper.Context(b) - opts := []grpc.DialOption{grpc.WithBlock(), grpc.WithInsecure()} + opts := []grpc.DialOption{grpc.WithBlock(), grpc.WithTransportCredentials(insecure.NewCredentials())} if tc.multiplexed { clientHandshaker := NewClientHandshaker(newLogger(), func() Server { return grpc.NewServer() }) opts = []grpc.DialOption{ diff --git a/internal/backchannel/server.go b/internal/backchannel/server.go index b277b727a..9e0f0537a 100644 --- a/internal/backchannel/server.go +++ b/internal/backchannel/server.go @@ -10,6 +10,7 @@ import ( "github.com/sirupsen/logrus" "google.golang.org/grpc" "google.golang.org/grpc/credentials" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/peer" ) @@ -114,12 +115,12 @@ func (s *ServerHandshaker) Handshake(conn net.Conn, authInfo credentials.AuthInf } // The address does not actually matter but we set it so clientConn.Target returns a meaningful value. - // WithInsecure is used as the multiplexer operates within a TLS session already if one is configured. + // Insecure credentials are used as the multiplexer operates within a TLS session already if one is configured. backchannelConn, err := grpc.Dial( "multiplexed/"+conn.RemoteAddr().String(), append( s.dialOpts, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(func(context.Context, string) (net.Conn, error) { return muxSession.Open() }), )..., ) diff --git a/internal/gitaly/client/dial.go b/internal/gitaly/client/dial.go index 4b08c2396..4b76b3756 100644 --- a/internal/gitaly/client/dial.go +++ b/internal/gitaly/client/dial.go @@ -115,7 +115,7 @@ func Dial(ctx context.Context, rawAddress string, connOpts []grpc.DialOption, ha } if transportCredentials == nil { - connOpts = append(connOpts, grpc.WithInsecure()) + connOpts = append(connOpts, grpc.WithTransportCredentials(insecure.NewCredentials())) } else { connOpts = append(connOpts, grpc.WithTransportCredentials(transportCredentials)) } diff --git a/internal/gitaly/rubyserver/health.go b/internal/gitaly/rubyserver/health.go index cf12a8e63..2802487c5 100644 --- a/internal/gitaly/rubyserver/health.go +++ b/internal/gitaly/rubyserver/health.go @@ -7,13 +7,14 @@ import ( "time" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" healthpb "google.golang.org/grpc/health/grpc_health_v1" ) func ping(address string) error { conn, err := grpc.Dial( address, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), // Use a custom dialer to ensure that we don't experience // issues in environments that have proxy configurations // https://gitlab.com/gitlab-org/gitaly/merge_requests/1072#note_140408512 diff --git a/internal/gitaly/rubyserver/rubyserver.go b/internal/gitaly/rubyserver/rubyserver.go index 5ac213e72..76c901a84 100644 --- a/internal/gitaly/rubyserver/rubyserver.go +++ b/internal/gitaly/rubyserver/rubyserver.go @@ -25,6 +25,7 @@ import ( grpccorrelation "gitlab.com/gitlab-org/labkit/correlation/grpc" grpctracing "gitlab.com/gitlab-org/labkit/tracing/grpc" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) // ConnectTimeout is the timeout for establishing a connection to the gitaly-ruby process. @@ -306,7 +307,7 @@ func (s *Server) createConnection(ctx context.Context) (*grpc.ClientConn, error) func dialOptions() []grpc.DialOption { return []grpc.DialOption{ grpc.WithBlock(), // With this we get retries. Without, connections fail fast. - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), // Use a custom dialer to ensure that we don't experience // issues in environments that have proxy configurations // https://gitlab.com/gitlab-org/gitaly/merge_requests/1072#note_140408512 diff --git a/internal/gitaly/server/auth_test.go b/internal/gitaly/server/auth_test.go index ea8e4a691..e650fbd10 100644 --- a/internal/gitaly/server/auth_test.go +++ b/internal/gitaly/server/auth_test.go @@ -34,6 +34,7 @@ import ( "google.golang.org/grpc" "google.golang.org/grpc/codes" "google.golang.org/grpc/credentials" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/health" healthpb "google.golang.org/grpc/health/grpc_health_v1" ) @@ -45,7 +46,7 @@ func TestMain(m *testing.M) { func TestSanity(t *testing.T) { serverSocketPath := runServer(t, testcfg.Build(t)) - conn, err := dial(serverSocketPath, []grpc.DialOption{grpc.WithInsecure()}) + conn, err := dial(serverSocketPath, []grpc.DialOption{grpc.WithTransportCredentials(insecure.NewCredentials())}) require.NoError(t, err) t.Cleanup(func() { conn.Close() }) @@ -102,7 +103,7 @@ func TestAuthFailures(t *testing.T) { })) serverSocketPath := runServer(t, cfg) - connOpts := append(tc.opts, grpc.WithInsecure()) + connOpts := append(tc.opts, grpc.WithTransportCredentials(insecure.NewCredentials())) conn, err := dial(serverSocketPath, connOpts) require.NoError(t, err, tc.desc) t.Cleanup(func() { conn.Close() }) @@ -145,7 +146,7 @@ func TestAuthSuccess(t *testing.T) { })) serverSocketPath := runServer(t, cfg) - connOpts := append(tc.opts, grpc.WithInsecure()) + connOpts := append(tc.opts, grpc.WithTransportCredentials(insecure.NewCredentials())) conn, err := dial(serverSocketPath, connOpts) require.NoError(t, err, tc.desc) t.Cleanup(func() { conn.Close() }) @@ -176,7 +177,7 @@ func newOperationClient(t *testing.T, token, serverSocketPath string) (gitalypb. t.Helper() connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(token)), } conn, err := grpc.Dial(serverSocketPath, connOpts...) @@ -260,7 +261,7 @@ func runSecureServer(t *testing.T, cfg config.Cfg) string { func TestUnaryNoAuth(t *testing.T) { cfg := testcfg.Build(t, testcfg.WithBase(config.Cfg{Auth: auth.Config{Token: "testtoken"}})) path := runServer(t, cfg) - conn, err := grpc.Dial(path, grpc.WithInsecure()) + conn, err := grpc.Dial(path, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer testhelper.MustClose(t, conn) ctx := testhelper.Context(t) @@ -281,7 +282,7 @@ func TestStreamingNoAuth(t *testing.T) { cfg := testcfg.Build(t, testcfg.WithBase(config.Cfg{Auth: auth.Config{Token: "testtoken"}})) path := runServer(t, cfg) - conn, err := dial(path, []grpc.DialOption{grpc.WithInsecure()}) + conn, err := dial(path, []grpc.DialOption{grpc.WithTransportCredentials(insecure.NewCredentials())}) require.NoError(t, err) t.Cleanup(func() { conn.Close() }) ctx := testhelper.Context(t) diff --git a/internal/gitaly/server/server_factory_test.go b/internal/gitaly/server/server_factory_test.go index 364238170..a0cfafd1f 100644 --- a/internal/gitaly/server/server_factory_test.go +++ b/internal/gitaly/server/server_factory_test.go @@ -24,6 +24,7 @@ import ( "google.golang.org/grpc" "google.golang.org/grpc/codes" "google.golang.org/grpc/credentials" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/health" healthpb "google.golang.org/grpc/health/grpc_health_v1" "google.golang.org/grpc/status" @@ -298,7 +299,7 @@ func TestGitalyServerFactory_closeOrder(t *testing.T) { go server.Serve(ln) - conn, err := grpc.DialContext(ctx, ln.Addr().String(), grpc.WithInsecure()) + conn, err := grpc.DialContext(ctx, ln.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) *builder.conn = conn diff --git a/internal/gitaly/service/blob/testhelper_test.go b/internal/gitaly/service/blob/testhelper_test.go index 40bb4f37d..8a1c0fb65 100644 --- a/internal/gitaly/service/blob/testhelper_test.go +++ b/internal/gitaly/service/blob/testhelper_test.go @@ -14,6 +14,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -43,7 +44,7 @@ func setup(ctx context.Context, tb testing.TB) (config.Cfg, *gitalypb.Repository }) cfg.SocketPath = addr - conn, err := grpc.Dial(addr, grpc.WithInsecure()) + conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(tb, err) tb.Cleanup(func() { conn.Close() }) diff --git a/internal/gitaly/service/cleanup/testhelper_test.go b/internal/gitaly/service/cleanup/testhelper_test.go index e29e74791..e869be767 100644 --- a/internal/gitaly/service/cleanup/testhelper_test.go +++ b/internal/gitaly/service/cleanup/testhelper_test.go @@ -14,6 +14,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -59,7 +60,7 @@ func runCleanupServiceServer(t *testing.T, cfg config.Cfg) string { func newCleanupServiceClient(t *testing.T, serverSocketPath string) (gitalypb.CleanupServiceClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/gitaly/service/commit/testhelper_test.go b/internal/gitaly/service/commit/testhelper_test.go index f304c6981..ad93dcedf 100644 --- a/internal/gitaly/service/commit/testhelper_test.go +++ b/internal/gitaly/service/commit/testhelper_test.go @@ -17,6 +17,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/protobuf/types/known/timestamppb" ) @@ -86,7 +87,7 @@ func newCommitServiceClient(t testing.TB, serviceSocketPath string) gitalypb.Com t.Helper() connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serviceSocketPath, connOpts...) require.NoError(t, err) diff --git a/internal/gitaly/service/conflicts/testhelper_test.go b/internal/gitaly/service/conflicts/testhelper_test.go index edd430efe..efb45bf0a 100644 --- a/internal/gitaly/service/conflicts/testhelper_test.go +++ b/internal/gitaly/service/conflicts/testhelper_test.go @@ -17,6 +17,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -80,7 +81,7 @@ func runConflictsServer(t testing.TB, cfg config.Cfg, hookManager hook.Manager) func NewConflictsClient(t testing.TB, serverSocketPath string) (gitalypb.ConflictsServiceClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) diff --git a/internal/gitaly/service/diff/testhelper_test.go b/internal/gitaly/service/diff/testhelper_test.go index 64634f3f4..c5094df10 100644 --- a/internal/gitaly/service/diff/testhelper_test.go +++ b/internal/gitaly/service/diff/testhelper_test.go @@ -14,6 +14,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -43,7 +44,7 @@ func setupDiffService(ctx context.Context, t testing.TB, opt ...testserver.Gital }, opt...) cfg.SocketPath = addr - conn, err := grpc.Dial(addr, grpc.WithInsecure()) + conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) diff --git a/internal/gitaly/service/hook/reference_transaction_test.go b/internal/gitaly/service/hook/reference_transaction_test.go index 9bc189af1..b466cee33 100644 --- a/internal/gitaly/service/hook/reference_transaction_test.go +++ b/internal/gitaly/service/hook/reference_transaction_test.go @@ -19,6 +19,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" ) type testTransactionServer struct { @@ -109,7 +110,7 @@ func TestReferenceTransactionHook(t *testing.T) { listener, err := net.Listen("tcp", "127.0.0.1:0") require.NoError(t, err) - backchannelConn, err := grpc.Dial(listener.Addr().String(), grpc.WithInsecure()) + backchannelConn, err := grpc.Dial(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer backchannelConn.Close() diff --git a/internal/gitaly/service/hook/testhelper_test.go b/internal/gitaly/service/hook/testhelper_test.go index bce6b9897..d01156891 100644 --- a/internal/gitaly/service/hook/testhelper_test.go +++ b/internal/gitaly/service/hook/testhelper_test.go @@ -14,6 +14,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -39,7 +40,7 @@ func newHooksClient(t testing.TB, serverSocketPath string) (gitalypb.HookService t.Helper() connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/gitaly/service/internalgitaly/testhelper_test.go b/internal/gitaly/service/internalgitaly/testhelper_test.go index 0af37d9af..62e8c8dc3 100644 --- a/internal/gitaly/service/internalgitaly/testhelper_test.go +++ b/internal/gitaly/service/internalgitaly/testhelper_test.go @@ -10,6 +10,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -20,7 +21,7 @@ func setupInternalGitalyService(t *testing.T, cfg config.Cfg, internalService gi add := testserver.RunGitalyServer(t, cfg, nil, func(srv *grpc.Server, deps *service.Dependencies) { gitalypb.RegisterInternalGitalyServer(srv, internalService) }, testserver.WithDisablePraefect()) - conn, err := grpc.Dial(add, grpc.WithInsecure()) + conn, err := grpc.Dial(add, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) diff --git a/internal/gitaly/service/namespace/testhelper_test.go b/internal/gitaly/service/namespace/testhelper_test.go index adaa3e58a..bc7c9e90c 100644 --- a/internal/gitaly/service/namespace/testhelper_test.go +++ b/internal/gitaly/service/namespace/testhelper_test.go @@ -11,6 +11,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func setupNamespaceService(t testing.TB, opts ...testserver.GitalyServerOpt) (config.Cfg, gitalypb.NamespaceServiceClient) { @@ -21,7 +22,7 @@ func setupNamespaceService(t testing.TB, opts ...testserver.GitalyServerOpt) (co gitalypb.RegisterNamespaceServiceServer(srv, NewServer(deps.GetLocator())) }, opts...) - conn, err := grpc.Dial(addr, grpc.WithInsecure()) + conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) diff --git a/internal/gitaly/service/objectpool/fetch_into_object_pool_test.go b/internal/gitaly/service/objectpool/fetch_into_object_pool_test.go index 40fe9bce2..c6539541c 100644 --- a/internal/gitaly/service/objectpool/fetch_into_object_pool_test.go +++ b/internal/gitaly/service/objectpool/fetch_into_object_pool_test.go @@ -24,6 +24,7 @@ import ( "gitlab.com/gitlab-org/labkit/log" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/status" ) @@ -95,7 +96,7 @@ func TestFetchIntoObjectPool_hooks(t *testing.T) { Seed: gittest.SeedGitLabTest, }) - conn, err := grpc.Dial(cfg.SocketPath, grpc.WithInsecure()) + conn, err := grpc.Dial(cfg.SocketPath, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer testhelper.MustClose(t, conn) @@ -138,7 +139,7 @@ func TestFetchIntoObjectPool_CollectLogStatistics(t *testing.T) { Seed: gittest.SeedGitLabTest, }) - conn, err := grpc.Dial(cfg.SocketPath, grpc.WithInsecure()) + conn, err := grpc.Dial(cfg.SocketPath, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) client := gitalypb.NewObjectPoolServiceClient(conn) diff --git a/internal/gitaly/service/objectpool/testhelper_test.go b/internal/gitaly/service/objectpool/testhelper_test.go index 5a25dbee3..82793239d 100644 --- a/internal/gitaly/service/objectpool/testhelper_test.go +++ b/internal/gitaly/service/objectpool/testhelper_test.go @@ -24,6 +24,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -52,7 +53,7 @@ func setup(ctx context.Context, t *testing.T, opts ...testserver.GitalyServerOpt locator := config.NewLocator(cfg) cfg.SocketPath = runObjectPoolServer(t, cfg, locator, testhelper.NewDiscardingLogger(t), opts...) - conn, err := grpc.Dial(cfg.SocketPath, grpc.WithInsecure()) + conn, err := grpc.Dial(cfg.SocketPath, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) diff --git a/internal/gitaly/service/operations/testhelper_test.go b/internal/gitaly/service/operations/testhelper_test.go index 4160e5485..4adb75e5f 100644 --- a/internal/gitaly/service/operations/testhelper_test.go +++ b/internal/gitaly/service/operations/testhelper_test.go @@ -21,6 +21,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) var ( @@ -135,7 +136,7 @@ func runOperationServiceServer(t testing.TB, cfg config.Cfg, options ...testserv func newOperationClient(t testing.TB, serverSocketPath string) (gitalypb.OperationServiceClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/gitaly/service/ref/testhelper_test.go b/internal/gitaly/service/ref/testhelper_test.go index 49dc0fd37..dc1c6e498 100644 --- a/internal/gitaly/service/ref/testhelper_test.go +++ b/internal/gitaly/service/ref/testhelper_test.go @@ -17,6 +17,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) var localBranches = map[string]*gitalypb.GitCommit{ @@ -81,7 +82,7 @@ func runRefServiceServer(t testing.TB, cfg config.Cfg) string { func newRefServiceClient(t testing.TB, serverSocketPath string) (gitalypb.RefServiceClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) require.NoError(t, err) diff --git a/internal/gitaly/service/remote/testhelper_test.go b/internal/gitaly/service/remote/testhelper_test.go index be730c42d..5edddfec1 100644 --- a/internal/gitaly/service/remote/testhelper_test.go +++ b/internal/gitaly/service/remote/testhelper_test.go @@ -13,6 +13,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -60,7 +61,7 @@ func newRemoteClient(t *testing.T, serverSocketPath string) (gitalypb.RemoteServ t.Helper() connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/gitaly/service/server/info_test.go b/internal/gitaly/service/server/info_test.go index 79ddab2b4..018806c0e 100644 --- a/internal/gitaly/service/server/info_test.go +++ b/internal/gitaly/service/server/info_test.go @@ -17,6 +17,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" ) func TestGitalyServerInfo(t *testing.T) { @@ -65,7 +66,7 @@ func TestServerNoAuth(t *testing.T) { addr := runServer(t, cfg) - conn, err := grpc.Dial(addr, grpc.WithInsecure()) + conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) ctx := testhelper.Context(t) @@ -78,7 +79,7 @@ func TestServerNoAuth(t *testing.T) { func newServerClient(t *testing.T, serverSocketPath string) gitalypb.ServerServiceClient { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(testhelper.RepositoryAuthToken)), } conn, err := grpc.Dial(serverSocketPath, connOpts...) diff --git a/internal/gitaly/service/smarthttp/testhelper_test.go b/internal/gitaly/service/smarthttp/testhelper_test.go index b40ad42c2..9e69d15f7 100644 --- a/internal/gitaly/service/smarthttp/testhelper_test.go +++ b/internal/gitaly/service/smarthttp/testhelper_test.go @@ -16,6 +16,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) const ( @@ -63,7 +64,7 @@ func newSmartHTTPClient(t *testing.T, serverSocketPath, token string) (gitalypb. t.Helper() connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(token)), } conn, err := grpc.Dial(serverSocketPath, connOpts...) diff --git a/internal/gitaly/service/ssh/testhelper_test.go b/internal/gitaly/service/ssh/testhelper_test.go index 03cdb977c..1ad2ab99a 100644 --- a/internal/gitaly/service/ssh/testhelper_test.go +++ b/internal/gitaly/service/ssh/testhelper_test.go @@ -11,6 +11,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func TestMain(m *testing.M) { @@ -45,7 +46,7 @@ func runSSHServerWithOptions(t *testing.T, cfg config.Cfg, opts []ServerOpt, ser func newSSHClient(t *testing.T, serverSocketPath string) (gitalypb.SSHServiceClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/gitaly/service/wiki/testhelper_test.go b/internal/gitaly/service/wiki/testhelper_test.go index 9708eff11..8fbed8ef4 100644 --- a/internal/gitaly/service/wiki/testhelper_test.go +++ b/internal/gitaly/service/wiki/testhelper_test.go @@ -21,6 +21,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) type createWikiPageOpts struct { @@ -97,7 +98,7 @@ func setupWikiService(t testing.TB, cfg config.Cfg, rubySrv *rubyserver.Server) func newWikiClient(t testing.TB, serverSocketPath string) gitalypb.WikiServiceClient { t.Helper() - conn, err := grpc.Dial(serverSocketPath, grpc.WithInsecure()) + conn, err := grpc.Dial(serverSocketPath, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { conn.Close() }) return gitalypb.NewWikiServiceClient(conn) diff --git a/internal/helper/chunk/chunker_test.go b/internal/helper/chunk/chunker_test.go index a7e0b3297..a4b9f75ca 100644 --- a/internal/helper/chunk/chunker_test.go +++ b/internal/helper/chunk/chunker_test.go @@ -9,6 +9,7 @@ import ( test "gitlab.com/gitlab-org/gitaly/v15/internal/helper/chunk/testdata" "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/protobuf/proto" "google.golang.org/protobuf/types/known/wrapperspb" ) @@ -89,7 +90,7 @@ func runServer(t *testing.T, s *server, opt ...grpc.ServerOption) (*grpc.Server, func newClient(t *testing.T, serverSocketPath string) (test.TestClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/listenmux/mux_test.go b/internal/listenmux/mux_test.go index c9e8ba9ab..bbd7b82d2 100644 --- a/internal/listenmux/mux_test.go +++ b/internal/listenmux/mux_test.go @@ -66,7 +66,7 @@ func TestMux_normalClientNoMux(t *testing.T) { addr := serverWithHandshaker(t, nil) - cc, err := grpc.Dial(addr, grpc.WithInsecure()) + cc, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer cc.Close() @@ -83,7 +83,7 @@ func TestMux_normalClientMuxIgnored(t *testing.T) { }), ) - cc, err := grpc.Dial(addr, grpc.WithInsecure()) + cc, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer cc.Close() @@ -104,7 +104,7 @@ func TestMux_muxClientPassesThrough(t *testing.T) { cc, err := grpc.Dial( "ignored", - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(func(context.Context, string) (net.Conn, error) { c, err := net.Dial("tcp", addr) if err != nil { @@ -264,7 +264,7 @@ func TestMux_concurrency(t *testing.T) { go func() { <-start grpcHealthErrors <- func() error { - cc, err := grpc.Dial(addr, grpc.WithInsecure()) + cc, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) if err != nil { return err } diff --git a/internal/middleware/cache/cache_test.go b/internal/middleware/cache/cache_test.go index 81a8aeb4d..8156d4b8f 100644 --- a/internal/middleware/cache/cache_test.go +++ b/internal/middleware/cache/cache_test.go @@ -16,6 +16,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/health" "google.golang.org/grpc/health/grpc_health_v1" "google.golang.org/grpc/status" @@ -195,7 +196,7 @@ func newTestSvc(t testing.TB, ctx context.Context, srvr *grpc.Server, svc testda ctx, lis.Addr().String(), grpc.WithBlock(), - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) require.NoError(t, err) diff --git a/internal/middleware/commandstatshandler/commandstatshandler_test.go b/internal/middleware/commandstatshandler/commandstatshandler_test.go index 74cb71b53..12d507bb0 100644 --- a/internal/middleware/commandstatshandler/commandstatshandler_test.go +++ b/internal/middleware/commandstatshandler/commandstatshandler_test.go @@ -23,6 +23,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/test/bufconn" ) @@ -138,7 +139,7 @@ func TestInterceptor(t *testing.T) { t.Run(tt.name, func(t *testing.T) { hook.Reset() - conn, err := grpc.DialContext(ctx, "", grpc.WithContextDialer(getBufDialer(listener)), grpc.WithInsecure()) + conn, err := grpc.DialContext(ctx, "", grpc.WithContextDialer(getBufDialer(listener)), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer conn.Close() diff --git a/internal/middleware/limithandler/middleware_test.go b/internal/middleware/limithandler/middleware_test.go index 52738cc50..9e5d1c892 100644 --- a/internal/middleware/limithandler/middleware_test.go +++ b/internal/middleware/limithandler/middleware_test.go @@ -21,6 +21,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/status" "google.golang.org/protobuf/types/known/durationpb" ) @@ -582,7 +583,7 @@ func runServer(t *testing.T, s pb.TestServer, opt ...grpc.ServerOption) (*grpc.S func newClient(t *testing.T, serverSocketPath string) (pb.TestClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), } conn, err := grpc.Dial(serverSocketPath, connOpts...) if err != nil { diff --git a/internal/praefect/auth_test.go b/internal/praefect/auth_test.go index 144620b9a..0c398fac1 100644 --- a/internal/praefect/auth_test.go +++ b/internal/praefect/auth_test.go @@ -21,6 +21,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" ) func TestAuthFailures(t *testing.T) { @@ -53,7 +54,7 @@ func TestAuthFailures(t *testing.T) { defer srv.Stop() defer cleanup() - connOpts := append(tc.opts, grpc.WithInsecure()) + connOpts := append(tc.opts, grpc.WithTransportCredentials(insecure.NewCredentials())) conn, err := dial(serverSocketPath, connOpts) require.NoError(t, err, tc.desc) defer conn.Close() @@ -102,7 +103,7 @@ func TestAuthSuccess(t *testing.T) { defer srv.Stop() defer cleanup() - connOpts := append(tc.opts, grpc.WithInsecure()) + connOpts := append(tc.opts, grpc.WithTransportCredentials(insecure.NewCredentials())) conn, err := dial(serverSocketPath, connOpts) require.NoError(t, err, tc.desc) defer conn.Close() diff --git a/internal/praefect/delete_object_pool_test.go b/internal/praefect/delete_object_pool_test.go index 06bb55b7b..0295a6877 100644 --- a/internal/praefect/delete_object_pool_test.go +++ b/internal/praefect/delete_object_pool_test.go @@ -15,6 +15,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testdb" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) type mockObjectPoolService struct { @@ -61,11 +62,11 @@ func TestDeleteObjectPoolHandler(t *testing.T) { rs.CreateRepository(ctx, 1, repo.StorageName, repo.RelativePath, "replica-path", "primary", []string{"secondary", "unconfigured_storage"}, nil, true, true), ) - primaryConn, err := grpc.Dial(primaryAddr, grpc.WithInsecure()) + primaryConn, err := grpc.Dial(primaryAddr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer primaryConn.Close() - secondaryConn, err := grpc.Dial(secondaryAddr, grpc.WithInsecure()) + secondaryConn, err := grpc.Dial(secondaryAddr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer secondaryConn.Close() @@ -95,7 +96,7 @@ func TestDeleteObjectPoolHandler(t *testing.T) { defer praefectSrv.Stop() go praefectSrv.Serve(praefectLn) - praefectConn, err := grpc.Dial(praefectAddr, grpc.WithInsecure()) + praefectConn, err := grpc.Dial(praefectAddr, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer praefectConn.Close() diff --git a/internal/praefect/grpc-proxy/proxy/handler_ext_test.go b/internal/praefect/grpc-proxy/proxy/handler_ext_test.go index 5333ca0ea..09b74c47a 100644 --- a/internal/praefect/grpc-proxy/proxy/handler_ext_test.go +++ b/internal/praefect/grpc-proxy/proxy/handler_ext_test.go @@ -30,6 +30,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" grpc_metadata "google.golang.org/grpc/metadata" "google.golang.org/grpc/status" ) @@ -221,7 +222,7 @@ func (s *ProxyHappySuite) SetupSuite() { require.NoError(s.T(), err, "must be able to allocate a port for listenerServer") // Setup of the proxy's Director. - s.connProxy2Server, err = grpc.Dial(listenerServer.Addr().String(), grpc.WithInsecure(), grpc.WithDefaultCallOptions(grpc.ForceCodec(proxy.NewCodec()))) + s.connProxy2Server, err = grpc.Dial(listenerServer.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithDefaultCallOptions(grpc.ForceCodec(proxy.NewCodec()))) require.NoError(s.T(), err, "must not error on deferred client Dial") director := func(ctx context.Context, fullName string, peeker proxy.StreamPeeker) (*proxy.StreamParameters, error) { payload, err := peeker.Peek() @@ -269,7 +270,7 @@ func (s *ProxyHappySuite) SetupSuite() { // Setup client for test suite ctx := testhelper.Context(s.T()) - s.connClient2Proxy, err = grpc.DialContext(ctx, listenerProxy.Addr().String(), grpc.WithInsecure()) + s.connClient2Proxy, err = grpc.DialContext(ctx, listenerProxy.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(s.T(), err, "must not error on deferred client Dial") s.client = pb.NewTestServiceClient(s.connClient2Proxy) } @@ -381,7 +382,7 @@ func TestProxyErrorPropagation(t *testing.T) { ctx := testhelper.Context(t) backendClientConn, err := grpc.DialContext(ctx, "unix://"+backendListener.Addr().String(), - grpc.WithInsecure(), grpc.WithDefaultCallOptions(grpc.ForceCodec(proxy.NewCodec()))) + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithDefaultCallOptions(grpc.ForceCodec(proxy.NewCodec()))) require.NoError(t, err) defer func() { require.NoError(t, backendClientConn.Close()) @@ -409,7 +410,7 @@ func TestProxyErrorPropagation(t *testing.T) { go func() { proxyServer.Serve(proxyListener) }() defer proxyServer.Stop() - proxyClientConn, err := grpc.DialContext(ctx, "unix://"+proxyListener.Addr().String(), grpc.WithInsecure()) + proxyClientConn, err := grpc.DialContext(ctx, "unix://"+proxyListener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer func() { require.NoError(t, proxyClientConn.Close()) diff --git a/internal/praefect/grpc-proxy/proxy/helper_test.go b/internal/praefect/grpc-proxy/proxy/helper_test.go index 3378a6bb6..01d83c043 100644 --- a/internal/praefect/grpc-proxy/proxy/helper_test.go +++ b/internal/praefect/grpc-proxy/proxy/helper_test.go @@ -9,6 +9,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/proxy" testservice "gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/testdata" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func newListener(tb testing.TB) net.Listener { @@ -35,7 +36,7 @@ func newBackendPinger(tb testing.TB, ctx context.Context) (*grpc.ClientConn, *in cc, err := grpc.DialContext( ctx, listener.Addr().String(), - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock(), grpc.WithDefaultCallOptions( grpc.ForceCodec(proxy.NewCodec()), @@ -71,7 +72,7 @@ func newProxy(tb testing.TB, ctx context.Context, director proxy.StreamDirector, proxyCC, err := grpc.DialContext( ctx, listener.Addr().String(), - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock(), ) require.NoError(tb, err) diff --git a/internal/praefect/middleware/errorhandler_test.go b/internal/praefect/middleware/errorhandler_test.go index 81a24cc3f..cdc4079e1 100644 --- a/internal/praefect/middleware/errorhandler_test.go +++ b/internal/praefect/middleware/errorhandler_test.go @@ -16,6 +16,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper" "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/protobuf/types/known/emptypb" ) @@ -72,7 +73,7 @@ func TestStreamInterceptor(t *testing.T) { ) (*proxy.StreamParameters, error) { cc, err := grpc.Dial("unix://"+internalServerSocketPath, grpc.WithDefaultCallOptions(grpc.ForceCodec(proxy.NewCodec())), - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithStreamInterceptor(StreamErrorHandler(registry, errTracker, nodeName)), ) require.NoError(t, err) @@ -91,7 +92,7 @@ func TestStreamInterceptor(t *testing.T) { defer praefectSrv.Stop() go praefectSrv.Serve(praefectLis) - praefectCC, err := grpc.Dial("unix://"+praefectSocket, grpc.WithInsecure()) + praefectCC, err := grpc.Dial("unix://"+praefectSocket, grpc.WithTransportCredentials(insecure.NewCredentials())) defer testhelper.MustClose(t, praefectCC) require.NoError(t, err) diff --git a/internal/praefect/nodes/local_elector_test.go b/internal/praefect/nodes/local_elector_test.go index 7899f1ded..6063ee15b 100644 --- a/internal/praefect/nodes/local_elector_test.go +++ b/internal/praefect/nodes/local_elector_test.go @@ -10,6 +10,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper" "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/promtest" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) func setupElector(t *testing.T) (*localElector, []*nodeStatus, *grpc.ClientConn) { @@ -18,7 +19,7 @@ func setupElector(t *testing.T) (*localElector, []*nodeStatus, *grpc.ClientConn) cc, err := grpc.Dial( "unix://"+socket, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) t.Cleanup(func() { testhelper.MustClose(t, cc) }) diff --git a/internal/praefect/nodes/manager_test.go b/internal/praefect/nodes/manager_test.go index dc223a72c..5c0303a27 100644 --- a/internal/praefect/nodes/manager_test.go +++ b/internal/praefect/nodes/manager_test.go @@ -16,6 +16,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper" "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/promtest" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/health" "google.golang.org/grpc/health/grpc_health_v1" ) @@ -61,7 +62,7 @@ func TestNodeStatus(t *testing.T) { cc, err := grpc.Dial( "unix://"+socket, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) defer testhelper.MustClose(t, cc) diff --git a/internal/praefect/nodes/sql_elector_test.go b/internal/praefect/nodes/sql_elector_test.go index d944040ae..a4f3c277c 100644 --- a/internal/praefect/nodes/sql_elector_test.go +++ b/internal/praefect/nodes/sql_elector_test.go @@ -46,7 +46,7 @@ func TestGetPrimaryAndSecondaries(t *testing.T) { cc0, err := grpc.Dial( "unix://"+internalSocket0, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) defer testhelper.MustClose(t, cc0) require.NoError(t, err) @@ -83,7 +83,7 @@ func TestSqlElector_slow_execution(t *testing.T) { gitalyConn, err := grpc.Dial( "unix://"+gitalySocket, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) defer testhelper.MustClose(t, gitalyConn) require.NoError(t, err) @@ -125,7 +125,7 @@ func TestBasicFailover(t *testing.T) { addr0 := "unix://" + internalSocket0 cc0, err := grpc.Dial( addr0, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) defer testhelper.MustClose(t, cc0) require.NoError(t, err) @@ -133,7 +133,7 @@ func TestBasicFailover(t *testing.T) { addr1 := "unix://" + internalSocket1 cc1, err := grpc.Dial( addr1, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), ) defer testhelper.MustClose(t, cc1) diff --git a/internal/praefect/remove_repository_test.go b/internal/praefect/remove_repository_test.go index 77ca6d76f..1ab05d5c4 100644 --- a/internal/praefect/remove_repository_test.go +++ b/internal/praefect/remove_repository_test.go @@ -21,6 +21,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/status" ) @@ -122,7 +123,7 @@ func TestRemoveRepositoryHandler(t *testing.T) { go func() { srv.Serve(ln) }() - clientConn, err := grpc.DialContext(ctx, "unix:"+ln.Addr().String(), grpc.WithInsecure()) + clientConn, err := grpc.DialContext(ctx, "unix:"+ln.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer clientConn.Close() diff --git a/internal/praefect/replicator_pg_test.go b/internal/praefect/replicator_pg_test.go index 17bb3c485..65ca60866 100644 --- a/internal/praefect/replicator_pg_test.go +++ b/internal/praefect/replicator_pg_test.go @@ -14,6 +14,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testdb" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" ) type mockRepositoryService struct { @@ -101,7 +102,7 @@ func TestReplicatorDestroy(t *testing.T) { go srv.Serve(ln) defer srv.Stop() - clientConn, err := grpc.Dial(ln.Addr().String(), grpc.WithInsecure()) + clientConn, err := grpc.Dial(ln.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer clientConn.Close() diff --git a/internal/praefect/replicator_test.go b/internal/praefect/replicator_test.go index bc9766157..79c6fb559 100644 --- a/internal/praefect/replicator_test.go +++ b/internal/praefect/replicator_test.go @@ -39,6 +39,7 @@ import ( "gitlab.com/gitlab-org/labkit/correlation" "golang.org/x/sync/errgroup" "google.golang.org/grpc" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/metadata" "google.golang.org/protobuf/proto" ) @@ -285,7 +286,7 @@ func TestConfirmReplication(t *testing.T) { testRepoB, _ := gittest.CloneRepo(t, cfg, cfg.Storages[0]) connOpts := []grpc.DialOption{ - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(cfg.Auth.Token)), } conn, err := grpc.Dial(srvSocketPath, connOpts...) @@ -760,7 +761,7 @@ func newRepositoryClient(t *testing.T, serverSocketPath, token string) gitalypb. conn, err := grpc.Dial( serverSocketPath, - grpc.WithInsecure(), + grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(token)), ) require.NoError(t, err) diff --git a/internal/praefect/repository_exists_test.go b/internal/praefect/repository_exists_test.go index b35fc8a88..38c3822ab 100644 --- a/internal/praefect/repository_exists_test.go +++ b/internal/praefect/repository_exists_test.go @@ -16,6 +16,7 @@ import ( "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" "google.golang.org/grpc" "google.golang.org/grpc/codes" + "google.golang.org/grpc/credentials/insecure" "google.golang.org/grpc/status" ) @@ -101,7 +102,7 @@ func TestRepositoryExistsHandler(t *testing.T) { go func() { srv.Serve(ln) }() - clientConn, err := grpc.DialContext(ctx, "unix://"+ln.Addr().String(), grpc.WithInsecure()) + clientConn, err := grpc.DialContext(ctx, "unix://"+ln.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) defer testhelper.MustClose(t, clientConn) diff --git a/internal/praefect/server_test.go b/internal/praefect/server_test.go index e8d9217b1..903b65e28 100644 --- a/internal/praefect/server_test.go +++ b/internal/praefect/server_test.go @@ -1003,7 +1003,7 @@ func TestErrorThreshold(t *testing.T) { go server.Serve(listener) defer server.Stop() - conn, err := dial("unix://"+socket, []grpc.DialOption{grpc.WithInsecure()}) + conn, err := dial("unix://"+socket, []grpc.DialOption{grpc.WithTransportCredentials(insecure.NewCredentials())}) require.NoError(t, err) defer testhelper.MustClose(t, conn) cli := mock.NewSimpleServiceClient(conn) @@ -1047,7 +1047,7 @@ func TestErrorThreshold(t *testing.T) { func newSmartHTTPClient(t *testing.T, serverSocketPath string) (gitalypb.SmartHTTPServiceClient, *grpc.ClientConn) { t.Helper() - conn, err := grpc.Dial(serverSocketPath, grpc.WithInsecure()) + conn, err := grpc.Dial(serverSocketPath, grpc.WithTransportCredentials(insecure.NewCredentials())) require.NoError(t, err) t.Cleanup(func() { testhelper.MustClose(t, conn) }) |