repository: Fix leaking command in `cloneFromURLCommand()` tests

The test to verify that `cloneFromURLCommand()` behaves as expected is
spawning a git-clone(1) command, but doesn't make sure that this command
terminates as expected. This has resulted in failed pipelines due to the
process leak checker detecting this escaped process.

Fix this flake by killing the process by cancelling the context and then
waiting for the process to return.

1 files changed, 9 insertions, 1 deletions

diff --git a/internal/gitaly/service/repository/create_repository_from_url_test.go b/internal/gitaly/service/repository/create_repository_from_url_test.go
index 0b6f52cea..6449a75c3 100644
--- a/internal/gitaly/service/repository/create_repository_from_url_test.go
+++ b/internal/gitaly/service/repository/create_repository_from_url_test.go
@@ -186,7 +186,6 @@ func TestCreateRepositoryFromURL_redirect(t *testing.T) {
 
 func TestServer_CloneFromURLCommand(t *testing.T) {
 	t.Parallel()
-	ctx := testhelper.Context(t)
 
 	cfg := testcfg.Build(t)
 	s := server{cfg: cfg, gitCmdFactory: gittest.NewCommandFactory(t, cfg)}
@@ -218,6 +217,8 @@ func TestServer_CloneFromURLCommand(t *testing.T) {
 		},
 	} {
 		t.Run(tc.desc, func(t *testing.T) {
+			ctx, cancel := context.WithCancel(testhelper.Context(t))
+
 			cmd, err := s.cloneFromURLCommand(
 				ctx,
 				tc.url,
@@ -229,6 +230,13 @@ func TestServer_CloneFromURLCommand(t *testing.T) {
 			)
 			require.NoError(t, err)
 
+			// Kill the command so that it won't leak outside of the current test
+			// context. We know that it will return an error, but we cannot quite tell
+			// what kind of error it will be because it might fail either be to the kill
+			// signal or because it failed to clone the repository.
+			cancel()
+			require.Error(t, cmd.Wait())
+
 			args := cmd.Args()
 			require.Contains(t, args, "--bare")
 			require.Contains(t, args, "https://192.0.2.1/secretrepo.git")