Do not mutate the original options slice

1 files changed, 8 insertions, 0 deletions

diff --git a/internal/gitaly/client/dial.go b/internal/gitaly/client/dial.go
index 4b76b3756..84800995d 100644
--- a/internal/gitaly/client/dial.go
+++ b/internal/gitaly/client/dial.go
@@ -57,6 +57,8 @@ type Handshaker interface {
 // If handshaker is provided, it's passed the transport credentials which would be otherwise set. The transport credentials
 // returned by handshaker are then set instead.
 func Dial(ctx context.Context, rawAddress string, connOpts []grpc.DialOption, handshaker Handshaker) (*grpc.ClientConn, error) {
+	connOpts = cloneOpts(connOpts) // copy to avoid potentially mutating the backing array of the passed slice
+
 	var canonicalAddress string
 	var err error
 	var transportCredentials credentials.TransportCredentials
@@ -149,3 +151,9 @@ func UnaryInterceptor() grpc.DialOption {
 		grpccorrelation.UnaryClientCorrelationInterceptor(),
 	)
 }
+
+func cloneOpts(opts []grpc.DialOption) []grpc.DialOption {
+	clone := make([]grpc.DialOption, len(opts))
+	copy(clone, opts)
+	return clone
+}