diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-05-09 13:42:16 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-05-09 16:09:54 +0300 |
commit | a5668263ba60ec8a7bec5e334295b4286f977bd5 (patch) | |
tree | 1539e3c365522d33bf4dcc370a0cd0dfb4beb5f2 | |
parent | 65a7e40ee58b808a55e98744a3671e70e537c116 (diff) |
protolint: Enforce new style for enumerations
Our enumerations do not currently have any strict design guidelines.
This brings two issues with it:
1. Enumeration values are scoped per-service. Consequentially, if
two enumerations want to declare a value with the same name, the
declarations will clash.
2. It is not possible to discern the case where a caller hasn't set
the value of an enumeration at all versus the case where the
field was explicitly set to its zero-value.
The official Protobuf style guide thus says that enum values should
always be prefixed with the name of the enum itself, and that the zero
value should be called `UNSPECIFIED`. Let's enforce this style via
protolint so that any new enumerations will follow this recommendation.
-rw-r--r-- | proto/.protolint.yaml | 5 | ||||
-rw-r--r-- | proto/commit.proto | 38 | ||||
-rw-r--r-- | proto/diff.proto | 14 | ||||
-rw-r--r-- | proto/go/gitalypb/commit.pb.go | 38 | ||||
-rw-r--r-- | proto/go/gitalypb/diff.pb.go | 14 | ||||
-rw-r--r-- | proto/go/gitalypb/hook.pb.go | 6 | ||||
-rw-r--r-- | proto/go/gitalypb/lint.pb.go | 12 | ||||
-rw-r--r-- | proto/go/gitalypb/operations.pb.go | 24 | ||||
-rw-r--r-- | proto/go/gitalypb/ref.pb.go | 26 | ||||
-rw-r--r-- | proto/go/gitalypb/repository.pb.go | 24 | ||||
-rw-r--r-- | proto/go/gitalypb/shared.pb.go | 22 | ||||
-rw-r--r-- | proto/go/gitalypb/transaction.pb.go | 12 | ||||
-rw-r--r-- | proto/go/gitalypb/wiki.pb.go | 8 | ||||
-rw-r--r-- | proto/hook.proto | 6 | ||||
-rw-r--r-- | proto/lint.proto | 12 | ||||
-rw-r--r-- | proto/operations.proto | 24 | ||||
-rw-r--r-- | proto/ref.proto | 26 | ||||
-rw-r--r-- | proto/repository.proto | 24 | ||||
-rw-r--r-- | proto/shared.proto | 22 | ||||
-rw-r--r-- | proto/transaction.proto | 12 | ||||
-rw-r--r-- | proto/wiki.proto | 8 |
21 files changed, 186 insertions, 191 deletions
diff --git a/proto/.protolint.yaml b/proto/.protolint.yaml index a2d94785d..a578b1131 100644 --- a/proto/.protolint.yaml +++ b/proto/.protolint.yaml @@ -3,11 +3,6 @@ lint: rules: all_default: true remove: - # Our use of enums isn't conforming to best practices, and it's hard to - # change retroactively. We may eventually enable these linters and then - # create exceptions for preexisting definitions. - - ENUM_FIELD_NAMES_PREFIX - - ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH # We don't specify any line length limits. - MAX_LINE_LENGTH # Many of our definitions aren't commented at all. We want to eventually diff --git a/proto/commit.proto b/proto/commit.proto index cbc14fa6c..dad17d5f8 100644 --- a/proto/commit.proto +++ b/proto/commit.proto @@ -186,15 +186,15 @@ message ListCommitsRequest { // Order is the order in which commits shoud be traversed. enum Order { // NONE defaults to reverse chronological order. - NONE = 0; + NONE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // TOPO order will cause no parents to be shown before all of its children // are shown. Furthermore, multiple lines of history will not be // intermixed. - TOPO = 1; + TOPO = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // DATE order will cause no parents to be shown before all of its children // are shown. Otherwise, commits are shown in commit timestamp order. This // can cause history to be shown intermixed. - DATE = 2; + DATE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX }; // Repository is the repository in which commits should be searched for. @@ -321,13 +321,13 @@ message TreeEntryResponse { // TODO: Replace this enum with ObjectType in shared.proto enum ObjectType { // This comment is left unintentionally blank. - COMMIT = 0; + COMMIT = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - BLOB = 1; + BLOB = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TREE = 2; + TREE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TAG = 3; + TAG = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -398,11 +398,11 @@ message TreeEntry { // TODO: Replace this enum with ObjectType in shared.proto enum EntryType { // This comment is left unintentionally blank. - BLOB = 0; + BLOB = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - TREE = 1; + TREE = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - COMMIT = 3; + COMMIT = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // OID of the object this tree entry points to @@ -425,10 +425,10 @@ message TreeEntry { message GetTreeEntriesRequest { // This comment is left unintentionally blank. enum SortBy { - // This comment is left unintentionally blank. - DEFAULT = 0; // Preserve order of git ls-tree - // This comment is left unintentionally blank. - TREES_FIRST = 1; // trees, blobs, submodules + // Preserve order of git ls-tree. + DEFAULT = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH + // Trees, blobs, submodules. + TREES_FIRST = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -527,11 +527,11 @@ message FindAllCommitsRequest { // This comment is left unintentionally blank. enum Order { // This comment is left unintentionally blank. - NONE = 0; + NONE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - TOPO = 1; + TOPO = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - DATE = 2; + DATE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -557,9 +557,9 @@ message FindCommitsRequest { // This comment is left unintentionally blank. enum Order { // This comment is left unintentionally blank. - NONE = 0; + NONE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - TOPO = 1; + TOPO = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. diff --git a/proto/diff.proto b/proto/diff.proto index d8e5b31c1..5f1615a45 100644 --- a/proto/diff.proto +++ b/proto/diff.proto @@ -60,9 +60,9 @@ message CommitDiffRequest { // This comment is left unintentionally blank. enum DiffMode { // DEFAULT is the standard diff mode and results in a linewise diff for textfiles. - DEFAULT = 0; + DEFAULT = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // WORDDIFF is a word diff and computes the diff for whitespace separated words instead of for whole lines. - WORDDIFF = 1; + WORDDIFF = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -250,15 +250,15 @@ message ChangedPaths { // This comment is left unintentionally blank. enum Status { // This comment is left unintentionally blank. - ADDED = 0; + ADDED = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - MODIFIED = 1; + MODIFIED = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - DELETED = 2; + DELETED = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TYPE_CHANGE = 3; + TYPE_CHANGE = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - COPIED = 4; + COPIED = 4; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. diff --git a/proto/go/gitalypb/commit.pb.go b/proto/go/gitalypb/commit.pb.go index a2c9d0a20..4a7ba41b3 100644 --- a/proto/go/gitalypb/commit.pb.go +++ b/proto/go/gitalypb/commit.pb.go @@ -26,15 +26,15 @@ type ListCommitsRequest_Order int32 const ( // NONE defaults to reverse chronological order. - ListCommitsRequest_NONE ListCommitsRequest_Order = 0 + ListCommitsRequest_NONE ListCommitsRequest_Order = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // TOPO order will cause no parents to be shown before all of its children // are shown. Furthermore, multiple lines of history will not be // intermixed. - ListCommitsRequest_TOPO ListCommitsRequest_Order = 1 + ListCommitsRequest_TOPO ListCommitsRequest_Order = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // DATE order will cause no parents to be shown before all of its children // are shown. Otherwise, commits are shown in commit timestamp order. This // can cause history to be shown intermixed. - ListCommitsRequest_DATE ListCommitsRequest_Order = 2 + ListCommitsRequest_DATE ListCommitsRequest_Order = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for ListCommitsRequest_Order. @@ -83,13 +83,13 @@ type TreeEntryResponse_ObjectType int32 const ( // This comment is left unintentionally blank. - TreeEntryResponse_COMMIT TreeEntryResponse_ObjectType = 0 + TreeEntryResponse_COMMIT TreeEntryResponse_ObjectType = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - TreeEntryResponse_BLOB TreeEntryResponse_ObjectType = 1 + TreeEntryResponse_BLOB TreeEntryResponse_ObjectType = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TreeEntryResponse_TREE TreeEntryResponse_ObjectType = 2 + TreeEntryResponse_TREE TreeEntryResponse_ObjectType = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TreeEntryResponse_TAG TreeEntryResponse_ObjectType = 3 + TreeEntryResponse_TAG TreeEntryResponse_ObjectType = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for TreeEntryResponse_ObjectType. @@ -140,11 +140,11 @@ type TreeEntry_EntryType int32 const ( // This comment is left unintentionally blank. - TreeEntry_BLOB TreeEntry_EntryType = 0 + TreeEntry_BLOB TreeEntry_EntryType = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - TreeEntry_TREE TreeEntry_EntryType = 1 + TreeEntry_TREE TreeEntry_EntryType = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TreeEntry_COMMIT TreeEntry_EntryType = 3 + TreeEntry_COMMIT TreeEntry_EntryType = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for TreeEntry_EntryType. @@ -192,10 +192,10 @@ func (TreeEntry_EntryType) EnumDescriptor() ([]byte, []int) { type GetTreeEntriesRequest_SortBy int32 const ( - // This comment is left unintentionally blank. - GetTreeEntriesRequest_DEFAULT GetTreeEntriesRequest_SortBy = 0 // Preserve order of git ls-tree - // This comment is left unintentionally blank. - GetTreeEntriesRequest_TREES_FIRST GetTreeEntriesRequest_SortBy = 1 // trees, blobs, submodules + // Preserve order of git ls-tree. + GetTreeEntriesRequest_DEFAULT GetTreeEntriesRequest_SortBy = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH + // Trees, blobs, submodules. + GetTreeEntriesRequest_TREES_FIRST GetTreeEntriesRequest_SortBy = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for GetTreeEntriesRequest_SortBy. @@ -242,11 +242,11 @@ type FindAllCommitsRequest_Order int32 const ( // This comment is left unintentionally blank. - FindAllCommitsRequest_NONE FindAllCommitsRequest_Order = 0 + FindAllCommitsRequest_NONE FindAllCommitsRequest_Order = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - FindAllCommitsRequest_TOPO FindAllCommitsRequest_Order = 1 + FindAllCommitsRequest_TOPO FindAllCommitsRequest_Order = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - FindAllCommitsRequest_DATE FindAllCommitsRequest_Order = 2 + FindAllCommitsRequest_DATE FindAllCommitsRequest_Order = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for FindAllCommitsRequest_Order. @@ -295,9 +295,9 @@ type FindCommitsRequest_Order int32 const ( // This comment is left unintentionally blank. - FindCommitsRequest_NONE FindCommitsRequest_Order = 0 + FindCommitsRequest_NONE FindCommitsRequest_Order = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - FindCommitsRequest_TOPO FindCommitsRequest_Order = 1 + FindCommitsRequest_TOPO FindCommitsRequest_Order = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for FindCommitsRequest_Order. diff --git a/proto/go/gitalypb/diff.pb.go b/proto/go/gitalypb/diff.pb.go index cc2114b9c..6c8c08e8d 100644 --- a/proto/go/gitalypb/diff.pb.go +++ b/proto/go/gitalypb/diff.pb.go @@ -25,9 +25,9 @@ type CommitDiffRequest_DiffMode int32 const ( // DEFAULT is the standard diff mode and results in a linewise diff for textfiles. - CommitDiffRequest_DEFAULT CommitDiffRequest_DiffMode = 0 + CommitDiffRequest_DEFAULT CommitDiffRequest_DiffMode = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // WORDDIFF is a word diff and computes the diff for whitespace separated words instead of for whole lines. - CommitDiffRequest_WORDDIFF CommitDiffRequest_DiffMode = 1 + CommitDiffRequest_WORDDIFF CommitDiffRequest_DiffMode = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for CommitDiffRequest_DiffMode. @@ -74,15 +74,15 @@ type ChangedPaths_Status int32 const ( // This comment is left unintentionally blank. - ChangedPaths_ADDED ChangedPaths_Status = 0 + ChangedPaths_ADDED ChangedPaths_Status = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ChangedPaths_MODIFIED ChangedPaths_Status = 1 + ChangedPaths_MODIFIED ChangedPaths_Status = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ChangedPaths_DELETED ChangedPaths_Status = 2 + ChangedPaths_DELETED ChangedPaths_Status = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ChangedPaths_TYPE_CHANGE ChangedPaths_Status = 3 + ChangedPaths_TYPE_CHANGE ChangedPaths_Status = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ChangedPaths_COPIED ChangedPaths_Status = 4 + ChangedPaths_COPIED ChangedPaths_Status = 4 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for ChangedPaths_Status. diff --git a/proto/go/gitalypb/hook.pb.go b/proto/go/gitalypb/hook.pb.go index 8fd4fe4c3..a8a92c76c 100644 --- a/proto/go/gitalypb/hook.pb.go +++ b/proto/go/gitalypb/hook.pb.go @@ -25,11 +25,11 @@ type ReferenceTransactionHookRequest_State int32 const ( // This comment is left unintentionally blank. - ReferenceTransactionHookRequest_PREPARED ReferenceTransactionHookRequest_State = 0 + ReferenceTransactionHookRequest_PREPARED ReferenceTransactionHookRequest_State = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ReferenceTransactionHookRequest_COMMITTED ReferenceTransactionHookRequest_State = 1 + ReferenceTransactionHookRequest_COMMITTED ReferenceTransactionHookRequest_State = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ReferenceTransactionHookRequest_ABORTED ReferenceTransactionHookRequest_State = 2 + ReferenceTransactionHookRequest_ABORTED ReferenceTransactionHookRequest_State = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for ReferenceTransactionHookRequest_State. diff --git a/proto/go/gitalypb/lint.pb.go b/proto/go/gitalypb/lint.pb.go index 08d2ad0ae..a2f4e9e72 100644 --- a/proto/go/gitalypb/lint.pb.go +++ b/proto/go/gitalypb/lint.pb.go @@ -26,13 +26,13 @@ type OperationMsg_Operation int32 const ( // This comment is left unintentionally blank. - OperationMsg_UNKNOWN OperationMsg_Operation = 0 + OperationMsg_UNKNOWN OperationMsg_Operation = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - OperationMsg_MUTATOR OperationMsg_Operation = 1 + OperationMsg_MUTATOR OperationMsg_Operation = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - OperationMsg_ACCESSOR OperationMsg_Operation = 2 + OperationMsg_ACCESSOR OperationMsg_Operation = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - OperationMsg_MAINTENANCE OperationMsg_Operation = 3 + OperationMsg_MAINTENANCE OperationMsg_Operation = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for OperationMsg_Operation. @@ -83,9 +83,9 @@ type OperationMsg_Scope int32 const ( // This comment is left unintentionally blank. - OperationMsg_REPOSITORY OperationMsg_Scope = 0 + OperationMsg_REPOSITORY OperationMsg_Scope = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - OperationMsg_STORAGE OperationMsg_Scope = 2 + OperationMsg_STORAGE OperationMsg_Scope = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for OperationMsg_Scope. diff --git a/proto/go/gitalypb/operations.pb.go b/proto/go/gitalypb/operations.pb.go index 5131a8573..12b0ef550 100644 --- a/proto/go/gitalypb/operations.pb.go +++ b/proto/go/gitalypb/operations.pb.go @@ -27,12 +27,12 @@ type UserCherryPickResponse_CreateTreeError int32 const ( // NONE denotes that no error occurred. - UserCherryPickResponse_NONE UserCherryPickResponse_CreateTreeError = 0 + UserCherryPickResponse_NONE UserCherryPickResponse_CreateTreeError = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // EMPTY denotes that the cherry-pick would've resulted in an empty commit, // typically because it has already been applied to the target branch. - UserCherryPickResponse_EMPTY UserCherryPickResponse_CreateTreeError = 1 + UserCherryPickResponse_EMPTY UserCherryPickResponse_CreateTreeError = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // CONFLICT denotes that the cherry-pick resulted in a conflict. - UserCherryPickResponse_CONFLICT UserCherryPickResponse_CreateTreeError = 2 + UserCherryPickResponse_CONFLICT UserCherryPickResponse_CreateTreeError = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for UserCherryPickResponse_CreateTreeError. @@ -82,12 +82,12 @@ type UserRevertResponse_CreateTreeError int32 const ( // NONE denotes that no error occurred. - UserRevertResponse_NONE UserRevertResponse_CreateTreeError = 0 + UserRevertResponse_NONE UserRevertResponse_CreateTreeError = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // EMPTY denotes that the revert would've resulted in an empty commit, // typically because it has already been applied to the target branch. - UserRevertResponse_EMPTY UserRevertResponse_CreateTreeError = 1 + UserRevertResponse_EMPTY UserRevertResponse_CreateTreeError = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // CONFLICT denotes that the revert resulted in a conflict. - UserRevertResponse_CONFLICT UserRevertResponse_CreateTreeError = 2 + UserRevertResponse_CONFLICT UserRevertResponse_CreateTreeError = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for UserRevertResponse_CreateTreeError. @@ -136,17 +136,17 @@ type UserCommitFilesActionHeader_ActionType int32 const ( // CREATE creates a new file. - UserCommitFilesActionHeader_CREATE UserCommitFilesActionHeader_ActionType = 0 + UserCommitFilesActionHeader_CREATE UserCommitFilesActionHeader_ActionType = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // CREATE_DIR creates a new directory. - UserCommitFilesActionHeader_CREATE_DIR UserCommitFilesActionHeader_ActionType = 1 + UserCommitFilesActionHeader_CREATE_DIR UserCommitFilesActionHeader_ActionType = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // UPDATE updates an existing file. - UserCommitFilesActionHeader_UPDATE UserCommitFilesActionHeader_ActionType = 2 + UserCommitFilesActionHeader_UPDATE UserCommitFilesActionHeader_ActionType = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // MOVE moves an existing file to a new path. - UserCommitFilesActionHeader_MOVE UserCommitFilesActionHeader_ActionType = 3 + UserCommitFilesActionHeader_MOVE UserCommitFilesActionHeader_ActionType = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // DELETE deletes an existing file. - UserCommitFilesActionHeader_DELETE UserCommitFilesActionHeader_ActionType = 4 + UserCommitFilesActionHeader_DELETE UserCommitFilesActionHeader_ActionType = 4 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // CHMOD changes the permissions of an existing file. - UserCommitFilesActionHeader_CHMOD UserCommitFilesActionHeader_ActionType = 5 + UserCommitFilesActionHeader_CHMOD UserCommitFilesActionHeader_ActionType = 5 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for UserCommitFilesActionHeader_ActionType. diff --git a/proto/go/gitalypb/ref.pb.go b/proto/go/gitalypb/ref.pb.go index 536f61ff2..df88af5e2 100644 --- a/proto/go/gitalypb/ref.pb.go +++ b/proto/go/gitalypb/ref.pb.go @@ -26,11 +26,11 @@ type FindLocalBranchesRequest_SortBy int32 const ( // This comment is left unintentionally blank. - FindLocalBranchesRequest_NAME FindLocalBranchesRequest_SortBy = 0 + FindLocalBranchesRequest_NAME FindLocalBranchesRequest_SortBy = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - FindLocalBranchesRequest_UPDATED_ASC FindLocalBranchesRequest_SortBy = 1 + FindLocalBranchesRequest_UPDATED_ASC FindLocalBranchesRequest_SortBy = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - FindLocalBranchesRequest_UPDATED_DESC FindLocalBranchesRequest_SortBy = 2 + FindLocalBranchesRequest_UPDATED_DESC FindLocalBranchesRequest_SortBy = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for FindLocalBranchesRequest_SortBy. @@ -79,9 +79,9 @@ type FindAllTagsRequest_SortBy_Key int32 const ( // This comment is left unintentionally blank. - FindAllTagsRequest_SortBy_REFNAME FindAllTagsRequest_SortBy_Key = 0 + FindAllTagsRequest_SortBy_REFNAME FindAllTagsRequest_SortBy_Key = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - FindAllTagsRequest_SortBy_CREATORDATE FindAllTagsRequest_SortBy_Key = 1 + FindAllTagsRequest_SortBy_CREATORDATE FindAllTagsRequest_SortBy_Key = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for FindAllTagsRequest_SortBy_Key. @@ -128,13 +128,13 @@ type CreateBranchResponse_Status int32 const ( // This comment is left unintentionally blank. - CreateBranchResponse_OK CreateBranchResponse_Status = 0 + CreateBranchResponse_OK CreateBranchResponse_Status = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - CreateBranchResponse_ERR_EXISTS CreateBranchResponse_Status = 1 + CreateBranchResponse_ERR_EXISTS CreateBranchResponse_Status = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - CreateBranchResponse_ERR_INVALID CreateBranchResponse_Status = 2 + CreateBranchResponse_ERR_INVALID CreateBranchResponse_Status = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - CreateBranchResponse_ERR_INVALID_START_POINT CreateBranchResponse_Status = 3 + CreateBranchResponse_ERR_INVALID_START_POINT CreateBranchResponse_Status = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for CreateBranchResponse_Status. @@ -185,13 +185,13 @@ type ListRefsRequest_SortBy_Key int32 const ( // This comment is left unintentionally blank. - ListRefsRequest_SortBy_REFNAME ListRefsRequest_SortBy_Key = 0 + ListRefsRequest_SortBy_REFNAME ListRefsRequest_SortBy_Key = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ListRefsRequest_SortBy_CREATORDATE ListRefsRequest_SortBy_Key = 1 + ListRefsRequest_SortBy_CREATORDATE ListRefsRequest_SortBy_Key = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ListRefsRequest_SortBy_AUTHORDATE ListRefsRequest_SortBy_Key = 2 + ListRefsRequest_SortBy_AUTHORDATE ListRefsRequest_SortBy_Key = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ListRefsRequest_SortBy_COMMITTERDATE ListRefsRequest_SortBy_Key = 3 + ListRefsRequest_SortBy_COMMITTERDATE ListRefsRequest_SortBy_Key = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for ListRefsRequest_SortBy_Key. diff --git a/proto/go/gitalypb/repository.pb.go b/proto/go/gitalypb/repository.pb.go index 90f8a7e6f..f24ce8a3d 100644 --- a/proto/go/gitalypb/repository.pb.go +++ b/proto/go/gitalypb/repository.pb.go @@ -27,7 +27,7 @@ const ( // SizeMultiple requires to use '--split --size-multiple=4' strategy to create/update commit graph. // https://git-scm.com/docs/git-commit-graph#Documentation/git-commit-graph.txt-emwriteem // It is a default, there is no need to explicitly set it in the request. - WriteCommitGraphRequest_SizeMultiple WriteCommitGraphRequest_SplitStrategy = 0 // protolint:disable:this ENUM_FIELD_NAMES_UPPER_SNAKE_CASE + WriteCommitGraphRequest_SizeMultiple WriteCommitGraphRequest_SplitStrategy = 0 // protolint:disable:this ENUM_FIELD_NAMES_UPPER_SNAKE_CASE ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH ) // Enum value maps for WriteCommitGraphRequest_SplitStrategy. @@ -72,13 +72,13 @@ type GetArchiveRequest_Format int32 const ( // This comment is left unintentionally blank. - GetArchiveRequest_ZIP GetArchiveRequest_Format = 0 + GetArchiveRequest_ZIP GetArchiveRequest_Format = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - GetArchiveRequest_TAR GetArchiveRequest_Format = 1 + GetArchiveRequest_TAR GetArchiveRequest_Format = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetArchiveRequest_TAR_GZ GetArchiveRequest_Format = 2 + GetArchiveRequest_TAR_GZ GetArchiveRequest_Format = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetArchiveRequest_TAR_BZ2 GetArchiveRequest_Format = 3 + GetArchiveRequest_TAR_BZ2 GetArchiveRequest_Format = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for GetArchiveRequest_Format. @@ -129,19 +129,19 @@ type GetRawChangesResponse_RawChange_Operation int32 const ( // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_UNKNOWN GetRawChangesResponse_RawChange_Operation = 0 + GetRawChangesResponse_RawChange_UNKNOWN GetRawChangesResponse_RawChange_Operation = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_ADDED GetRawChangesResponse_RawChange_Operation = 1 + GetRawChangesResponse_RawChange_ADDED GetRawChangesResponse_RawChange_Operation = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_COPIED GetRawChangesResponse_RawChange_Operation = 2 + GetRawChangesResponse_RawChange_COPIED GetRawChangesResponse_RawChange_Operation = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_DELETED GetRawChangesResponse_RawChange_Operation = 3 + GetRawChangesResponse_RawChange_DELETED GetRawChangesResponse_RawChange_Operation = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_MODIFIED GetRawChangesResponse_RawChange_Operation = 4 + GetRawChangesResponse_RawChange_MODIFIED GetRawChangesResponse_RawChange_Operation = 4 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_RENAMED GetRawChangesResponse_RawChange_Operation = 5 + GetRawChangesResponse_RawChange_RENAMED GetRawChangesResponse_RawChange_Operation = 5 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - GetRawChangesResponse_RawChange_TYPE_CHANGED GetRawChangesResponse_RawChange_Operation = 6 + GetRawChangesResponse_RawChange_TYPE_CHANGED GetRawChangesResponse_RawChange_Operation = 6 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for GetRawChangesResponse_RawChange_Operation. diff --git a/proto/go/gitalypb/shared.pb.go b/proto/go/gitalypb/shared.pb.go index 31a54b636..e1aa03aac 100644 --- a/proto/go/gitalypb/shared.pb.go +++ b/proto/go/gitalypb/shared.pb.go @@ -26,15 +26,15 @@ type ObjectType int32 const ( // This comment is left unintentionally blank. - ObjectType_UNKNOWN ObjectType = 0 + ObjectType_UNKNOWN ObjectType = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ObjectType_COMMIT ObjectType = 1 + ObjectType_COMMIT ObjectType = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ObjectType_BLOB ObjectType = 2 + ObjectType_BLOB ObjectType = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ObjectType_TREE ObjectType = 3 + ObjectType_TREE ObjectType = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ObjectType_TAG ObjectType = 4 + ObjectType_TAG ObjectType = 4 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for ObjectType. @@ -87,13 +87,13 @@ type SignatureType int32 const ( // This comment is left unintentionally blank. - SignatureType_NONE SignatureType = 0 + SignatureType_NONE SignatureType = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - SignatureType_PGP SignatureType = 1 + SignatureType_PGP SignatureType = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - SignatureType_X509 SignatureType = 2 + SignatureType_X509 SignatureType = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - SignatureType_SSH SignatureType = 3 // maybe add X509+TSA or other combinations at a later step + SignatureType_SSH SignatureType = 3 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for SignatureType. @@ -144,9 +144,9 @@ type SortDirection int32 const ( // ASCENDING sorts by the sort key in ascending order. - SortDirection_ASCENDING SortDirection = 0 + SortDirection_ASCENDING SortDirection = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // DESCENDING sorts by the sort key in descending order. - SortDirection_DESCENDING SortDirection = 1 + SortDirection_DESCENDING SortDirection = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for SortDirection. diff --git a/proto/go/gitalypb/transaction.pb.go b/proto/go/gitalypb/transaction.pb.go index b98a2af3a..6824ea2d8 100644 --- a/proto/go/gitalypb/transaction.pb.go +++ b/proto/go/gitalypb/transaction.pb.go @@ -27,14 +27,14 @@ const ( // UNKNOWN_PHASE is the unknown voting phase. This value has been the // default because phases have been introduced. Eventually, using this // phase will become unsupported. - VoteTransactionRequest_UNKNOWN_PHASE VoteTransactionRequest_Phase = 0 + VoteTransactionRequest_UNKNOWN_PHASE VoteTransactionRequest_Phase = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // PREPARED_PHASE is the prepratory phase. The data that is about to change // is locked for concurrent modification, but changes have not yet been // written to disk. - VoteTransactionRequest_PREPARED_PHASE VoteTransactionRequest_Phase = 1 + VoteTransactionRequest_PREPARED_PHASE VoteTransactionRequest_Phase = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // COMMITTED_PHASE is the committing phase. Data has been committed to disk // and will be visible in all subsequent requests. - VoteTransactionRequest_COMMITTED_PHASE VoteTransactionRequest_Phase = 2 + VoteTransactionRequest_COMMITTED_PHASE VoteTransactionRequest_Phase = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for VoteTransactionRequest_Phase. @@ -84,11 +84,11 @@ type VoteTransactionResponse_TransactionState int32 const ( // This comment is left unintentionally blank. - VoteTransactionResponse_COMMIT VoteTransactionResponse_TransactionState = 0 + VoteTransactionResponse_COMMIT VoteTransactionResponse_TransactionState = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - VoteTransactionResponse_ABORT VoteTransactionResponse_TransactionState = 1 + VoteTransactionResponse_ABORT VoteTransactionResponse_TransactionState = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - VoteTransactionResponse_STOP VoteTransactionResponse_TransactionState = 2 + VoteTransactionResponse_STOP VoteTransactionResponse_TransactionState = 2 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for VoteTransactionResponse_TransactionState. diff --git a/proto/go/gitalypb/wiki.pb.go b/proto/go/gitalypb/wiki.pb.go index a57413524..d37ad38fc 100644 --- a/proto/go/gitalypb/wiki.pb.go +++ b/proto/go/gitalypb/wiki.pb.go @@ -25,9 +25,9 @@ type WikiGetAllPagesRequest_SortBy int32 const ( // This comment is left unintentionally blank. - WikiGetAllPagesRequest_TITLE WikiGetAllPagesRequest_SortBy = 0 + WikiGetAllPagesRequest_TITLE WikiGetAllPagesRequest_SortBy = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - WikiGetAllPagesRequest_CREATED_AT WikiGetAllPagesRequest_SortBy = 1 + WikiGetAllPagesRequest_CREATED_AT WikiGetAllPagesRequest_SortBy = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for WikiGetAllPagesRequest_SortBy. @@ -74,9 +74,9 @@ type WikiListPagesRequest_SortBy int32 const ( // This comment is left unintentionally blank. - WikiListPagesRequest_TITLE WikiListPagesRequest_SortBy = 0 + WikiListPagesRequest_TITLE WikiListPagesRequest_SortBy = 0 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - WikiListPagesRequest_CREATED_AT WikiListPagesRequest_SortBy = 1 + WikiListPagesRequest_CREATED_AT WikiListPagesRequest_SortBy = 1 // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ) // Enum value maps for WikiListPagesRequest_SortBy. diff --git a/proto/hook.proto b/proto/hook.proto index eda4036cf..308154e51 100644 --- a/proto/hook.proto +++ b/proto/hook.proto @@ -123,11 +123,11 @@ message ReferenceTransactionHookRequest { // This comment is left unintentionally blank. enum State { // This comment is left unintentionally blank. - PREPARED = 0; + PREPARED = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - COMMITTED = 1; + COMMITTED = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ABORTED = 2; + ABORTED = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. diff --git a/proto/lint.proto b/proto/lint.proto index 6f1d2b1b5..49595e3d4 100644 --- a/proto/lint.proto +++ b/proto/lint.proto @@ -11,21 +11,21 @@ message OperationMsg { // This comment is left unintentionally blank. enum Operation { // This comment is left unintentionally blank. - UNKNOWN = 0; + UNKNOWN = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - MUTATOR = 1; + MUTATOR = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ACCESSOR = 2; + ACCESSOR = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - MAINTENANCE = 3; + MAINTENANCE = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. enum Scope { // This comment is left unintentionally blank. - REPOSITORY = 0; + REPOSITORY = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - STORAGE = 2; + STORAGE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX reserved 1; reserved "SERVER"; diff --git a/proto/operations.proto b/proto/operations.proto index 3db97dc30..fd9d1b6e7 100644 --- a/proto/operations.proto +++ b/proto/operations.proto @@ -418,12 +418,12 @@ message UserCherryPickResponse { // cherry-pick. enum CreateTreeError { // NONE denotes that no error occurred. - NONE = 0; + NONE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // EMPTY denotes that the cherry-pick would've resulted in an empty commit, // typically because it has already been applied to the target branch. - EMPTY = 1; + EMPTY = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // CONFLICT denotes that the cherry-pick resulted in a conflict. - CONFLICT = 2; + CONFLICT = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // branch_update represents details about the updated branch. @@ -496,12 +496,12 @@ message UserRevertResponse { // revert. enum CreateTreeError { // NONE denotes that no error occurred. - NONE = 0; + NONE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // EMPTY denotes that the revert would've resulted in an empty commit, // typically because it has already been applied to the target branch. - EMPTY = 1; + EMPTY = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // CONFLICT denotes that the revert resulted in a conflict. - CONFLICT = 2; + CONFLICT = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // branch_update represents details about the updated branch. @@ -524,17 +524,17 @@ message UserCommitFilesActionHeader { // This comment is left unintentionally blank. enum ActionType { // CREATE creates a new file. - CREATE = 0; + CREATE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // CREATE_DIR creates a new directory. - CREATE_DIR = 1; + CREATE_DIR = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // UPDATE updates an existing file. - UPDATE = 2; + UPDATE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // MOVE moves an existing file to a new path. - MOVE = 3; + MOVE = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // DELETE deletes an existing file. - DELETE = 4; + DELETE = 4; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // CHMOD changes the permissions of an existing file. - CHMOD = 5; + CHMOD = 5; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // action is the type of the action taken to build a commit. Not all fields are diff --git a/proto/ref.proto b/proto/ref.proto index 502d86e7f..e97a85012 100644 --- a/proto/ref.proto +++ b/proto/ref.proto @@ -190,11 +190,11 @@ message FindLocalBranchesRequest { // This comment is left unintentionally blank. enum SortBy { // This comment is left unintentionally blank. - NAME = 0; + NAME = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - UPDATED_ASC = 1; + UPDATED_ASC = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - UPDATED_DESC = 2; + UPDATED_DESC = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -288,9 +288,9 @@ message FindAllTagsRequest { // Key is a key used for sorting. enum Key { // This comment is left unintentionally blank. - REFNAME = 0; + REFNAME = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - CREATORDATE = 1; + CREATORDATE = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -344,13 +344,13 @@ message CreateBranchResponse { // This comment is left unintentionally blank. enum Status { // This comment is left unintentionally blank. - OK = 0; + OK = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ERR_EXISTS = 1; + ERR_EXISTS = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ERR_INVALID = 2; + ERR_INVALID = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - ERR_INVALID_START_POINT = 3; + ERR_INVALID_START_POINT = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -526,13 +526,13 @@ message ListRefsRequest { // This comment is left unintentionally blank. enum Key { // This comment is left unintentionally blank. - REFNAME = 0; + REFNAME = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - CREATORDATE = 1; + CREATORDATE = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - AUTHORDATE = 2; + AUTHORDATE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - COMMITTERDATE = 3; + COMMITTERDATE = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // Key is a key used for sorting. diff --git a/proto/repository.proto b/proto/repository.proto index 9f8c51d95..edac1fe51 100644 --- a/proto/repository.proto +++ b/proto/repository.proto @@ -399,7 +399,7 @@ message WriteCommitGraphRequest { // SizeMultiple requires to use '--split --size-multiple=4' strategy to create/update commit graph. // https://git-scm.com/docs/git-commit-graph#Documentation/git-commit-graph.txt-emwriteem // It is a default, there is no need to explicitly set it in the request. - SizeMultiple = 0; // protolint:disable:this ENUM_FIELD_NAMES_UPPER_SNAKE_CASE + SizeMultiple = 0; // protolint:disable:this ENUM_FIELD_NAMES_UPPER_SNAKE_CASE ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH } // This comment is left unintentionally blank. @@ -520,13 +520,13 @@ message GetArchiveRequest { // This comment is left unintentionally blank. enum Format { // This comment is left unintentionally blank. - ZIP = 0; + ZIP = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - TAR = 1; + TAR = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TAR_GZ = 2; + TAR_GZ = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TAR_BZ2 = 3; + TAR_BZ2 = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -842,19 +842,19 @@ message GetRawChangesResponse { // This comment is left unintentionally blank. enum Operation { // This comment is left unintentionally blank. - UNKNOWN = 0; + UNKNOWN = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ADDED = 1; + ADDED = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - COPIED = 2; + COPIED = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - DELETED = 3; + DELETED = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - MODIFIED = 4; + MODIFIED = 4; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - RENAMED = 5; + RENAMED = 5; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TYPE_CHANGED = 6; + TYPE_CHANGED = 6; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. diff --git a/proto/shared.proto b/proto/shared.proto index 8f5d04d99..0c734477d 100644 --- a/proto/shared.proto +++ b/proto/shared.proto @@ -10,27 +10,27 @@ option go_package = "gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"; // This comment is left unintentionally blank. enum ObjectType { // This comment is left unintentionally blank. - UNKNOWN = 0; + UNKNOWN = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - COMMIT = 1; + COMMIT = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - BLOB = 2; + BLOB = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TREE = 3; + TREE = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - TAG = 4; + TAG = 4; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. enum SignatureType { // This comment is left unintentionally blank. - NONE = 0; + NONE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - PGP = 1; + PGP = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - X509 = 2; + X509 = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - SSH = 3; + SSH = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // maybe add X509+TSA or other combinations at a later step } @@ -203,7 +203,7 @@ message GlobalOptions { // SortDirection defines the sort direction. enum SortDirection { // ASCENDING sorts by the sort key in ascending order. - ASCENDING = 0; + ASCENDING = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // DESCENDING sorts by the sort key in descending order. - DESCENDING = 1; + DESCENDING = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } diff --git a/proto/transaction.proto b/proto/transaction.proto index ed22eea63..577ca4e5b 100644 --- a/proto/transaction.proto +++ b/proto/transaction.proto @@ -49,14 +49,14 @@ message VoteTransactionRequest { // UNKNOWN_PHASE is the unknown voting phase. This value has been the // default because phases have been introduced. Eventually, using this // phase will become unsupported. - UNKNOWN_PHASE = 0; + UNKNOWN_PHASE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // PREPARED_PHASE is the prepratory phase. The data that is about to change // is locked for concurrent modification, but changes have not yet been // written to disk. - PREPARED_PHASE = 1; + PREPARED_PHASE = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // COMMITTED_PHASE is the committing phase. Data has been committed to disk // and will be visible in all subsequent requests. - COMMITTED_PHASE = 2; + COMMITTED_PHASE = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX }; // This comment is left unintentionally blank. @@ -77,11 +77,11 @@ message VoteTransactionResponse { // transaction should be committed or rolled back. enum TransactionState { // This comment is left unintentionally blank. - COMMIT = 0; + COMMIT = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - ABORT = 1; + ABORT = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX // This comment is left unintentionally blank. - STOP = 2; + STOP = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. diff --git a/proto/wiki.proto b/proto/wiki.proto index 8c039ae75..ac096f26a 100644 --- a/proto/wiki.proto +++ b/proto/wiki.proto @@ -159,9 +159,9 @@ message WikiGetAllPagesRequest { // This comment is left unintentionally blank. enum SortBy { // This comment is left unintentionally blank. - TITLE = 0; + TITLE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - CREATED_AT = 1; + CREATED_AT = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. @@ -187,9 +187,9 @@ message WikiListPagesRequest { // This comment is left unintentionally blank. enum SortBy { // This comment is left unintentionally blank. - TITLE = 0; + TITLE = 0; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH // This comment is left unintentionally blank. - CREATED_AT = 1; + CREATED_AT = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX } // This comment is left unintentionally blank. |