diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-04 14:52:14 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-28 10:05:16 +0300 |
commit | 1d49b915c3fa9088c503f54c6edd8db65a2ba5b6 (patch) | |
tree | 11d1e474bf7ea426f552a9c09c45d72bf33a8ab6 | |
parent | 3a7ee9f8386ff772aa7a602c346b9032c9eb25a9 (diff) |
ci: Add job to exercise minimum required Git version
With the conversion of our CI jobs to use bundled Git by default we're
not testing the minimum required Git version anymore. Add a new job
which tests that we're still compatible with this version to assert that
we're not starting to use new Git features which aren't available in
this version.
-rw-r--r-- | .gitlab-ci.yml | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 020985f7d..be5db9a1a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -115,13 +115,9 @@ build: - _support/test-boot . ${TEST_BOOT_ARGS} parallel: matrix: - # These definitions are for the non-default Git versions. - #- GO_VERSION: [ "1.16", "1.17" ] - # GIT_VERSION: [ ] - # These definitions are for the default Git version where we want to - # apply our default set of Git patches. - GO_VERSION: [ "1.16", "1.17" ] TEST_BOOT_ARGS: "--bundled-git" + - GIT_VERSION: "v2.33.0" build:binaries: stage: build @@ -156,15 +152,15 @@ test: - setpriv --reuid=9999 --regid=9999 --clear-groups --no-new-privs env HOME=/dev/null make ${TARGET} SKIP_RSPEC_BUILD=YesPlease $(test "${GIT_VERSION}" = default && echo WITH_BUNDLED_GIT=YesPlease) parallel: matrix: - # These definitions are for the non-default Git versions. - #- GO_VERSION: [ "1.16", "1.17" ] - # GIT_VERSION: [ ] - # TARGET: test - # These definitions are for the default Git version where we want to - # apply our default set of Git patches. + # The following jobs all test with our default Git version, which is + # using bundled Git binaries. - GO_VERSION: [ "1.16", "1.17" ] TARGET: test - TARGET: [ test-with-proxies, test-with-praefect, race-go ] + # We also verify that things work as expected with a non-bundled Git + # version matching our minimum required Git version. + - TARGET: test + GIT_VERSION: "v2.33.0" # Execute tests with our minimum required Postgres version, as well. If # the minimum version changes, please change this to the new minimum # version. Furthermore, please make sure to update the minimum required |