diff options
author | Andrew Newdigate <andrew@gitlab.com> | 2017-03-28 17:00:28 +0300 |
---|---|---|
committer | Andrew Newdigate <andrew@gitlab.com> | 2017-03-28 17:00:28 +0300 |
commit | c7a881b308f45840a0b63c156a190b0aa54a72ff (patch) | |
tree | 9ac210d12e7c5554d79b880aff905c1eef0757ce | |
parent | 302e5674311a0458d1bee05ed264ea08bbb0e193 (diff) | |
parent | 10f195a17ec777b4105c7fc1bc0770a5a2fab643 (diff) |
Merge branch 'p95-to-p99' into 'master'
Switch from p95 to p99
See merge request !109
-rw-r--r-- | README.md | 13 |
1 files changed, 8 insertions, 5 deletions
@@ -154,7 +154,7 @@ Based on the [daily overview dashboard](http://performance.gitlab.net/dashboard Using [data based on the](#generating-prioritization-data) [daily overview dashboard](http://performance.gitlab.net/dashboard/db/daily-overview?panelId=14&fullscreen), we've prioritised the order in which we'll work through the `gitlab-rails` controllers -in descending order of **95% Cumulative Time** (that is `(number of calls) * (95% call time)`). +in descending order of **99% Cumulative Time** (that is `(number of calls) * (99% call time)`). A [Google Spreadsheet](https://docs.google.com/spreadsheets/d/1MVjsbLIjBVryMxO0UhBWebrwXuqpbCz18ZtrThcSFFU/edit) is available with these calculations. @@ -187,21 +187,24 @@ with these calculations. ### Generating the Priorization Data -Use this script to generate a CSV of the 95 percentile accumulated for a 7 day period. +Use this script to generate a CSV of the 99th percentile accumulated for a 7 day period. This data will change over time, so it's important to reprioritize from time-to-time. ```shell +(echo 'Controller,Amount,Mean,p99,p99Accum'; \ influx \ -host performance.gitlab.net \ -username gitlab \ -password $GITLAB_INFLUXDB_PASSWORD \ -database gitlab \ - -execute "SELECT sum(count) as Amount, mean(duration_mean) AS Mean, mean(duration_95th) AS p95, sum(count) * mean(duration_95th) as Accum FROM downsampled.rails_git_timings_per_action_per_day WHERE time > now() - 7d GROUP BY action" \ + -execute "SELECT sum(count) as Amount, mean(duration_mean) AS Mean, mean(duration_99th) AS p99, sum(count) * mean(duration_99th) as Accum FROM downsampled.rails_git_timings_per_action_per_day WHERE time > now() - 7d GROUP BY action" \ -format csv | \ grep -v 'name,tags,'| \ - cut -d, -f2,3,4,5,6,7| \ - sed 's/action=//' > data.csv + cut -d, -f2,4,5,6,7| \ + sed 's/action=//' | \ + sort --general-numeric-sort --key=5 --field-separator=, --reverse \ +) > data.csv ``` ## Plan |