diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-12-17 14:12:32 +0300 |
|---|---|---|
| committer | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-12-17 14:12:32 +0300 |
| commit | cc278df0d6fe57561a31774c87f6c0e411959fa4 (patch) | |
| tree | ddf5d6c4adc9d8d469d2e3edd193f8a53fa63458 | |
| parent | f0019cdaae96ee4fd8ee551cdc576c1424116e5b (diff) | |
| parent | 2f7110b80cfb3d889d2d330fcb65b866a57f1fb3 (diff) | |
Merge branch 'jv-document-unused-field' into 'master'
GetAllLFSPointers: document unused field
See merge request gitlab-org/gitaly!1704
| -rw-r--r-- | proto/blob.proto | 2 | ||||
| -rw-r--r-- | proto/go/gitalypb/blob.pb.go | 12 |
2 files changed, 9 insertions, 5 deletions
diff --git a/proto/blob.proto b/proto/blob.proto index 83edd83bc..0696ae541 100644 --- a/proto/blob.proto +++ b/proto/blob.proto @@ -126,6 +126,8 @@ message GetNewLFSPointersResponse { message GetAllLFSPointersRequest { Repository repository = 1; + // This revision field is ignored by the implementation; it should be + // removed! https://gitlab.com/gitlab-org/gitaly/issues/2247 bytes revision = 2; } diff --git a/proto/go/gitalypb/blob.pb.go b/proto/go/gitalypb/blob.pb.go index f585c129a..cd6252ce9 100644 --- a/proto/go/gitalypb/blob.pb.go +++ b/proto/go/gitalypb/blob.pb.go @@ -649,11 +649,13 @@ func (m *GetNewLFSPointersResponse) GetLfsPointers() []*LFSPointer { } type GetAllLFSPointersRequest struct { - Repository *Repository `protobuf:"bytes,1,opt,name=repository,proto3" json:"repository,omitempty"` - Revision []byte `protobuf:"bytes,2,opt,name=revision,proto3" json:"revision,omitempty"` - XXX_NoUnkeyedLiteral struct{} `json:"-"` - XXX_unrecognized []byte `json:"-"` - XXX_sizecache int32 `json:"-"` + Repository *Repository `protobuf:"bytes,1,opt,name=repository,proto3" json:"repository,omitempty"` + // This revision field is ignored by the implementation; it should be + // removed! https://gitlab.com/gitlab-org/gitaly/issues/2247 + Revision []byte `protobuf:"bytes,2,opt,name=revision,proto3" json:"revision,omitempty"` + XXX_NoUnkeyedLiteral struct{} `json:"-"` + XXX_unrecognized []byte `json:"-"` + XXX_sizecache int32 `json:"-"` } func (m *GetAllLFSPointersRequest) Reset() { *m = GetAllLFSPointersRequest{} } |