diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-02-20 01:40:56 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-02-20 01:49:51 +0300 |
| commit | 90e0f97dc0063cced9380c3b78cefd340ce201f0 (patch) | |
| tree | 685c4f07d709516a09b8a7e61a67b6be69ffd95f | |
| parent | 5e94dc966ac1900c11794b107a77496552591f9b (diff) | |
Remove another test that exercises gogit feature flag
As mentioned in https://gitlab.com/gitlab-org/gitaly/merge_requests/899,
we ran an experiment with go-git some time ago. The outcome was not to
use it for now.
The test asserted that we get the same results whether the feature flag
is on or off. Because the feature flag is a no-op now, this test had
become pointless.
| -rw-r--r-- | changelogs/unreleased/sh-remove-gogit-test.yml | 5 | ||||
| -rw-r--r-- | internal/service/commit/find_commit_test.go | 9 |
2 files changed, 5 insertions, 9 deletions
diff --git a/changelogs/unreleased/sh-remove-gogit-test.yml b/changelogs/unreleased/sh-remove-gogit-test.yml new file mode 100644 index 000000000..831c28239 --- /dev/null +++ b/changelogs/unreleased/sh-remove-gogit-test.yml @@ -0,0 +1,5 @@ +--- +title: Remove another test that exercises gogit feature flag +merge_request: 1086 +author: +type: other diff --git a/internal/service/commit/find_commit_test.go b/internal/service/commit/find_commit_test.go index 12d730e69..d5935beb5 100644 --- a/internal/service/commit/find_commit_test.go +++ b/internal/service/commit/find_commit_test.go @@ -9,12 +9,10 @@ import ( "github.com/golang/protobuf/ptypes/timestamp" "github.com/stretchr/testify/require" "gitlab.com/gitlab-org/gitaly-proto/go/gitalypb" - "gitlab.com/gitlab-org/gitaly/internal/featureflag" "gitlab.com/gitlab-org/gitaly/internal/git/log" "gitlab.com/gitlab-org/gitaly/internal/helper" "gitlab.com/gitlab-org/gitaly/internal/testhelper" "google.golang.org/grpc/codes" - "google.golang.org/grpc/metadata" "google.golang.org/grpc/status" ) @@ -275,10 +273,6 @@ func TestFailedFindCommitRequest(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() - gogitCtx := metadata.NewOutgoingContext( - ctx, - metadata.New(map[string]string{featureflag.HeaderKey("gogit-findcommit"): "true"}), - ) for _, testCase := range testCases { t.Run(testCase.description, func(t *testing.T) { @@ -289,9 +283,6 @@ func TestFailedFindCommitRequest(t *testing.T) { _, err := client.FindCommit(ctx, request) require.Equal(t, codes.InvalidArgument, status.Code(err), "default lookup should fail") - - _, err = client.FindCommit(gogitCtx, request) - require.Equal(t, codes.InvalidArgument, status.Code(err), "go-git lookup should fail") }) } } |