Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQuang-Minh Nguyen <qmnguyen@gitlab.com>2022-12-30 06:56:10 +0300
committerQuang-Minh Nguyen <qmnguyen@gitlab.com>2023-01-09 14:04:03 +0300
commitc3b887bd15ccc255720c838b0dc26101c05f6f0e (patch)
tree4f43964f59fd3f1061d1ddf3961d3509d08bc319
parentfaa85e577ef9dd8063e7a1096d04e68dd22da3fc (diff)
Handle unhandled connection closing in tests
-rw-r--r--client/dial_test.go16
1 files changed, 8 insertions, 8 deletions
diff --git a/client/dial_test.go b/client/dial_test.go
index 70858b6ef..bd7b8423d 100644
--- a/client/dial_test.go
+++ b/client/dial_test.go
@@ -142,7 +142,7 @@ func TestDial(t *testing.T) {
return
}
require.NoError(t, err)
- defer conn.Close()
+ defer testhelper.MustClose(t, conn)
_, err = healthpb.NewHealthClient(conn).Check(ctx, &healthpb.HealthCheckRequest{})
if tt.expectHealthFailure {
@@ -227,7 +227,7 @@ func TestDialSidechannel(t *testing.T) {
conn, err := DialSidechannel(ctx, tt.rawAddress, registry, tt.dialOpts)
require.NoError(t, err)
- defer conn.Close()
+ defer testhelper.MustClose(t, conn)
ctx, scw := registry.Register(ctx, func(conn SidechannelConn) error {
const message = "hello world"
@@ -305,7 +305,7 @@ func TestDial_Correlation(t *testing.T) {
internalclient.UnaryInterceptor(), internalclient.StreamInterceptor(),
})
require.NoError(t, err)
- defer cc.Close()
+ defer testhelper.MustClose(t, cc)
client := grpc_testing.NewTestServiceClient(cc)
@@ -340,7 +340,7 @@ func TestDial_Correlation(t *testing.T) {
internalclient.UnaryInterceptor(), internalclient.StreamInterceptor(),
})
require.NoError(t, err)
- defer cc.Close()
+ defer testhelper.MustClose(t, cc)
client := grpc_testing.NewTestServiceClient(cc)
@@ -402,7 +402,7 @@ func TestDial_Tracing(t *testing.T) {
t.Run("unary", func(t *testing.T) {
reporter := jaeger.NewInMemoryReporter()
tracer, tracerCloser := jaeger.NewTracer("", jaeger.NewConstSampler(true), reporter)
- defer tracerCloser.Close()
+ defer testhelper.MustClose(t, tracerCloser)
defer func(old opentracing.Tracer) { opentracing.SetGlobalTracer(old) }(opentracing.GlobalTracer())
opentracing.SetGlobalTracer(tracer)
@@ -413,7 +413,7 @@ func TestDial_Tracing(t *testing.T) {
internalclient.UnaryInterceptor(), internalclient.StreamInterceptor(),
})
require.NoError(t, err)
- defer cc.Close()
+ defer testhelper.MustClose(t, cc)
// We set up a "main" span here, which is going to be what the
// other spans inherit from. In order to check whether baggage
@@ -461,7 +461,7 @@ func TestDial_Tracing(t *testing.T) {
t.Run("stream", func(t *testing.T) {
reporter := jaeger.NewInMemoryReporter()
tracer, tracerCloser := jaeger.NewTracer("", jaeger.NewConstSampler(true), reporter)
- defer tracerCloser.Close()
+ defer testhelper.MustClose(t, tracerCloser)
defer func(old opentracing.Tracer) { opentracing.SetGlobalTracer(old) }(opentracing.GlobalTracer())
opentracing.SetGlobalTracer(tracer)
@@ -472,7 +472,7 @@ func TestDial_Tracing(t *testing.T) {
internalclient.UnaryInterceptor(), internalclient.StreamInterceptor(),
})
require.NoError(t, err)
- defer cc.Close()
+ defer testhelper.MustClose(t, cc)
// We set up a "main" span here, which is going to be what the other spans inherit
// from. In order to check whether baggage works correctly, we also set up a "stub"