diff options
author | Sami Hiltunen <shiltunen@gitlab.com> | 2023-08-18 17:36:30 +0300 |
---|---|---|
committer | Sami Hiltunen <shiltunen@gitlab.com> | 2023-08-28 15:26:06 +0300 |
commit | 044a9b10648d2f4737c3a03bddc0f470e7f0af3c (patch) | |
tree | 860af5adcbf665ef13e2f29072e748f58f60bbdb | |
parent | 3f95a789b84a0fac1ecd8735573bc21c0097f810 (diff) |
Disable RemoveAll tests with WAL
RemoveAll is a problematic RPC as it empties out the entire storage.
Doing so, it removes the disk state Gitaly is still operating on. This
causes issues with WAL as the transaction manager and the database don't
expect their disk state to suddenly disappear. Disable RemoveAll tests
with WAL until the RPC has been properly integrated.
-rw-r--r-- | cmd/gitaly-backup/restore_test.go | 14 | ||||
-rw-r--r-- | internal/backup/backup_test.go | 7 | ||||
-rw-r--r-- | internal/backup/server_side_test.go | 7 | ||||
-rw-r--r-- | internal/gitaly/service/repository/remove_all_test.go | 7 | ||||
-rw-r--r-- | internal/praefect/remove_all_test.go | 7 |
5 files changed, 42 insertions, 0 deletions
diff --git a/cmd/gitaly-backup/restore_test.go b/cmd/gitaly-backup/restore_test.go index 7b327f3eb..a36434b55 100644 --- a/cmd/gitaly-backup/restore_test.go +++ b/cmd/gitaly-backup/restore_test.go @@ -25,6 +25,13 @@ import ( func TestRestoreSubcommand(t *testing.T) { gittest.SkipWithSHA256(t) + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() ctx := testhelper.Context(t) @@ -101,6 +108,13 @@ func TestRestoreSubcommand(t *testing.T) { func TestRestoreSubcommand_serverSide(t *testing.T) { gittest.SkipWithSHA256(t) + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() ctx := testhelper.Context(t) diff --git a/internal/backup/backup_test.go b/internal/backup/backup_test.go index 0121f2116..eb4fa2011 100644 --- a/internal/backup/backup_test.go +++ b/internal/backup/backup_test.go @@ -29,6 +29,13 @@ import ( ) func TestManager_RemoveAllRepositories(t *testing.T) { + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() cfg := testcfg.Build(t) diff --git a/internal/backup/server_side_test.go b/internal/backup/server_side_test.go index 05f5f9b82..5d69b70b2 100644 --- a/internal/backup/server_side_test.go +++ b/internal/backup/server_side_test.go @@ -242,6 +242,13 @@ func TestServerSideAdapter_Restore(t *testing.T) { } func TestServerSideAdapter_RemoveAllRepositories(t *testing.T) { + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() backupRoot := testhelper.TempDir(t) diff --git a/internal/gitaly/service/repository/remove_all_test.go b/internal/gitaly/service/repository/remove_all_test.go index 1a861bc84..785f54b01 100644 --- a/internal/gitaly/service/repository/remove_all_test.go +++ b/internal/gitaly/service/repository/remove_all_test.go @@ -10,6 +10,13 @@ import ( ) func TestRemoveAll(t *testing.T) { + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() cfg, client := setupRepositoryService(t) diff --git a/internal/praefect/remove_all_test.go b/internal/praefect/remove_all_test.go index cfbd7beb5..5f635de0b 100644 --- a/internal/praefect/remove_all_test.go +++ b/internal/praefect/remove_all_test.go @@ -24,6 +24,13 @@ import ( ) func TestRemoveAllHandler(t *testing.T) { + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() ctx := testhelper.Context(t) |