Consume stream to finish in flaky test

TestInterceptor/streaming_repository-scoped_call is flaky due to not
consuming the gRPC stream to finish. The test server is recording the
captured tags after calling the handler. This leads to a race where
the test body may assert the tags while the server is storing them.

Fix the race by consuming the stream to finish in the test. This way
the interceptor capturing the tags runs to finish before the test
asserts the result as the test has to wait for the status to be
received first.

While at it, simplify the test handler by removing the unnecessary
response sending as it doesn't help with the synchronization.

1 files changed, 3 insertions, 10 deletions

diff --git a/internal/grpc/middleware/requestinfohandler/requestinfohandler_test.go b/internal/grpc/middleware/requestinfohandler/requestinfohandler_test.go
index 38e40faeb..a51755430 100644
--- a/internal/grpc/middleware/requestinfohandler/requestinfohandler_test.go
+++ b/internal/grpc/middleware/requestinfohandler/requestinfohandler_test.go
@@ -599,7 +599,7 @@ func TestInterceptors(t *testing.T) {
 				}))
 
 				_, err = stream.Recv()
-				require.NoError(t, err)
+				require.Equal(t, err, io.EOF)
 			},
 			expectedInfo: &RequestInfo{
 				clientName:      "unknown",
@@ -744,13 +744,6 @@ func (s *mockServer) FetchIntoObjectPool(ctx context.Context, _ *gitalypb.FetchI
 }
 
 func (s *mockServer) CreateBundleFromRefList(stream gitalypb.RepositoryService_CreateBundleFromRefListServer) error {
-	if _, err := stream.Recv(); err != nil {
-		return err
-	}
-
-	if err := stream.Send(&gitalypb.CreateBundleFromRefListResponse{}); err != nil {
-		return err
-	}
-
-	return nil
+	_, err := stream.Recv()
+	return err
 }