diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-10-11 12:17:40 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-10-11 12:22:11 +0300 |
| commit | 234423dea2ebafabb1924f36eaf841439e2fa01d (patch) | |
| tree | a93bd6f0ec453fee4e5d3112bebcab5f3247d151 | |
| parent | 3a6c3a660806fd6a7b6843aaedbc1220f0bc1887 (diff) | |
ci: Fix backwards-compatibility job with changing setup
The database backwards-compatibility job is testing whether an old
version of Praefect continues to work correctly in case it's running
with a database which has been migrated to a newer schema. To do so, we
check out the previous minor release, but restore migrations from the
current version. While this works alright in case there are only changes
to the migrations themselves (e.g. only migrations have been added), it
falls apart when the setup of migrations itself changes.
An upcoming change will remove setup of the migration package in
"migrations.go" and move it into local state. Naturally, if we run an
older version which does not yet set up that local state in the other
packages with a "migrations.go" file which doesn't set up the table name
anymore, the only result can be failure.
Fix the issue by not modifying "migrations.go" anymore.
| -rw-r--r-- | .gitlab-ci.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 228fb4e13..be6245f36 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -308,7 +308,7 @@ backwards_compatibility_test: script: - git fetch origin 'refs/tags/*:refs/tags/*' - git checkout $(_support/get-previous-minor-release) - - git checkout --no-overlay $CI_COMMIT_SHA -- internal/praefect/datastore/migrations + - git checkout --no-overlay $CI_COMMIT_SHA -- internal/praefect/datastore/migrations :!internal/praefect/datastore/migrations/migrations.go - make test-postgres lint: |