diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-11-23 10:50:41 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-11-24 09:45:13 +0300 |
| commit | 88405e3c245c3c6828c35174f123d8a333e3cd0d (patch) | |
| tree | 01c49a05d203c843ee659f29f007c76f6f211008 | |
| parent | f83638d3790eb20409a293e9641e41512f4d29ef (diff) | |
Makefile: Update `gofumpt` to v0.2.0
Update `gofumpt` to v0.2.0, which adds a new bunch of formatting rules:
- Composite literals should not have leading or trailing empty
lines.
- No empty lines following an assignment operator.
- Functions using an empty line for readability should use a `) {` line instead.
- Remove unnecessary empty lines from interfaces.
We only have a small set of code which didn't follow these new rules.
Reformat them.
| -rw-r--r-- | Makefile | 2 | ||||
| -rw-r--r-- | internal/gitlab/http_client_test.go | 1 | ||||
| -rw-r--r-- | internal/praefect/nodes/health_manager_test.go | 1 |
3 files changed, 1 insertions, 3 deletions
@@ -70,7 +70,7 @@ GO_BUILD_TAGS := tracer_static,tracer_static_jaeger,tracer_static_stackdrive # Dependency versions GOLANGCI_LINT_VERSION ?= 1.43.0 GOCOVER_COBERTURA_VERSION ?= aaee18c8195c3f2d90e5ef80ca918d265463842a -GOFUMPT_VERSION ?= 0.1.1 +GOFUMPT_VERSION ?= 0.2.0 GOIMPORTS_VERSION ?= 2538eef75904eff384a2551359968e40c207d9d2 GO_JUNIT_REPORT_VERSION ?= 984a47ca6b0a7d704c4b589852051b4d7865aa17 GO_LICENSES_VERSION ?= 73411c8fa237ccc6a75af79d0a5bc021c9487aad diff --git a/internal/gitlab/http_client_test.go b/internal/gitlab/http_client_test.go index 8ce8be5e0..12b7eaecf 100644 --- a/internal/gitlab/http_client_test.go +++ b/internal/gitlab/http_client_test.go @@ -262,7 +262,6 @@ func TestAccess_allowedResponseHandling(t *testing.T) { allowed bool errMsg string }{ - { desc: "allowed", allowedHandler: func(w http.ResponseWriter, r *http.Request) { diff --git a/internal/praefect/nodes/health_manager_test.go b/internal/praefect/nodes/health_manager_test.go index 9ca498ab9..b0a7a7a15 100644 --- a/internal/praefect/nodes/health_manager_test.go +++ b/internal/praefect/nodes/health_manager_test.go @@ -280,7 +280,6 @@ func TestHealthManager(t *testing.T) { { desc: "majority consensus healthy", healthChecks: HealthChecks{ - { PraefectName: "praefect-1", LocalStatus: LocalStatus{ |