diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2021-03-25 14:16:12 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2021-03-30 11:10:59 +0300 |
| commit | 42f1073089f7f4f6513657c607776b033d3edbc5 (patch) | |
| tree | e4e9d081fd51f77fc731e415cc7fe11111703391 | |
| parent | 2970c6087e6c19d41aaf322c70df4ffce02d8c5b (diff) | |
remove duplicate WithInsecure from a test
The client packages' Dial already sets the WithInsecure dial option
if TLS is not used. As such, it si not necessary to set the WithInsecure
option again in newRepositoryClient. Doing so will fail the tests if
transport credentials are configured as will be the case with multiplexed
connections.
| -rw-r--r-- | internal/gitaly/service/repository/testhelper_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/internal/gitaly/service/repository/testhelper_test.go b/internal/gitaly/service/repository/testhelper_test.go index 9334b1945..1803279c8 100644 --- a/internal/gitaly/service/repository/testhelper_test.go +++ b/internal/gitaly/service/repository/testhelper_test.go @@ -71,7 +71,6 @@ func testMain(m *testing.M) int { func newRepositoryClient(t *testing.T, serverSocketPath string) (gitalypb.RepositoryServiceClient, *grpc.ClientConn) { connOpts := []grpc.DialOption{ - grpc.WithInsecure(), grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(config.Config.Auth.Token)), } conn, err := client.Dial(serverSocketPath, connOpts) |