diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-07-20 09:38:08 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-07-20 09:38:08 +0300 |
| commit | 83672d777ffc7c8b2aee1ff1c2f6b5f857536b97 (patch) | |
| tree | cf9c66afa6a5a357d616eb1da7d1b080b80075a7 | |
| parent | 2c392d6c5f7c7536fb00f0dbc980e78bb8bc4a48 (diff) | |
| parent | 69743f934c1e5462b5dce44eae7b8ef3422799d2 (diff) | |
Merge branch 'pks-repository-clone-from-url-fix-test' into 'master'
repository: Fix test writing into Gitaly's repository
See merge request gitlab-org/gitaly!4718
| -rw-r--r-- | internal/gitaly/service/repository/create_repository_from_url_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/internal/gitaly/service/repository/create_repository_from_url_test.go b/internal/gitaly/service/repository/create_repository_from_url_test.go index cc2e46338..54dd7e79e 100644 --- a/internal/gitaly/service/repository/create_repository_from_url_test.go +++ b/internal/gitaly/service/repository/create_repository_from_url_test.go @@ -262,7 +262,7 @@ func TestServer_CloneFromURLCommand_withMirror(t *testing.T) { t.Parallel() ctx := testhelper.Context(t) - repositoryFullPath := "full/path/to/repository" + repositoryFullPath := filepath.Join(testhelper.TempDir(t), "full/path/to/repository") url := "https://www.example.com/secretrepo.git" cfg := testcfg.Build(t) @@ -273,6 +273,7 @@ func TestServer_CloneFromURLCommand_withMirror(t *testing.T) { args := cmd.Args() require.Contains(t, args, "--mirror") require.NotContains(t, args, "--bare") + require.Error(t, cmd.Wait()) } func gitServerWithBasicAuth(ctx context.Context, t testing.TB, gitCmdFactory git.CommandFactory, user, pass, repoPath string) (int, func() error) { |