diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2022-03-31 10:40:59 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2022-04-04 13:54:32 +0300 |
| commit | f6d989353d8180abf2559c7212883980f8fad830 (patch) | |
| tree | 3ed7df36791f1f9b41e0aef3e3643bec66fccbf8 | |
| parent | 27fe4f2f884f9cb8ba4ad931d115799259533cea (diff) | |
Don't disable Praefect in RemoveRepository tests
Praefect is currently disabled in RemoveRepository tests which allows
for Praefect's RemoveRepository behavior to deviate from the Gitaly's.
This commit enables Praefect for these tests so we can be sure we catch
behavior deviations between the two handlers.
| -rw-r--r-- | internal/gitaly/service/repository/remove_test.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/internal/gitaly/service/repository/remove_test.go b/internal/gitaly/service/repository/remove_test.go index 962b6e0b8..b6c922ecb 100644 --- a/internal/gitaly/service/repository/remove_test.go +++ b/internal/gitaly/service/repository/remove_test.go @@ -41,8 +41,7 @@ func TestRemoveRepository_doesNotExist(t *testing.T) { t.Parallel() ctx := testhelper.Context(t) - // Praefect special-cases repository removals, so we disable Praefect here. - cfg, client := setupRepositoryServiceWithoutRepo(t, testserver.WithDisablePraefect()) + cfg, client := setupRepositoryServiceWithoutRepo(t) _, err := client.RemoveRepository(ctx, &gitalypb.RemoveRepositoryRequest{ Repository: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "/does/not/exist"}, @@ -54,7 +53,7 @@ func TestRemoveRepository_locking(t *testing.T) { t.Parallel() ctx := testhelper.Context(t) - // Praefect special-cases repository removals, so we disable Praefect here. + // Praefect does not acquire a lock on repository deletion so disable the test case for Praefect. _, repo, repoPath, client := setupRepositoryService(ctx, t, testserver.WithDisablePraefect()) // Simulate a concurrent RPC holding the repository lock. |