diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-12-08 17:19:03 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-12-13 09:52:07 +0300 |
| commit | c90b1df094bb2e2371e164b0e8d9a1d6b9280646 (patch) | |
| tree | bbcc4099549da1461f146bcbaffceacc50d76d9b | |
| parent | 27dddad834d99e9901b4a9b137748b850e71849a (diff) | |
featureflag: Enable atomic repository creation by default
With f87bc1e98 (Merge branch 'pks-create-repository-atomic' into
'master', 2021-11-24), we have implemented support for atomic repository
creation. With this mode, creation of repositories will use locking and
meaningful transactional voting to create repos in a race-free manner.
The feature flag guarding the new behaviour has been rolled out on
December 6th, and no issues have surfaced since then. But the change is
rather high-risk given that it changes semantics of some of the RPCs to
return errors in case the target repository exists already, which wasn't
the case previously. To be on the safe side, we thus want to keep this
feature flag for at least one release such that we have an escape hatch
in case there are issues with this change which we haven't yet seen.
Default-enable the flag.
Changelog: changed
| -rw-r--r-- | internal/metadata/featureflag/ff_tx_atomic_repository_creation.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/metadata/featureflag/ff_tx_atomic_repository_creation.go b/internal/metadata/featureflag/ff_tx_atomic_repository_creation.go index 456f7da0e..81dd1b94b 100644 --- a/internal/metadata/featureflag/ff_tx_atomic_repository_creation.go +++ b/internal/metadata/featureflag/ff_tx_atomic_repository_creation.go @@ -5,4 +5,4 @@ package featureflag // This changes behaviour such the target repository must not exist previous to the call, creation // and seeding of the repository is done in a temporary staging area and then moved into place only // if no other RPC call created it concurrently. -var TxAtomicRepositoryCreation = NewFeatureFlag("tx_atomic_repository_creation", false) +var TxAtomicRepositoryCreation = NewFeatureFlag("tx_atomic_repository_creation", true) |