diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-15 15:01:14 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-24 16:54:07 +0300 |
| commit | 081157d4fd9b228fbdb78d4438abfe2ec6aac3cf (patch) | |
| tree | f89dc5477444234a673c0c65080a61c3ca48248a | |
| parent | 232a13c37ff758e733052e40e12fc8ca128868f1 (diff) | |
Makefile: Remove comment stating that `coverage` doesn't fail
The `coverage` Makefile target used to not fail in the past. Nowadays it
does though because it executes `run_go_tests` on its own.
| -rw-r--r-- | Makefile | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -481,9 +481,8 @@ rubocop: ${SOURCE_DIR}/.ruby-bundle ## Generate coverage report via Go tests. cover: TEST_OPTIONS := ${TEST_OPTIONS} -coverprofile "${COVERAGE_DIR}/all.merged" cover: prepare-tests libgit2 ${GOCOVER_COBERTURA} - ${Q}echo "NOTE: make cover does not exit 1 on failure, don't use it to check for tests success!" + ${Q}rm -rf "${COVERAGE_DIR}" ${Q}mkdir -p "${COVERAGE_DIR}" - ${Q}rm -f "${COVERAGE_DIR}/all.merged" "${COVERAGE_DIR}/all.html" ${Q}$(call run_go_tests) ${Q}go tool cover -html "${COVERAGE_DIR}/all.merged" -o "${COVERAGE_DIR}/all.html" @ # sed is used below to convert file paths to repository root relative paths. See https://gitlab.com/gitlab-org/gitlab/-/issues/217664 |