diff options
| author | Toon Claes <toon@gitlab.com> | 2023-01-25 14:09:43 +0300 |
|---|---|---|
| committer | Toon Claes <toon@gitlab.com> | 2023-01-25 14:09:43 +0300 |
| commit | 0642df411de97fbb4ec254e64a1ba733d3c068bc (patch) | |
| tree | 171761f0281c099a762d389e424d1ff35bc5ecbd | |
| parent | 69e486270838efbbb78e6736ac6aecde5ccd8caa (diff) | |
| parent | d763b7b6d196664921a5e7e3dd15c7c6e96f2843 (diff) | |
Merge branch 'pks-dangerfile-fix-changes-size-with-renames' into 'master'
Dangerfile: Fix segfault when computing change size with renamed files
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5279
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
| -rw-r--r-- | danger/rules/changes_size/Dangerfile | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/danger/rules/changes_size/Dangerfile b/danger/rules/changes_size/Dangerfile index 841b373f7..fc3b6f118 100644 --- a/danger/rules/changes_size/Dangerfile +++ b/danger/rules/changes_size/Dangerfile @@ -5,7 +5,11 @@ thresholds = helper.config.code_size_thresholds lines_changed = (git.added_files + git.modified_files).sum do |file| next 0 if file.end_with?('.pb.go') || file.end_with?('_pb.rb') - git.info_for_file(file)[:insertions] + info = git.info_for_file(file) + + next 0 if info.nil? + + info[:insertions] end if lines_changed > thresholds[:high] |