diff options
author | Rémy Coutable <remy@rymai.me> | 2022-03-15 19:44:12 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2022-03-15 20:23:06 +0300 |
commit | d1ecda7b67e1f239fb90dd1cefaef9139ac19d52 (patch) | |
tree | e8624495219ff5827b76d2c6676c8a3b2ecb166d | |
parent | f69b4e9fd337a8ce1e344c421d7497fc4f88f5b6 (diff) |
Use the changelog rule from `gitlab-dangerfiles`
The rule was introduced in
https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/releases/v2.9.0
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rw-r--r-- | danger/rules/changelog/Dangerfile | 91 |
1 files changed, 0 insertions, 91 deletions
diff --git a/danger/rules/changelog/Dangerfile b/danger/rules/changelog/Dangerfile deleted file mode 100644 index e1079b78a..000000000 --- a/danger/rules/changelog/Dangerfile +++ /dev/null @@ -1,91 +0,0 @@ -require 'yaml' - -def lint_commit(commit) - trailer = commit.message.match(/^(?<name>Changelog):\s*(?<category>.+)$/i) - - return :missing if trailer.nil? || trailer[:category].nil? - - name = trailer[:name] - - unless name == 'Changelog' - self.fail( - "The changelog trailer for commit #{commit.sha} must be `Changelog` (starting with a capital C), not `#{name}`" - ) - - return :invalid - end - - category = trailer[:category] - - return :valid if CATEGORIES.include?(category) - - self.fail( - "Commit #{commit.sha} uses an invalid changelog category: #{category}" - ) - - :invalid -end - -def presented_no_changelog_labels - NO_CHANGELOG_LABELS.map { |label| %(~"#{label}") }.join(', ') -end - -NO_CHANGELOG_LABELS = [ - 'documentation', - 'type::tooling', - 'tooling::pipelines', - 'tooling::workflow', - 'ci-build', - 'meta' -].freeze - -CATEGORIES = YAML - .load_file(File.expand_path('../../../.gitlab/changelog_config.yml', __dir__)) - .fetch('categories') - .keys - .freeze - -SEE_DOC = "See [the documentation](https://docs.gitlab.com/ee/development/changelog.html).".freeze - -CHANGELOG_MISSING = <<~MSG.freeze -**[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html).** - -To ceate a changelog, annotate one or more commits with the `Changelog` Git -trailer. If you want to annotate the latest commit, you can do so using `git -commit --amend`. If you want to annotate older or multiple commits, you need to -do so using `git rebase -i`. - -When adding the trailer, you can use the following values: - -- #{CATEGORIES.join("\n- ")} - -For example: - -``` -This is the subject of your commit. - -This would be the body of your commit containing some extra details. - -Changelog: added -``` - -If your merge request doesn't warrant a CHANGELOG entry, consider adding any of -the #{presented_no_changelog_labels} labels. - -#{SEE_DOC} -MSG - -changelog_needed = (gitlab.mr_labels & NO_CHANGELOG_LABELS).empty? - -if changelog_needed - checked = 0 - - git.commits.each do |commit| - case lint_commit(commit) - when :valid, :invalid - checked += 1 - end - end - - warn(CHANGELOG_MISSING) if checked.zero? -end |