Test beginning a transaction fails without a relative path

This commit adds a test for ensuring we return a proper error when a
transaction is begun without a relative path provided. This would not
happen in production as we validate relative paths already in the
transaction middleware but is here for thoroughness and to ease
troubleshooting.

2 files changed, 13 insertions, 1 deletions

diff --git a/internal/gitaly/storage/storagemgr/transaction_manager.go b/internal/gitaly/storage/storagemgr/transaction_manager.go
index 7654edd9f..9099c1cfe 100644
--- a/internal/gitaly/storage/storagemgr/transaction_manager.go
+++ b/internal/gitaly/storage/storagemgr/transaction_manager.go
@@ -49,6 +49,9 @@ var (
 	errInitializationFailed = errors.New("initializing transaction processing failed")
 	// errNotDirectory is returned when the repository's path doesn't point to a directory
 	errNotDirectory = errors.New("repository's path didn't point to a directory")
+	// errRelativePathNotSet is returned when a transaction is begun without providing a relative path
+	// of the target repository.
+	errRelativePathNotSet = errors.New("relative path not set")
 )
 
 // InvalidReferenceFormatError is returned when a reference name was invalid.
@@ -225,7 +228,7 @@ func (mgr *TransactionManager) Begin(ctx context.Context, relativePath string, r
 	if relativePath == "" {
 		// For now we don't have a use case for transactions that don't target a repository.
 		// Until support is implemented, error out.
-		return nil, errors.New("relative path not set")
+		return nil, errRelativePathNotSet
 	}
 
 	mgr.mutex.Lock()
diff --git a/internal/gitaly/storage/storagemgr/transaction_manager_test.go b/internal/gitaly/storage/storagemgr/transaction_manager_test.go
index a99d1b158..1aaeb9451 100644
--- a/internal/gitaly/storage/storagemgr/transaction_manager_test.go
+++ b/internal/gitaly/storage/storagemgr/transaction_manager_test.go
@@ -4720,6 +4720,15 @@ func TestTransactionManager(t *testing.T) {
 				},
 			},
 		},
+		{
+			desc: "start transaction with empty relative path",
+			steps: steps{
+				StartManager{},
+				Begin{
+					ExpectedError: errRelativePathNotSet,
+				},
+			},
+		},
 	}
 
 	type invalidReferenceTestCase struct {