diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-04-01 17:22:36 +0300 |
|---|---|---|
| committer | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-04-01 17:22:36 +0300 |
| commit | 5e8af134ced1d204217c0145c16206c5ac343fed (patch) | |
| tree | 79f16dcb6abe59a2fbec2a3428e594405ba56352 | |
| parent | 071db2de108f6fd3ebcce81e1f8270d8a582dba5 (diff) | |
Remove unused Ruby implementation of GetRawChanges
Ported in https://gitlab.com/gitlab-org/gitaly/merge_requests/1026, over
two months ago. This makes it safe to remove now.
| -rw-r--r-- | changelogs/unreleased/zj-remove-get-raw-changes-ruby.yml | 5 | ||||
| -rw-r--r-- | ruby/lib/gitaly_server/repository_service.rb | 19 |
2 files changed, 5 insertions, 19 deletions
diff --git a/changelogs/unreleased/zj-remove-get-raw-changes-ruby.yml b/changelogs/unreleased/zj-remove-get-raw-changes-ruby.yml new file mode 100644 index 000000000..0f08c0b87 --- /dev/null +++ b/changelogs/unreleased/zj-remove-get-raw-changes-ruby.yml @@ -0,0 +1,5 @@ +--- +title: Remove unused Ruby implementation of GetRawChanges +merge_request: 1169 +author: +type: other diff --git a/ruby/lib/gitaly_server/repository_service.rb b/ruby/lib/gitaly_server/repository_service.rb index edbe2011f..23e55b352 100644 --- a/ruby/lib/gitaly_server/repository_service.rb +++ b/ruby/lib/gitaly_server/repository_service.rb @@ -81,25 +81,6 @@ module GitalyServer Gitaly::FindLicenseResponse.new(license_short_name: short_name || "") end - # TODO: remove after 11.8 because of https://gitlab.com/gitlab-org/gitaly/merge_requests/1026 - def get_raw_changes(request, call) - repo = Gitlab::Git::Repository.from_gitaly(request.repository, call) - - changes = begin - repo - .raw_changes_between(request.from_revision, request.to_revision) - .map { |c| to_proto_raw_change(c) } - rescue ::Gitlab::Git::Repository::GitError => e - raise GRPC::InvalidArgument.new(e.message) - end - - Enumerator.new do |y| - changes.each_slice(100) do |batch| - y.yield Gitaly::GetRawChangesResponse.new(raw_changes: batch) - end - end - end - private OPERATION_MAP = { |